Fixed failing test after drawio default url change

[bookstack] / tests / Entity / PageRevisionTest.php

diff --git a/tests/Entity/PageRevisionTest.php b/tests/Entity/PageRevisionTest.php
index 62fbfbf3140d46b1544b9af26fdb60e38a4c8f9b..fc6678788636df222c405f34e58823643b4c3be2 100644 (file)
--- a/tests/Entity/PageRevisionTest.php
+++ b/tests/Entity/PageRevisionTest.php
@@ -1,4 +1,6 @@
-<?php namespace Tests\Entity;
+<?php
+
+namespace Tests\Entity;

 
 use BookStack\Entities\Models\Page;
 use BookStack\Entities\Repos\PageRepo;
 
 use BookStack\Entities\Models\Page;
 use BookStack\Entities\Repos\PageRepo;


@@ -47,8 +49,7 @@ class PageRevisionTest extends TestCase
         $page = Page::first();
         $pageRepo->update($page, ['name' => 'updated page abc123', 'html' => '<p>new contente def456</p>', 'summary' => 'initial page revision testing']);
         $pageRepo->update($page, ['name' => 'updated page again', 'html' => '<p>new content</p>', 'summary' => 'page revision testing']);
         $page = Page::first();
         $pageRepo->update($page, ['name' => 'updated page abc123', 'html' => '<p>new contente def456</p>', 'summary' => 'initial page revision testing']);
         $pageRepo->update($page, ['name' => 'updated page again', 'html' => '<p>new content</p>', 'summary' => 'page revision testing']);

-        $page =  Page::find($page->id);
-
+        $page = Page::find($page->id);

 
         $pageView = $this->get($page->getUrl());
         $pageView->assertDontSee('abc123');
 
         $pageView = $this->get($page->getUrl());
         $pageView->assertDontSee('abc123');


@@ -56,7 +57,7 @@ class PageRevisionTest extends TestCase
 
         $revToRestore = $page->revisions()->where('name', 'like', '%abc123')->first();
         $restoreReq = $this->put($page->getUrl() . '/revisions/' . $revToRestore->id . '/restore');
 
         $revToRestore = $page->revisions()->where('name', 'like', '%abc123')->first();
         $restoreReq = $this->put($page->getUrl() . '/revisions/' . $revToRestore->id . '/restore');

-        $page =  Page::find($page->id);
+        $page = Page::find($page->id);

 
         $restoreReq->assertStatus(302);
         $restoreReq->assertRedirect($page->getUrl());
 
         $restoreReq->assertStatus(302);
         $restoreReq->assertRedirect($page->getUrl());


@@ -89,7 +90,7 @@ class PageRevisionTest extends TestCase
 
         $pageView = $this->get($page->getUrl());
         $this->assertDatabaseHas('pages', [
 
         $pageView = $this->get($page->getUrl());
         $this->assertDatabaseHas('pages', [

-            'id' => $page->id,
+            'id'       => $page->id,

             'markdown' => '## New Content def456',
         ]);
         $pageView->assertSee('abc123');
             'markdown' => '## New Content def456',
         ]);
         $pageView->assertSee('abc123');


@@ -112,8 +113,8 @@ class PageRevisionTest extends TestCase
 
         $this->assertDatabaseHas('page_revisions', [
             'page_id' => $page->id,
 
         $this->assertDatabaseHas('page_revisions', [
             'page_id' => $page->id,

-            'text' => 'new contente def456',
-            'type' => 'version',
+            'text'    => 'new contente def456',
+            'type'    => 'version',

             'summary' => "Restored from #{$revToRestore->id}; My first update",
         ]);
     }
             'summary' => "Restored from #{$revToRestore->id}; My first update",
         ]);
     }


@@ -125,7 +126,7 @@ class PageRevisionTest extends TestCase
         $resp = $this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
         $resp->assertStatus(302);
 
         $resp = $this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
         $resp->assertStatus(302);
 

-        $this->assertTrue(Page::find($page->id)->revision_count === $startCount+1);
+        $this->assertTrue(Page::find($page->id)->revision_count === $startCount + 1);

     }
 
     public function test_revision_count_shown_in_page_meta()
     }
 
     public function test_revision_count_shown_in_page_meta()


@@ -141,14 +142,16 @@ class PageRevisionTest extends TestCase
         $pageView->assertSee('Revision #' . $page->revision_count);
     }
 
         $pageView->assertSee('Revision #' . $page->revision_count);
     }
 

-    public function test_revision_deletion() {
-        $page = Page::first();
+    public function test_revision_deletion()
+    {
+        /** @var Page $page */
+        $page = Page::query()->first();

         $this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
 
         $this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
 

-        $page = Page::find($page->id);
+        $page->refresh();

         $this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
 
         $this->asEditor()->put($page->getUrl(), ['name' => 'Updated page', 'html' => 'new page html', 'summary' => 'Update a']);
 

-        $page = Page::find($page->id);
+        $page->refresh();

         $beforeRevisionCount = $page->revisions->count();
 
         // Delete the first revision
         $beforeRevisionCount = $page->revisions->count();
 
         // Delete the first revision


@@ -156,18 +159,17 @@ class PageRevisionTest extends TestCase
         $resp = $this->asEditor()->delete($revision->getUrl('/delete/'));
         $resp->assertRedirect($page->getUrl('/revisions'));
 
         $resp = $this->asEditor()->delete($revision->getUrl('/delete/'));
         $resp->assertRedirect($page->getUrl('/revisions'));
 

-        $page = Page::find($page->id);
+        $page->refresh();

         $afterRevisionCount = $page->revisions->count();
 
         $this->assertTrue($beforeRevisionCount === ($afterRevisionCount + 1));
 
         // Try to delete the latest revision
         $beforeRevisionCount = $page->revisions->count();
         $afterRevisionCount = $page->revisions->count();
 
         $this->assertTrue($beforeRevisionCount === ($afterRevisionCount + 1));
 
         // Try to delete the latest revision
         $beforeRevisionCount = $page->revisions->count();

-        $currentRevision = $page->getCurrentRevision();
-        $resp = $this->asEditor()->delete($currentRevision->getUrl('/delete/'));
+        $resp = $this->asEditor()->delete($page->currentRevision->getUrl('/delete/'));

         $resp->assertRedirect($page->getUrl('/revisions'));
 
         $resp->assertRedirect($page->getUrl('/revisions'));
 

-        $page = Page::find($page->id);
+        $page->refresh();

         $afterRevisionCount = $page->revisions->count();
         $this->assertTrue($beforeRevisionCount === $afterRevisionCount);
     }
         $afterRevisionCount = $page->revisions->count();
         $this->assertTrue($beforeRevisionCount === $afterRevisionCount);
     }


@@ -201,4 +203,4 @@ class PageRevisionTest extends TestCase
         $revisionCount = $page->revisions()->count();
         $this->assertEquals(12, $revisionCount);
     }
         $revisionCount = $page->revisions()->count();
         $this->assertEquals(12, $revisionCount);
     }

-}
\ No newline at end of file
+}