Testing: Added entity decode flag and phpunit env option

[bookstack] / resources / js / components / dropdown.js

diff --git a/resources/js/components/dropdown.js b/resources/js/components/dropdown.js
index ed69088b29acae227a9f57557406299a74e71459..2c5919a37e755d9fa8e3facc0a8f226612dff468 100644 (file)
--- a/resources/js/components/dropdown.js
+++ b/resources/js/components/dropdown.js
@@ -1,6 +1,6 @@
-import {onSelect} from "../services/dom";
-import {KeyboardNavigationHandler} from "../services/keyboard-navigation";
-import {Component} from "./component";
+import {onSelect} from '../services/dom';
+import {KeyboardNavigationHandler} from '../services/keyboard-navigation';
+import {Component} from './component';

 
 /**
  * Dropdown
 
 /**
  * Dropdown


@@ -41,7 +41,11 @@ export class Dropdown extends Component {
             this.menu.style.position = 'fixed';
             this.menu.style.width = `${menuOriginalRect.width}px`;
             this.menu.style.left = `${menuOriginalRect.left}px`;
             this.menu.style.position = 'fixed';
             this.menu.style.width = `${menuOriginalRect.width}px`;
             this.menu.style.left = `${menuOriginalRect.left}px`;

-            heightOffset = dropUpwards ? (window.innerHeight - menuOriginalRect.top  - toggleHeight / 2) : menuOriginalRect.top;
+            if (dropUpwards) {
+                heightOffset = (window.innerHeight - menuOriginalRect.top - toggleHeight / 2);
+            } else {
+                heightOffset = menuOriginalRect.top;
+            }

         }
 
         // Adjust menu to display upwards if near the bottom of the screen
         }
 
         // Adjust menu to display upwards if near the bottom of the screen


@@ -55,8 +59,8 @@ export class Dropdown extends Component {
 
         // Set listener to hide on mouse leave or window click
         this.menu.addEventListener('mouseleave', this.hide);
 
         // Set listener to hide on mouse leave or window click
         this.menu.addEventListener('mouseleave', this.hide);

-        window.addEventListener('click', event => {
-            if (!this.menu.contains(event.target)) {
+        window.addEventListener('click', clickEvent => {
+            if (!this.menu.contains(clickEvent.target)) {

                 this.hide();
             }
         });
                 this.hide();
             }
         });


@@ -76,7 +80,7 @@ export class Dropdown extends Component {
     }
 
     hideAll() {
     }
 
     hideAll() {

-        for (let dropdown of window.$components.get('dropdown')) {
+        for (const dropdown of window.$components.get('dropdown')) {

             dropdown.hide();
         }
     }
             dropdown.hide();
         }
     }


@@ -100,13 +104,13 @@ export class Dropdown extends Component {
     }
 
     setupListeners() {
     }
 
     setupListeners() {

-        const keyboardNavHandler = new KeyboardNavigationHandler(this.container, (event) => {
+        const keyboardNavHandler = new KeyboardNavigationHandler(this.container, event => {

             this.hide();
             this.toggle.focus();
             if (!this.bubbleEscapes) {
                 event.stopPropagation();
             }
             this.hide();
             this.toggle.focus();
             if (!this.bubbleEscapes) {
                 event.stopPropagation();
             }

-        }, (event) => {
+        }, event => {

             if (event.target.nodeName === 'INPUT') {
                 event.preventDefault();
                 event.stopPropagation();
             if (event.target.nodeName === 'INPUT') {
                 event.preventDefault();
                 event.stopPropagation();


@@ -120,14 +124,15 @@ export class Dropdown extends Component {
 
         // Hide menu on option click
         this.container.addEventListener('click', event => {
 
         // Hide menu on option click
         this.container.addEventListener('click', event => {

-             const possibleChildren = Array.from(this.menu.querySelectorAll('a'));
-             if (possibleChildren.includes(event.target)) {
-                 this.hide();
-             }
+            const possibleChildren = Array.from(this.menu.querySelectorAll('a'));
+            if (possibleChildren.includes(event.target)) {
+                this.hide();
+            }

         });
 
         onSelect(this.toggle, event => {
             event.stopPropagation();
         });
 
         onSelect(this.toggle, event => {
             event.stopPropagation();

+            event.preventDefault();

             this.show(event);
             if (event instanceof KeyboardEvent) {
                 keyboardNavHandler.focusNext();
             this.show(event);
             if (event instanceof KeyboardEvent) {
                 keyboardNavHandler.focusNext();