Fixes for CodeStyle vol.2

[bookstack] / tests / Entity / PageTest.php

diff --git a/tests/Entity/PageTest.php b/tests/Entity/PageTest.php
index 4fc6b9c16175b992cd5784ca5c7cd5729118b1fe..2721c225cd66c487f823d6e075e552f406ce6549 100644 (file)
--- a/tests/Entity/PageTest.php
+++ b/tests/Entity/PageTest.php
@@ -1,4 +1,6 @@
-<?php namespace Tests\Entity;
+<?php
+
+namespace Tests\Entity;

 
 use BookStack\Entities\Models\Book;
 use BookStack\Entities\Models\Page;
 
 use BookStack\Entities\Models\Book;
 use BookStack\Entities\Models\Page;


@@ -6,6 +8,21 @@ use Tests\TestCase;
 
 class PageTest extends TestCase
 {
 
 class PageTest extends TestCase
 {

+    public function test_page_view_when_creator_is_deleted_but_owner_exists()
+    {
+        $page = Page::query()->first();
+        $user = $this->getViewer();
+        $owner = $this->getEditor();
+        $page->created_by = $user->id;
+        $page->owned_by = $owner->id;
+        $page->save();
+        $user->delete();
+
+        $resp = $this->asAdmin()->get($page->getUrl());
+        $resp->assertStatus(200);
+        $resp->assertSeeText('Owned by ' . $owner->name);
+    }
+

     public function test_page_creation_with_markdown_content()
     {
         $this->setSettings(['app-editor' => 'markdown']);
     public function test_page_creation_with_markdown_content()
     {
         $this->setSettings(['app-editor' => 'markdown']);


@@ -17,22 +34,22 @@ class PageTest extends TestCase
 
         $details = [
             'markdown' => '# a title',
 
         $details = [
             'markdown' => '# a title',

-            'html' => '<h1>a title</h1>',
-            'name' => 'my page',
+            'html'     => '<h1>a title</h1>',
+            'name'     => 'my page',

         ];
         $resp = $this->post($book->getUrl("/draft/{$draft->id}"), $details);
         $resp->assertRedirect();
 
         $this->assertDatabaseHas('pages', [
             'markdown' => $details['markdown'],
         ];
         $resp = $this->post($book->getUrl("/draft/{$draft->id}"), $details);
         $resp->assertRedirect();
 
         $this->assertDatabaseHas('pages', [
             'markdown' => $details['markdown'],

-            'name' => $details['name'],
-            'id' => $draft->id,
-            'draft' => false
+            'name'     => $details['name'],
+            'id'       => $draft->id,
+            'draft'    => false,

         ]);
 
         $draft->refresh();
         ]);
 
         $draft->refresh();

-        $resp = $this->get($draft->getUrl("/edit"));
-        $resp->assertSee("# a title");
+        $resp = $this->get($draft->getUrl('/edit'));
+        $resp->assertSee('# a title');

     }
 
     public function test_page_delete()
     }
 
     public function test_page_delete()


@@ -55,6 +72,33 @@ class PageTest extends TestCase
         $redirectReq->assertNotificationContains('Page Successfully Deleted');
     }
 
         $redirectReq->assertNotificationContains('Page Successfully Deleted');
     }
 

+    public function test_page_full_delete_removes_all_revisions()
+    {
+        /** @var Page $page */
+        $page = Page::query()->first();
+        $page->revisions()->create([
+            'html' => '<p>ducks</p>',
+            'name' => 'my page revision',
+            'type' => 'draft',
+        ]);
+        $page->revisions()->create([
+            'html' => '<p>ducks</p>',
+            'name' => 'my page revision',
+            'type' => 'revision',
+        ]);
+
+        $this->assertDatabaseHas('page_revisions', [
+            'page_id' => $page->id,
+        ]);
+
+        $this->asEditor()->delete($page->getUrl());
+        $this->asAdmin()->post('/settings/recycle-bin/empty');
+
+        $this->assertDatabaseMissing('page_revisions', [
+            'page_id' => $page->id,
+        ]);
+    }
+

     public function test_page_copy()
     {
         $page = Page::first();
     public function test_page_copy()
     {
         $page = Page::first();


@@ -69,7 +113,7 @@ class PageTest extends TestCase
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,

-            'name' => 'My copied test page'
+            'name'             => 'My copied test page',

         ]);
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
 
         ]);
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
 


@@ -88,7 +132,7 @@ class PageTest extends TestCase
 
         $this->asEditor()->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,
 
         $this->asEditor()->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,

-            'name' => 'My copied test page'
+            'name'             => 'My copied test page',

         ]);
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
 
         ]);
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
 


@@ -105,7 +149,7 @@ class PageTest extends TestCase
         $resp->assertSee('Copy Page');
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
         $resp->assertSee('Copy Page');
 
         $movePageResp = $this->post($page->getUrl('/copy'), [

-            'name' => 'My copied test page'
+            'name' => 'My copied test page',

         ]);
 
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();
         ]);
 
         $pageCopy = Page::where('name', '=', 'My copied test page')->first();


@@ -135,14 +179,37 @@ class PageTest extends TestCase
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,
 
         $movePageResp = $this->post($page->getUrl('/copy'), [
             'entity_selection' => 'book:' . $newBook->id,

-            'name' => 'My copied test page'
+            'name'             => 'My copied test page',

         ]);
         $movePageResp->assertRedirect();
 
         $this->assertDatabaseHas('pages', [
         ]);
         $movePageResp->assertRedirect();
 
         $this->assertDatabaseHas('pages', [

-            'name' => 'My copied test page',
+            'name'       => 'My copied test page',

             'created_by' => $viewer->id,
             'created_by' => $viewer->id,

-            'book_id' => $newBook->id,
+            'book_id'    => $newBook->id,
+        ]);
+    }
+
+    public function test_empty_markdown_still_saves_without_error()
+    {
+        $this->setSettings(['app-editor' => 'markdown']);
+        $book = Book::query()->first();
+
+        $this->asEditor()->get($book->getUrl('/create-page'));
+        $draft = Page::query()->where('book_id', '=', $book->id)
+            ->where('draft', '=', true)->first();
+
+        $details = [
+            'name'     => 'my page',
+            'markdown' => '',
+        ];
+        $resp = $this->post($book->getUrl("/draft/{$draft->id}"), $details);
+        $resp->assertRedirect();
+
+        $this->assertDatabaseHas('pages', [
+            'markdown' => $details['markdown'],
+            'id'       => $draft->id,
+            'draft'    => false,

         ]);
     }
         ]);
     }

-}
\ No newline at end of file
+}