Fixed OIDC Logout

[bookstack] / tests / ErrorTest.php

diff --git a/tests/ErrorTest.php b/tests/ErrorTest.php
index 1558df78d1c200d59b29d559ceef38f687b81e4f..6ba01dd88e6ed8dfb094e637f3cbf6ed1ea6cfe1 100644 (file)
--- a/tests/ErrorTest.php
+++ b/tests/ErrorTest.php
@@ -1,17 +1,17 @@
-<?php namespace Tests;
+<?php
+
+namespace Tests;

 
 

-use BookStack\Entities\Models\Book;

 use Illuminate\Support\Facades\Log;
 
 class ErrorTest extends TestCase
 {
 use Illuminate\Support\Facades\Log;
 
 class ErrorTest extends TestCase
 {

-

     public function test_404_page_does_not_show_login()
     {
         // Due to middleware being handled differently this will not fail
         // if our custom, middleware-loaded handler fails but this is here
         // as a reminder and as a general check in the event of other issues.
     public function test_404_page_does_not_show_login()
     {
         // Due to middleware being handled differently this will not fail
         // if our custom, middleware-loaded handler fails but this is here
         // as a reminder and as a general check in the event of other issues.

-        $editor = $this->getEditor();
+        $editor = $this->users->editor();

         $editor->name = 'tester';
         $editor->save();
 
         $editor->name = 'tester';
         $editor->save();
 


@@ -24,9 +24,9 @@ class ErrorTest extends TestCase
 
     public function test_item_not_found_does_not_get_logged_to_file()
     {
 
     public function test_item_not_found_does_not_get_logged_to_file()
     {

-        $this->actingAs($this->getViewer());
+        $this->actingAs($this->users->viewer());

         $handler = $this->withTestLogger();
         $handler = $this->withTestLogger();

-        $book = Book::query()->first();
+        $book = $this->entities->book();

 
         // Ensure we're seeing errors
         Log::error('cat');
 
         // Ensure we're seeing errors
         Log::error('cat');


@@ -38,4 +38,11 @@ class ErrorTest extends TestCase
 
         $this->assertCount(1, $handler->getRecords());
     }
 
         $this->assertCount(1, $handler->getRecords());
     }

-}
\ No newline at end of file
+
+    public function test_access_to_non_existing_image_location_provides_404_response()
+    {
+        $resp = $this->actingAs($this->users->viewer())->get('/uploads/images/gallery/2021-05/anonexistingimage.png');
+        $resp->assertStatus(404);
+        $resp->assertSeeText('Image Not Found');
+    }
+}