Covered app icon setting with testing

[bookstack] / app / Http / Controllers / SettingController.php

diff --git a/app/Http/Controllers/SettingController.php b/app/Http/Controllers/SettingController.php
index 70a12631a2929d43424149208a79350697caaa4b..1e13d7cb77ed4001598f2cb8a85bbde357e7ea6c 100644 (file)
--- a/app/Http/Controllers/SettingController.php
+++ b/app/Http/Controllers/SettingController.php
@@ -1,45 +1,69 @@
-<?php namespace BookStack\Http\Controllers;
+<?php

 
 

+namespace BookStack\Http\Controllers;
+
+use BookStack\Actions\ActivityType;
+use BookStack\Auth\User;
+use BookStack\Settings\AppSettingsStore;
+use BookStack\Uploads\ImageRepo;

 use Illuminate\Http\Request;
 use Illuminate\Http\Request;

-use Illuminate\Http\Response;
-use Setting;

 
 class SettingController extends Controller
 {
 
 class SettingController extends Controller
 {

+    protected array $settingCategories = ['features', 'customization', 'registration'];
+

     /**
     /**

-     * Display a listing of the settings.
-     * @return Response
+     * Handle requests to the settings index path.

      */
     public function index()
     {
      */
     public function index()
     {

+        return redirect('/settings/features');
+    }
+
+    /**
+     * Display the settings for the given category.
+     */
+    public function category(string $category)
+    {
+        $this->ensureCategoryExists($category);

         $this->checkPermission('settings-manage');
         $this->checkPermission('settings-manage');

-        $this->setPageTitle('Settings');
+        $this->setPageTitle(trans('settings.settings'));

 
         // Get application version
         $version = trim(file_get_contents(base_path('version')));
 
 
         // Get application version
         $version = trim(file_get_contents(base_path('version')));
 

-        return view('settings/index', ['version' => $version]);
+        return view('settings.' . $category, [
+            'category'  => $category,
+            'version'   => $version,
+            'guestUser' => User::getDefault(),
+        ]);

     }
 
     /**
      * Update the specified settings in storage.
     }
 
     /**
      * Update the specified settings in storage.

-     * @param  Request $request
-     * @return Response

      */
      */

-    public function update(Request $request)
+    public function update(Request $request, AppSettingsStore $store, string $category)

     {
     {

-        $this->preventAccessForDemoUsers();
+        $this->ensureCategoryExists($category);
+        $this->preventAccessInDemoMode();

         $this->checkPermission('settings-manage');
         $this->checkPermission('settings-manage');

+        $this->validate($request, [
+            'app_logo' => ['nullable', ...$this->getImageValidationRules()],
+            'app_icon' => ['nullable', ...$this->getImageValidationRules()],
+        ]);

 
 

-        // Cycles through posted settings and update them
-        foreach ($request->all() as $name => $value) {
-            if (strpos($name, 'setting-') !== 0) continue;
-            $key = str_replace('setting-', '', trim($name));
-            Setting::put($key, $value);
-        }
+        $store->storeFromUpdateRequest($request, $category);
+
+        $this->logActivity(ActivityType::SETTINGS_UPDATE, $category);
+        $this->showSuccessNotification(trans('settings.settings_save_success'));

 
 

-        session()->flash('success', trans('settings.settings_save_success'));
-        return redirect('/settings');
+        return redirect("/settings/{$category}");

     }
 
     }
 

+    protected function ensureCategoryExists(string $category): void
+    {
+        if (!in_array($category, $this->settingCategories)) {
+            abort(404);
+        }
+    }

 }
 }