fix deprecated syntax

[bookstack] / app / Uploads / UserAvatars.php

diff --git a/app/Uploads/UserAvatars.php b/app/Uploads/UserAvatars.php
index 3cd37812acbd40f14aec23ae2bb1d386a49df693..c623247352b17234cd60168fb7686f19375478bc 100644 (file)
--- a/app/Uploads/UserAvatars.php
+++ b/app/Uploads/UserAvatars.php
@@ -3,20 +3,20 @@
 namespace BookStack\Uploads;
 
 use BookStack\Exceptions\HttpFetchException;
 namespace BookStack\Uploads;
 
 use BookStack\Exceptions\HttpFetchException;

+use BookStack\Http\HttpRequestService;

 use BookStack\Users\Models\User;
 use Exception;
 use BookStack\Users\Models\User;
 use Exception;

+use GuzzleHttp\Psr7\Request;

 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Str;
 use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Str;

+use Psr\Http\Client\ClientExceptionInterface;

 
 class UserAvatars
 {
 
 class UserAvatars
 {

-    protected $imageService;
-    protected $http;
-
-    public function __construct(ImageService $imageService, HttpFetcher $http)
-    {
-        $this->imageService = $imageService;
-        $this->http = $http;
+    public function __construct(
+        protected ImageService $imageService,
+        protected HttpRequestService $http
+    ) {

     }
 
     /**
     }
 
     /**


@@ -56,7 +56,7 @@ class UserAvatars
     /**
      * Destroy all user avatars uploaded to the given user.
      */
     /**
      * Destroy all user avatars uploaded to the given user.
      */

-    public function destroyAllForUser(User $user)
+    public function destroyAllForUser(User $user): void

     {
         $profileImages = Image::query()->where('type', '=', 'user')
             ->where('uploaded_to', '=', $user->id)
     {
         $profileImages = Image::query()->where('type', '=', 'user')
             ->where('uploaded_to', '=', $user->id)


@@ -70,7 +70,7 @@ class UserAvatars
     /**
      * Save an avatar image from an external service.
      *
     /**
      * Save an avatar image from an external service.
      *

-     * @throws Exception
+     * @throws HttpFetchException

      */
     protected function saveAvatarImage(User $user, int $size = 500): Image
     {
      */
     protected function saveAvatarImage(User $user, int $size = 500): Image
     {


@@ -112,28 +112,32 @@ class UserAvatars
     protected function getAvatarImageData(string $url): string
     {
         try {
     protected function getAvatarImageData(string $url): string
     {
         try {

-            $imageData = $this->http->fetch($url);
-        } catch (HttpFetchException $exception) {
+            $client = $this->http->buildClient(5);
+            $response = $client->sendRequest(new Request('GET', $url));
+            if ($response->getStatusCode() !== 200) {
+                throw new HttpFetchException(trans('errors.cannot_get_image_from_url', ['url' => $url]));
+            }
+
+            return (string) $response->getBody();
+        } catch (ClientExceptionInterface $exception) {

             throw new HttpFetchException(trans('errors.cannot_get_image_from_url', ['url' => $url]), $exception->getCode(), $exception);
         }
             throw new HttpFetchException(trans('errors.cannot_get_image_from_url', ['url' => $url]), $exception->getCode(), $exception);
         }

-
-        return $imageData;

     }
 
     /**
      * Check if fetching external avatars is enabled.
      */
     }
 
     /**
      * Check if fetching external avatars is enabled.
      */

-    protected function avatarFetchEnabled(): bool
+    public function avatarFetchEnabled(): bool

     {
         $fetchUrl = $this->getAvatarUrl();
 
     {
         $fetchUrl = $this->getAvatarUrl();
 

-        return is_string($fetchUrl) && strpos($fetchUrl, 'http') === 0;
+        return str_starts_with($fetchUrl, 'http');

     }
 
     /**
      * Get the URL to fetch avatars from.
      */
     }
 
     /**
      * Get the URL to fetch avatars from.
      */

-    protected function getAvatarUrl(): string
+    public function getAvatarUrl(): string

     {
         $configOption = config('services.avatar_url');
         if ($configOption === false) {
     {
         $configOption = config('services.avatar_url');
         if ($configOption === false) {