Fixed local_secure_restricted preventing attachment uploads

[bookstack] / tests / HomepageTest.php

diff --git a/tests/HomepageTest.php b/tests/HomepageTest.php
index 86cae7893a4b2e4e70f9ae60e1cedb6b4d001e2a..1d968a2c92fdcf79ea009f6165eafd8a31b6fb01 100644 (file)
--- a/tests/HomepageTest.php
+++ b/tests/HomepageTest.php
@@ -1,8 +1,14 @@
-<?php namespace Tests;
+<?php
+
+namespace Tests;
+
+use BookStack\Auth\Role;
+use BookStack\Auth\User;
+use BookStack\Entities\Models\Bookshelf;
+use BookStack\Entities\Models\Page;

 
 class HomepageTest extends TestCase
 {
 
 class HomepageTest extends TestCase
 {

-

     public function test_default_homepage_visible()
     {
         $this->asEditor();
     public function test_default_homepage_visible()
     {
         $this->asEditor();


@@ -36,10 +42,14 @@ class HomepageTest extends TestCase
         $name = 'My custom homepage';
         $content = str_repeat('This is the body content of my custom homepage.', 20);
         $customPage = $this->newPage(['name' => $name, 'html' => $content]);
         $name = 'My custom homepage';
         $content = str_repeat('This is the body content of my custom homepage.', 20);
         $customPage = $this->newPage(['name' => $name, 'html' => $content]);

-        $this->setSettings(['app-homepage' => $customPage->id]);
+        $this->setSettings([
+            'app-homepage'      => $customPage->id,
+            'app-homepage-type' => 'page',
+        ]);

 
         $homeVisit = $this->get('/');
         $homeVisit->assertSee($name);
 
         $homeVisit = $this->get('/');
         $homeVisit->assertSee($name);

+        $this->withHtml($homeVisit)->assertElementNotExists('#home-default');

 
         $pageDeleteReq = $this->delete($customPage->getUrl());
         $pageDeleteReq->assertStatus(302);
 
         $pageDeleteReq = $this->delete($customPage->getUrl());
         $pageDeleteReq->assertStatus(302);


@@ -52,6 +62,60 @@ class HomepageTest extends TestCase
         $homeVisit->assertStatus(200);
     }
 
         $homeVisit->assertStatus(200);
     }
 

+    public function test_custom_homepage_can_be_deleted_once_custom_homepage_no_longer_used()
+    {
+        $this->asEditor();
+        $name = 'My custom homepage';
+        $content = str_repeat('This is the body content of my custom homepage.', 20);
+        $customPage = $this->newPage(['name' => $name, 'html' => $content]);
+        $this->setSettings([
+            'app-homepage'      => $customPage->id,
+            'app-homepage-type' => 'default',
+        ]);
+
+        $pageDeleteReq = $this->delete($customPage->getUrl());
+        $pageDeleteReq->assertStatus(302);
+        $pageDeleteReq->assertSessionHas('success');
+        $pageDeleteReq->assertSessionMissing('error');
+    }
+
+    public function test_custom_homepage_cannot_be_deleted_from_parent_deletion()
+    {
+        /** @var Page $page */
+        $page = Page::query()->first();
+        $this->setSettings([
+            'app-homepage'      => $page->id,
+            'app-homepage-type' => 'page',
+        ]);
+
+        $this->asEditor()->delete($page->book->getUrl());
+        $this->assertSessionError('Cannot delete a page while it is set as a homepage');
+        $this->assertDatabaseMissing('deletions', ['deletable_id' => $page->book->id]);
+
+        $page->refresh();
+        $this->assertNull($page->deleted_at);
+        $this->assertNull($page->book->deleted_at);
+    }
+
+    public function test_custom_homepage_renders_includes()
+    {
+        $this->asEditor();
+        /** @var Page $included */
+        $included = Page::query()->first();
+        $content = str_repeat('This is the body content of my custom homepage.', 20);
+        $included->html = $content;
+        $included->save();
+
+        $name = 'My custom homepage';
+        $customPage = $this->newPage(['name' => $name, 'html' => '{{@' . $included->id . '}}']);
+        $this->setSettings(['app-homepage' => $customPage->id]);
+        $this->setSettings(['app-homepage-type' => 'page']);
+
+        $homeVisit = $this->get('/');
+        $homeVisit->assertSee($name);
+        $homeVisit->assertSee($content);
+    }
+

     public function test_set_book_homepage()
     {
         $editor = $this->getEditor();
     public function test_set_book_homepage()
     {
         $editor = $this->getEditor();


@@ -62,7 +126,7 @@ class HomepageTest extends TestCase
         $this->asEditor();
         $homeVisit = $this->get('/');
         $homeVisit->assertSee('Books');
         $this->asEditor();
         $homeVisit = $this->get('/');
         $homeVisit->assertSee('Books');

-        $homeVisit->assertSee('book-grid-item grid-card');
+        $homeVisit->assertSee('grid-card');

         $homeVisit->assertSee('grid-card-content');
         $homeVisit->assertSee('grid-card-footer');
         $homeVisit->assertSee('featured-image-container');
         $homeVisit->assertSee('grid-card-content');
         $homeVisit->assertSee('grid-card-footer');
         $homeVisit->assertSee('featured-image-container');


@@ -75,18 +139,57 @@ class HomepageTest extends TestCase
     {
         $editor = $this->getEditor();
         setting()->putUser($editor, 'bookshelves_view_type', 'grid');
     {
         $editor = $this->getEditor();
         setting()->putUser($editor, 'bookshelves_view_type', 'grid');

+        $shelf = Bookshelf::query()->firstOrFail();

 
         $this->setSettings(['app-homepage-type' => 'bookshelves']);
 
         $this->asEditor();
         $homeVisit = $this->get('/');
         $homeVisit->assertSee('Shelves');
 
         $this->setSettings(['app-homepage-type' => 'bookshelves']);
 
         $this->asEditor();
         $homeVisit = $this->get('/');
         $homeVisit->assertSee('Shelves');

-        $homeVisit->assertSee('bookshelf-grid-item grid-card');

         $homeVisit->assertSee('grid-card-content');
         $homeVisit->assertSee('grid-card-content');

-        $homeVisit->assertSee('grid-card-footer');

         $homeVisit->assertSee('featured-image-container');
         $homeVisit->assertSee('featured-image-container');

+        $this->withHtml($homeVisit)->assertElementContains('.grid-card', $shelf->name);

 
         $this->setSettings(['app-homepage-type' => false]);
         $this->test_default_homepage_visible();
     }
 
         $this->setSettings(['app-homepage-type' => false]);
         $this->test_default_homepage_visible();
     }

+
+    public function test_shelves_list_homepage_adheres_to_book_visibility_permissions()
+    {
+        $editor = $this->getEditor();
+        setting()->putUser($editor, 'bookshelves_view_type', 'list');
+        $this->setSettings(['app-homepage-type' => 'bookshelves']);
+        $this->asEditor();
+
+        $shelf = Bookshelf::query()->first();
+        $book = $shelf->books()->first();
+
+        // Ensure initially visible
+        $homeVisit = $this->get('/');
+        $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $shelf->name);
+        $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $book->name);
+
+        // Ensure book no longer visible without view permission
+        $editor->roles()->detach();
+        $this->giveUserPermissions($editor, ['bookshelf-view-all']);
+        $homeVisit = $this->get('/');
+        $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $shelf->name);
+        $this->withHtml($homeVisit)->assertElementNotContains('.content-wrap', $book->name);
+
+        // Ensure is visible again with entity-level view permission
+        $this->setEntityRestrictions($book, ['view'], [$editor->roles()->first()]);
+        $homeVisit = $this->get('/');
+        $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $shelf->name);
+        $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $book->name);
+    }
+
+    public function test_new_users_dont_have_any_recently_viewed()
+    {
+        $user = User::factory()->create();
+        $viewRole = Role::getRole('Viewer');
+        $user->attachRole($viewRole);
+
+        $homeVisit = $this->actingAs($user)->get('/');
+        $this->withHtml($homeVisit)->assertElementContains('#recently-viewed', 'You have not viewed any pages');
+    }

 }
 }