added routes for zip export

[bookstack] / tests / FavouriteTest.php

diff --git a/tests/FavouriteTest.php b/tests/FavouriteTest.php
index a0f11886e5a23760c1e9122f2a76071c7df43df9..11016af14bb0a7c922e86668d6896466536c38c8 100644 (file)
--- a/tests/FavouriteTest.php
+++ b/tests/FavouriteTest.php
@@ -1,25 +1,23 @@
 <?php
 
 <?php
 

-use BookStack\Actions\Favourite;
-use BookStack\Entities\Models\Book;
-use BookStack\Entities\Models\Bookshelf;
-use BookStack\Entities\Models\Chapter;
-use BookStack\Entities\Models\Page;
-use Tests\TestCase;
+namespace Tests;
+
+use BookStack\Activity\Models\Favourite;
+use BookStack\Users\Models\User;

 
 class FavouriteTest extends TestCase
 {
     public function test_page_add_favourite_flow()
     {
 
 class FavouriteTest extends TestCase
 {
     public function test_page_add_favourite_flow()
     {

-        $page = Page::query()->first();
-        $editor = $this->getEditor();
+        $page = $this->entities->page();
+        $editor = $this->users->editor();

 
         $resp = $this->actingAs($editor)->get($page->getUrl());
 
         $resp = $this->actingAs($editor)->get($page->getUrl());

-        $resp->assertElementContains('button', 'Favourite');
-        $resp->assertElementExists('form[method="POST"][action$="/favourites/add"]');
+        $this->withHtml($resp)->assertElementContains('button', 'Favourite');
+        $this->withHtml($resp)->assertElementExists('form[method="POST"][action$="/favourites/add"] input[name="type"][value="page"]');

 
         $resp = $this->post('/favourites/add', [
 
         $resp = $this->post('/favourites/add', [

-            'type' => get_class($page),
+            'type' => $page->getMorphClass(),

             'id'   => $page->id,
         ]);
         $resp->assertRedirect($page->getUrl());
             'id'   => $page->id,
         ]);
         $resp->assertRedirect($page->getUrl());


@@ -34,8 +32,8 @@ class FavouriteTest extends TestCase
 
     public function test_page_remove_favourite_flow()
     {
 
     public function test_page_remove_favourite_flow()
     {

-        $page = Page::query()->first();
-        $editor = $this->getEditor();
+        $page = $this->entities->page();
+        $editor = $this->users->editor();

         Favourite::query()->forceCreate([
             'user_id'           => $editor->id,
             'favouritable_id'   => $page->id,
         Favourite::query()->forceCreate([
             'user_id'           => $editor->id,
             'favouritable_id'   => $page->id,


@@ -43,11 +41,11 @@ class FavouriteTest extends TestCase
         ]);
 
         $resp = $this->actingAs($editor)->get($page->getUrl());
         ]);
 
         $resp = $this->actingAs($editor)->get($page->getUrl());

-        $resp->assertElementContains('button', 'Unfavourite');
-        $resp->assertElementExists('form[method="POST"][action$="/favourites/remove"]');
+        $this->withHtml($resp)->assertElementContains('button', 'Unfavourite');
+        $this->withHtml($resp)->assertElementExists('form[method="POST"][action$="/favourites/remove"]');

 
         $resp = $this->post('/favourites/remove', [
 
         $resp = $this->post('/favourites/remove', [

-            'type' => get_class($page),
+            'type' => $page->getMorphClass(),

             'id'   => $page->id,
         ]);
         $resp->assertRedirect($page->getUrl());
             'id'   => $page->id,
         ]);
         $resp->assertRedirect($page->getUrl());


@@ -58,49 +56,84 @@ class FavouriteTest extends TestCase
         ]);
     }
 
         ]);
     }
 

-    public function test_book_chapter_shelf_pages_contain_favourite_button()
+    public function test_add_and_remove_redirect_to_entity_without_history()
+    {
+        $page = $this->entities->page();
+
+        $resp = $this->asEditor()->post('/favourites/add', [
+            'type' => $page->getMorphClass(),
+            'id'   => $page->id,
+        ]);
+        $resp->assertRedirect($page->getUrl());
+
+        $resp = $this->asEditor()->post('/favourites/remove', [
+            'type' => $page->getMorphClass(),
+            'id'   => $page->id,
+        ]);
+        $resp->assertRedirect($page->getUrl());
+    }
+
+    public function test_favourite_flow_with_own_permissions()
+    {
+        $book = $this->entities->book();
+        $user = User::factory()->create();
+        $book->owned_by = $user->id;
+        $book->save();
+
+        $this->permissions->grantUserRolePermissions($user, ['book-view-own']);
+
+        $this->actingAs($user)->get($book->getUrl());
+        $resp = $this->post('/favourites/add', [
+            'type' => $book->getMorphClass(),
+            'id'   => $book->id,
+        ]);
+        $resp->assertRedirect($book->getUrl());
+
+        $this->assertDatabaseHas('favourites', [
+            'user_id'           => $user->id,
+            'favouritable_type' => $book->getMorphClass(),
+            'favouritable_id'   => $book->id,
+        ]);
+    }
+
+    public function test_each_entity_type_shows_favourite_button()

     {
     {

-        $entities = [
-            Bookshelf::query()->first(),
-            Book::query()->first(),
-            Chapter::query()->first(),
-        ];
-        $this->actingAs($this->getEditor());
-
-        foreach ($entities as $entity) {
+        $this->actingAs($this->users->editor());
+
+        foreach ($this->entities->all() as $entity) {

             $resp = $this->get($entity->getUrl());
             $resp = $this->get($entity->getUrl());

-            $resp->assertElementExists('form[method="POST"][action$="/favourites/add"]');
+            $this->withHtml($resp)->assertElementExists('form[method="POST"][action$="/favourites/add"]');

         }
     }
 
     public function test_header_contains_link_to_favourites_page_when_logged_in()
     {
         $this->setSettings(['app-public' => 'true']);
         }
     }
 
     public function test_header_contains_link_to_favourites_page_when_logged_in()
     {
         $this->setSettings(['app-public' => 'true']);

-        $this->get('/')->assertElementNotContains('header', 'My Favourites');
-        $this->actingAs($this->getViewer())->get('/')->assertElementContains('header a', 'My Favourites');
+        $resp = $this->get('/');
+        $this->withHtml($resp)->assertElementNotContains('header', 'My Favourites');
+        $resp = $this->actingAs($this->users->viewer())->get('/');
+        $this->withHtml($resp)->assertElementContains('header a', 'My Favourites');

     }
 
     public function test_favourites_shown_on_homepage()
     {
     }
 
     public function test_favourites_shown_on_homepage()
     {

-        $editor = $this->getEditor();
+        $editor = $this->users->editor();

 
         $resp = $this->actingAs($editor)->get('/');
 
         $resp = $this->actingAs($editor)->get('/');

-        $resp->assertElementNotExists('#top-favourites');
+        $this->withHtml($resp)->assertElementNotExists('#top-favourites');

 
 

-        /** @var Page $page */
-        $page = Page::query()->first();
+        $page = $this->entities->page();

         $page->favourites()->save((new Favourite())->forceFill(['user_id' => $editor->id]));
 
         $resp = $this->get('/');
         $page->favourites()->save((new Favourite())->forceFill(['user_id' => $editor->id]));
 
         $resp = $this->get('/');

-        $resp->assertElementExists('#top-favourites');
-        $resp->assertElementContains('#top-favourites', $page->name);
+        $this->withHtml($resp)->assertElementExists('#top-favourites');
+        $this->withHtml($resp)->assertElementContains('#top-favourites', $page->name);

     }
 
     public function test_favourites_list_page_shows_favourites_and_has_working_pagination()
     {
     }
 
     public function test_favourites_list_page_shows_favourites_and_has_working_pagination()
     {

-        /** @var Page $page */
-        $page = Page::query()->first();
-        $editor = $this->getEditor();
+        $page = $this->entities->page();
+        $editor = $this->users->editor();

 
         $resp = $this->actingAs($editor)->get('/favourites');
         $resp->assertDontSee($page->name);
 
         $resp = $this->actingAs($editor)->get('/favourites');
         $resp->assertDontSee($page->name);