Themes: Documented public file serving

[bookstack] / app / Uploads / ImageRepo.php

diff --git a/app/Uploads/ImageRepo.php b/app/Uploads/ImageRepo.php
index 0e312d8832730b678e2c35502604966247037761..845067fdc29987e318633a079c11f98ef3d6deef 100644 (file)
--- a/app/Uploads/ImageRepo.php
+++ b/app/Uploads/ImageRepo.php
@@ -2,7 +2,7 @@
 
 namespace BookStack\Uploads;
 
 
 namespace BookStack\Uploads;
 

-use BookStack\Entities\Models\Page;
+use BookStack\Entities\Queries\PageQueries;

 use BookStack\Exceptions\ImageUploadException;
 use BookStack\Permissions\PermissionApplicator;
 use Exception;
 use BookStack\Exceptions\ImageUploadException;
 use BookStack\Permissions\PermissionApplicator;
 use Exception;


@@ -15,6 +15,7 @@ class ImageRepo
         protected ImageService $imageService,
         protected PermissionApplicator $permissions,
         protected ImageResizer $imageResizer,
         protected ImageService $imageService,
         protected PermissionApplicator $permissions,
         protected ImageResizer $imageResizer,

+        protected PageQueries $pageQueries,

     ) {
     }
 
     ) {
     }
 


@@ -77,14 +78,13 @@ class ImageRepo
      */
     public function getEntityFiltered(
         string $type,
      */
     public function getEntityFiltered(
         string $type,

-        string $filterType = null,
-        int $page = 0,
-        int $pageSize = 24,
-        int $uploadedTo = null,
-        string $search = null
+        ?string $filterType,
+        int $page,
+        int $pageSize,
+        int $uploadedTo,
+        ?string $search

     ): array {
     ): array {

-        /** @var Page $contextPage */
-        $contextPage = Page::visible()->findOrFail($uploadedTo);
+        $contextPage = $this->pageQueries->findVisibleByIdOrFail($uploadedTo);

         $parentFilter = null;
 
         if ($filterType === 'book' || $filterType === 'page') {
         $parentFilter = null;
 
         if ($filterType === 'book' || $filterType === 'page') {


@@ -166,7 +166,7 @@ class ImageRepo
      */
     public function updateImageFile(Image $image, UploadedFile $file): void
     {
      */
     public function updateImageFile(Image $image, UploadedFile $file): void
     {

-        if ($file->getClientOriginalExtension() !== pathinfo($image->path, PATHINFO_EXTENSION)) {
+        if (strtolower($file->getClientOriginalExtension()) !== strtolower(pathinfo($image->path, PATHINFO_EXTENSION))) {

             throw new ImageUploadException(trans('errors.image_upload_replace_type'));
         }
 
             throw new ImageUploadException(trans('errors.image_upload_replace_type'));
         }
 


@@ -225,9 +225,9 @@ class ImageRepo
      */
     public function getPagesUsingImage(Image $image): array
     {
      */
     public function getPagesUsingImage(Image $image): array
     {

-        $pages = Page::visible()
+        $pages = $this->pageQueries->visibleForList()

             ->where('html', 'like', '%' . $image->url . '%')
             ->where('html', 'like', '%' . $image->url . '%')

-            ->get(['id', 'name', 'slug', 'book_id']);
+            ->get();

 
         foreach ($pages as $page) {
             $page->setAttribute('url', $page->getUrl());
 
         foreach ($pages as $page) {
             $page->setAttribute('url', $page->getUrl());