-<?php namespace Tests;
+<?php namespace Tests\Auth;
+use BookStack\Auth\Role;
use BookStack\Auth\User;
-use BookStack\Entities\Page;
+use BookStack\Entities\Models\Page;
use BookStack\Notifications\ConfirmEmail;
+use BookStack\Notifications\ResetPassword;
use BookStack\Settings\SettingService;
+use DB;
+use Hash;
use Illuminate\Support\Facades\Notification;
+use Tests\BrowserKitTest;
class AuthTest extends BrowserKitTest
{
->press('Resend Confirmation Email');
// Get confirmation and confirm notification matches
- $emailConfirmation = \DB::table('email_confirmations')->where('user_id', '=', $dbUser->id)->first();
+ $emailConfirmation = DB::table('email_confirmations')->where('user_id', '=', $dbUser->id)->first();
Notification::assertSentTo($dbUser, ConfirmEmail::class, function($notification, $channels) use ($emailConfirmation) {
return $notification->token === $emailConfirmation->token;
});
->seePageIs('/register/confirm')
->seeInDatabase('users', ['name' => $user->name, 'email' => $user->email, 'email_confirmed' => false]);
+ $this->visit('/')
+ ->seePageIs('/register/confirm/awaiting');
+
+ auth()->logout();
+
$this->visit('/')->seePageIs('/login')
->type($user->email, '#email')
->type($user->password, '#password')
->seePageIs('/register/confirm')
->seeInDatabase('users', ['name' => $user->name, 'email' => $user->email, 'email_confirmed' => false]);
+ $this->visit('/')
+ ->seePageIs('/register/confirm/awaiting');
+
+ auth()->logout();
$this->visit('/')->seePageIs('/login')
->type($user->email, '#email')
->type($user->password, '#password')
public function test_user_creation()
{
$user = factory(User::class)->make();
+ $adminRole = Role::getRole('admin');
$this->asAdmin()
->visit('/settings/users')
->click('Add New User')
->type($user->name, '#name')
->type($user->email, '#email')
- ->check('roles[admin]')
+ ->check("roles[{$adminRole->id}]")
->type($user->password, '#password')
->type($user->password, '#password-confirm')
->press('Save')
->seePageIs('/settings/users');
$userPassword = User::find($user->id)->password;
- $this->assertTrue(\Hash::check('newpassword', $userPassword));
+ $this->assertTrue(Hash::check('newpassword', $userPassword));
}
public function test_user_deletion()
public function test_user_cannot_be_deleted_if_last_admin()
{
- $adminRole = \BookStack\Auth\Role::getRole('admin');
+ $adminRole = Role::getRole('admin');
// Delete all but one admin user if there are more than one
$adminUsers = $adminRole->users;
public function test_reset_password_flow()
{
-
Notification::fake();
$this->visit('/login')->click('Forgot Password?')
->seePageIs('/password/email')
->press('Send Reset Link')
+ ->see('A password reset link
will be sent to [email protected] if that email address is found in the system.');
$this->seeInDatabase('password_resets', [
- Notification::assertSentTo($user, \BookStack\Notifications\ResetPassword::class);
- $n = Notification::sent($user, \BookStack\Notifications\ResetPassword::class);
+ Notification::assertSentTo($user, ResetPassword::class);
+ $n = Notification::sent($user, ResetPassword::class);
$this->visit('/password/reset/' . $n->first()->token)
->see('Reset Password')
->see('Your password has been successfully reset');
}
+ public function test_reset_password_flow_shows_success_message_even_if_wrong_password_to_prevent_user_discovery()
+ {
+ $this->visit('/login')->click('Forgot Password?')
+ ->seePageIs('/password/email')
+ ->press('Send Reset Link')
+ ->see('A password reset link will be sent to
[email protected] if that email address is found in the system.')
+ ->dontSee('We can\'t find a user');
+
+
+ $this->visit('/password/reset/arandometokenvalue')
+ ->see('Reset Password')
+ ->submitForm('Reset Password', [
+ 'password' => 'randompass',
+ 'password_confirmation' => 'randompass'
+ ])->followRedirects()
+ ->seePageIs('/password/reset/arandometokenvalue')
+ ->dontSee('We can\'t find a user')
+ ->see('The password reset token is invalid for this email address.');
+ }
+
public function test_reset_password_page_shows_sign_links()
{
$this->setSettings(['registration-enabled' => 'true']);
->seePageUrlIs($page->getUrl());
}
+ public function test_login_intended_redirect_does_not_redirect_to_external_pages()
+ {
+ config()->set('app.url', 'http://localhost');
+ $this->setSettings(['app-public' => true]);
+
+ $this->get('/login', ['referer' => 'https://example.com']);
+ $login = $this->post('/login', ['email' => '
[email protected]', 'password' => 'password']);
+
+ $login->assertRedirectedTo('http://localhost');
+ }
+
+ public function test_login_authenticates_admins_on_all_guards()
+ {
+ $this->assertTrue(auth()->check());
+ $this->assertTrue(auth('ldap')->check());
+ $this->assertTrue(auth('saml2')->check());
+ }
+
+ public function test_login_authenticates_nonadmins_on_default_guard_only()
+ {
+ $editor = $this->getEditor();
+ $editor->password = bcrypt('password');
+ $editor->save();
+
+ $this->post('/login', ['email' => $editor->email, 'password' => 'password']);
+ $this->assertTrue(auth()->check());
+ $this->assertFalse(auth('ldap')->check());
+ $this->assertFalse(auth('saml2')->check());
+ }
+
+ public function test_failed_logins_are_logged_when_message_configured()
+ {
+ $log = $this->withTestLogger();
+ config()->set(['logging.failed_login.message' => 'Failed login for %u']);
+
+ $this->post('/login', ['email' => '
[email protected]', 'password' => 'cattreedog']);
+ $this->assertTrue($log->hasWarningThatContains('Failed login for
[email protected]'));
+
+ $this->assertFalse($log->hasWarningThatContains('Failed login for
[email protected]'));
+ }
+
/**
* Perform a login
- * @param string $email
- * @param string $password
- * @return $this
*/
- protected function login($email, $password)
+ protected function login(string $email, string $password): AuthTest
{
return $this->visit('/login')
->type($email, '#email')
projects / bookstack / blobdiff