Fixes for CodeStyle vol.2

[bookstack] / app / Auth / UserRepo.php

diff --git a/app/Auth/UserRepo.php b/app/Auth/UserRepo.php
index a903e2c38324e27c1d646655d9758d8e1febb471..e1a040fc2ceb8850dd52b046556690add64bd606 100644 (file)
--- a/app/Auth/UserRepo.php
+++ b/app/Auth/UserRepo.php
@@ -1,69 +1,78 @@
-<?php namespace BookStack\Auth;
+<?php
+
+namespace BookStack\Auth;

 
 use Activity;
 
 use Activity;

-use BookStack\Entities\Book;
-use BookStack\Entities\Bookshelf;
-use BookStack\Entities\Chapter;
-use BookStack\Entities\Page;
+use BookStack\Entities\EntityProvider;
+use BookStack\Entities\Models\Book;
+use BookStack\Entities\Models\Bookshelf;
+use BookStack\Entities\Models\Chapter;
+use BookStack\Entities\Models\Page;

 use BookStack\Exceptions\NotFoundException;
 use BookStack\Exceptions\UserUpdateException;
 use BookStack\Exceptions\NotFoundException;
 use BookStack\Exceptions\UserUpdateException;

-use BookStack\Uploads\Image;
+use BookStack\Uploads\UserAvatars;

 use Exception;
 use Illuminate\Database\Eloquent\Builder;
 use Exception;
 use Illuminate\Database\Eloquent\Builder;

-use Images;
+use Illuminate\Database\Eloquent\Collection;
+use Illuminate\Pagination\LengthAwarePaginator;

 use Log;
 
 class UserRepo
 {
 use Log;
 
 class UserRepo
 {

-
-    protected $user;
-    protected $role;
+    protected $userAvatar;

 
     /**
      * UserRepo constructor.
      */
 
     /**
      * UserRepo constructor.
      */

-    public function __construct(User $user, Role $role)
+    public function __construct(UserAvatars $userAvatar)

     {
     {

-        $this->user = $user;
-        $this->role = $role;
+        $this->userAvatar = $userAvatar;

     }
 
     /**
     }
 
     /**

-     * @param string $email
-     * @return User|null
+     * Get a user by their email address.

      */
      */

-    public function getByEmail($email)
+    public function getByEmail(string $email): ?User

     {
     {

-        return $this->user->where('email', '=', $email)->first();
+        return User::query()->where('email', '=', $email)->first();

     }
 
     /**
     }
 
     /**

-     * @param int $id
-     * @return User
+     * Get a user by their ID.

      */
      */

-    public function getById($id)
+    public function getById(int $id): User

     {
     {

-        return $this->user->newQuery()->findOrFail($id);
+        return User::query()->findOrFail($id);
+    }
+
+    /**
+     * Get a user by their slug.
+     */
+    public function getBySlug(string $slug): User
+    {
+        return User::query()->where('slug', '=', $slug)->firstOrFail();

     }
 
     /**
      * Get all the users with their permissions.
     }
 
     /**
      * Get all the users with their permissions.

-     * @return Builder|static

      */
      */

-    public function getAllUsers()
+    public function getAllUsers(): Collection

     {
     {

-        return $this->user->with('roles', 'avatar')->orderBy('name', 'asc')->get();
+        return User::query()->with('roles', 'avatar')->orderBy('name', 'asc')->get();

     }
 
     /**
      * Get all the users with their permissions in a paginated format.
     }
 
     /**
      * Get all the users with their permissions in a paginated format.

-     * @param int $count
-     * @param $sortData
-     * @return Builder|static

      */
      */

-    public function getAllUsersPaginatedAndSorted($count, $sortData)
+    public function getAllUsersPaginatedAndSorted(int $count, array $sortData): LengthAwarePaginator

     {
     {

-        $query = $this->user->with('roles', 'avatar')->orderBy($sortData['sort'], $sortData['order']);
+        $sort = $sortData['sort'];
+
+        $query = User::query()->select(['*'])
+            ->withLastActivityAt()
+            ->with(['roles', 'avatar'])
+            ->withCount('mfaValues')
+            ->orderBy($sort, $sortData['order']);

 
         if ($sortData['search']) {
             $term = '%' . $sortData['search'] . '%';
 
         if ($sortData['search']) {
             $term = '%' . $sortData['search'] . '%';


@@ -76,43 +85,27 @@ class UserRepo
         return $query->paginate($count);
     }
 
         return $query->paginate($count);
     }
 

-     /**
+    /**

      * Creates a new user and attaches a role to them.
      * Creates a new user and attaches a role to them.

-     * @param array $data
-     * @param boolean $verifyEmail
-     * @return User

      */
      */

-    public function registerNew(array $data, $verifyEmail = false)
+    public function registerNew(array $data, bool $emailConfirmed = false): User

     {
     {

-        $user = $this->create($data, $verifyEmail);
-        $this->attachDefaultRole($user);
+        $user = $this->create($data, $emailConfirmed);
+        $user->attachDefaultRole();

         $this->downloadAndAssignUserAvatar($user);
 
         return $user;
     }
 
         $this->downloadAndAssignUserAvatar($user);
 
         return $user;
     }
 

-    /**
-     * Give a user the default role. Used when creating a new user.
-     * @param User $user
-     */
-    public function attachDefaultRole(User $user)
-    {
-        $roleId = setting('registration-role');
-        if ($roleId !== false && $user->roles()->where('id', '=', $roleId)->count() === 0) {
-            $user->attachRoleId($roleId);
-        }
-    }
-

     /**
      * Assign a user to a system-level role.
     /**
      * Assign a user to a system-level role.

-     * @param User $user
-     * @param $systemRoleName
+     *

      * @throws NotFoundException
      */
      * @throws NotFoundException
      */

-    public function attachSystemRole(User $user, $systemRoleName)
+    public function attachSystemRole(User $user, string $systemRoleName)

     {
     {

-        $role = $this->role->newQuery()->where('system_name', '=', $systemRoleName)->first();
-        if ($role === null) {
+        $role = Role::getSystemRole($systemRoleName);
+        if (is_null($role)) {

             throw new NotFoundException("Role '{$systemRoleName}' not found");
         }
         $user->attachRole($role);
             throw new NotFoundException("Role '{$systemRoleName}' not found");
         }
         $user->attachRole($role);


@@ -120,26 +113,24 @@ class UserRepo
 
     /**
      * Checks if the give user is the only admin.
 
     /**
      * Checks if the give user is the only admin.

-     * @param User $user
-     * @return bool

      */
      */

-    public function isOnlyAdmin(User $user)
+    public function isOnlyAdmin(User $user): bool

     {
         if (!$user->hasSystemRole('admin')) {
             return false;
         }
 
     {
         if (!$user->hasSystemRole('admin')) {
             return false;
         }
 

-        $adminRole = $this->role->getSystemRole('admin');
-        if ($adminRole->users->count() > 1) {
+        $adminRole = Role::getSystemRole('admin');
+        if ($adminRole->users()->count() > 1) {

             return false;
         }
             return false;
         }

+

         return true;
     }
 
     /**
      * Set the assigned user roles via an array of role IDs.
         return true;
     }
 
     /**
      * Set the assigned user roles via an array of role IDs.

-     * @param User $user
-     * @param array $roles
+     *

      * @throws UserUpdateException
      */
     public function setUserRoles(User $user, array $roles)
      * @throws UserUpdateException
      */
     public function setUserRoles(User $user, array $roles)


@@ -154,14 +145,11 @@ class UserRepo
     /**
      * Check if the given user is the last admin and their new roles no longer
      * contains the admin role.
     /**
      * Check if the given user is the last admin and their new roles no longer
      * contains the admin role.

-     * @param User $user
-     * @param array $newRoles
-     * @return bool

      */
      */

-    protected function demotingLastAdmin(User $user, array $newRoles) : bool
+    protected function demotingLastAdmin(User $user, array $newRoles): bool

     {
         if ($this->isOnlyAdmin($user)) {
     {
         if ($this->isOnlyAdmin($user)) {

-            $adminRole = $this->role->getSystemRole('admin');
+            $adminRole = Role::getSystemRole('admin');

             if (!in_array(strval($adminRole->id), $newRoles)) {
                 return true;
             }
             if (!in_array(strval($adminRole->id), $newRoles)) {
                 return true;
             }


@@ -172,45 +160,65 @@ class UserRepo
 
     /**
      * Create a new basic instance of user.
 
     /**
      * Create a new basic instance of user.

-     * @param array $data
-     * @param boolean $verifyEmail
-     * @return User

      */
      */

-    public function create(array $data, $verifyEmail = false)
+    public function create(array $data, bool $emailConfirmed = false): User

     {
     {

-        return $this->user->forceCreate([
-            'name'     => $data['name'],
-            'email'    => $data['email'],
-            'password' => bcrypt($data['password']),
-            'email_confirmed' => $verifyEmail
-        ]);
+        $details = [
+            'name'             => $data['name'],
+            'email'            => $data['email'],
+            'password'         => bcrypt($data['password']),
+            'email_confirmed'  => $emailConfirmed,
+            'external_auth_id' => $data['external_auth_id'] ?? '',
+        ];
+
+        $user = new User();
+        $user->forceFill($details);
+        $user->refreshSlug();
+        $user->save();
+
+        return $user;

     }
 
     /**
      * Remove the given user from storage, Delete all related content.
     }
 
     /**
      * Remove the given user from storage, Delete all related content.

-     * @param User $user
+     *

      * @throws Exception
      */
      * @throws Exception
      */

-    public function destroy(User $user)
+    public function destroy(User $user, ?int $newOwnerId = null)

     {
         $user->socialAccounts()->delete();
     {
         $user->socialAccounts()->delete();

+        $user->apiTokens()->delete();
+        $user->favourites()->delete();
+        $user->mfaValues()->delete();

         $user->delete();
         $user->delete();

-        
+

         // Delete user profile images
         // Delete user profile images

-        $profileImages = Image::where('type', '=', 'user')->where('uploaded_to', '=', $user->id)->get();
-        foreach ($profileImages as $image) {
-            Images::destroy($image);
+        $this->userAvatar->destroyAllForUser($user);
+
+        if (!empty($newOwnerId)) {
+            $newOwner = User::query()->find($newOwnerId);
+            if (!is_null($newOwner)) {
+                $this->migrateOwnership($user, $newOwner);
+            }
+        }
+    }
+
+    /**
+     * Migrate ownership of items in the system from one user to another.
+     */
+    protected function migrateOwnership(User $fromUser, User $toUser)
+    {
+        $entities = (new EntityProvider())->all();
+        foreach ($entities as $instance) {
+            $instance->newQuery()->where('owned_by', '=', $fromUser->id)
+                ->update(['owned_by' => $toUser->id]);

         }
     }
 
     /**
      * Get the latest activity for a user.
         }
     }
 
     /**
      * Get the latest activity for a user.

-     * @param User $user
-     * @param int $count
-     * @param int $page
-     * @return array

      */
      */

-    public function getActivity(User $user, $count = 20, $page = 0)
+    public function getActivity(User $user, int $count = 20, int $page = 0): array

     {
         return Activity::userActivity($user, $count, $page);
     }
     {
         return Activity::userActivity($user, $count, $page);
     }


@@ -241,43 +249,33 @@ class UserRepo
     public function getAssetCounts(User $user): array
     {
         $createdBy = ['created_by' => $user->id];
     public function getAssetCounts(User $user): array
     {
         $createdBy = ['created_by' => $user->id];

+

         return [
         return [

-            'pages'    =>  Page::visible()->where($createdBy)->count(),
-            'chapters'    =>  Chapter::visible()->where($createdBy)->count(),
-            'books'    =>  Book::visible()->where($createdBy)->count(),
-            'shelves'    =>  Bookshelf::visible()->where($createdBy)->count(),
+            'pages'       => Page::visible()->where($createdBy)->count(),
+            'chapters'    => Chapter::visible()->where($createdBy)->count(),
+            'books'       => Book::visible()->where($createdBy)->count(),
+            'shelves'     => Bookshelf::visible()->where($createdBy)->count(),

         ];
     }
 
     /**
      * Get the roles in the system that are assignable to a user.
         ];
     }
 
     /**
      * Get the roles in the system that are assignable to a user.

-     * @return mixed

      */
      */

-    public function getAllRoles()
+    public function getAllRoles(): Collection

     {
     {

-        return $this->role->newQuery()->orderBy('name', 'asc')->get();
+        return Role::query()->orderBy('display_name', 'asc')->get();

     }
 
     /**
      * Get an avatar image for a user and set it as their avatar.
      * Returns early if avatars disabled or not set in config.
     }
 
     /**
      * Get an avatar image for a user and set it as their avatar.
      * Returns early if avatars disabled or not set in config.

-     * @param User $user
-     * @return bool

      */
      */

-    public function downloadAndAssignUserAvatar(User $user)
+    public function downloadAndAssignUserAvatar(User $user): void

     {
     {

-        if (!Images::avatarFetchEnabled()) {
-            return false;
-        }
-

         try {
         try {

-            $avatar = Images::saveUserAvatar($user);
-            $user->avatar()->associate($avatar);
-            $user->save();
-            return true;
+            $this->userAvatar->fetchAndAssignToUser($user);

         } catch (Exception $e) {
             Log::error('Failed to save user avatar image');
         } catch (Exception $e) {
             Log::error('Failed to save user avatar image');

-            return false;

         }
     }
 }
         }
     }
 }