Fixed failing test after drawio default url change

[bookstack] / tests / SharedTestHelpers.php

diff --git a/tests/SharedTestHelpers.php b/tests/SharedTestHelpers.php
index 3433f3b832f86d61411729ea23983905596d57d0..cbf49bf71f424f747e97bc04b3e3ff55fa6bb50b 100644 (file)
--- a/tests/SharedTestHelpers.php
+++ b/tests/SharedTestHelpers.php
@@ -1,33 +1,43 @@
-<?php namespace Tests;
+<?php

 
 

+namespace Tests;
+
+use BookStack\Auth\Permissions\PermissionService;
+use BookStack\Auth\Permissions\PermissionsRepo;
+use BookStack\Auth\Permissions\RolePermission;
+use BookStack\Auth\Role;

 use BookStack\Auth\User;
 use BookStack\Auth\User;

-use BookStack\Entities\Book;
-use BookStack\Entities\Bookshelf;
-use BookStack\Entities\Chapter;
-use BookStack\Entities\Entity;
-use BookStack\Entities\Page;
+use BookStack\Entities\Models\Book;
+use BookStack\Entities\Models\Bookshelf;
+use BookStack\Entities\Models\Chapter;
+use BookStack\Entities\Models\Entity;
+use BookStack\Entities\Models\Page;

 use BookStack\Entities\Repos\BookRepo;
 use BookStack\Entities\Repos\BookshelfRepo;
 use BookStack\Entities\Repos\ChapterRepo;
 use BookStack\Entities\Repos\BookRepo;
 use BookStack\Entities\Repos\BookshelfRepo;
 use BookStack\Entities\Repos\ChapterRepo;

-use BookStack\Auth\Permissions\PermissionsRepo;
-use BookStack\Auth\Role;
-use BookStack\Auth\Permissions\PermissionService;

 use BookStack\Entities\Repos\PageRepo;
 use BookStack\Settings\SettingService;
 use BookStack\Uploads\HttpFetcher;
 use BookStack\Entities\Repos\PageRepo;
 use BookStack\Settings\SettingService;
 use BookStack\Uploads\HttpFetcher;

+use GuzzleHttp\Client;
+use GuzzleHttp\Handler\MockHandler;
+use GuzzleHttp\HandlerStack;
+use GuzzleHttp\Middleware;
+use Illuminate\Http\JsonResponse;

 use Illuminate\Support\Env;
 use Illuminate\Support\Env;

+use Illuminate\Support\Facades\Log;
+use Illuminate\Testing\Assert as PHPUnit;

 use Mockery;
 use Mockery;

-use Throwable;
+use Monolog\Handler\TestHandler;
+use Monolog\Logger;
+use Psr\Http\Client\ClientInterface;

 
 trait SharedTestHelpers
 {
 
 trait SharedTestHelpers
 {

-

     protected $admin;
     protected $editor;
 
     /**
      * Set the current user context to be an admin.
     protected $admin;
     protected $editor;
 
     /**
      * Set the current user context to be an admin.

-     * @return $this

      */
     public function asAdmin()
     {
      */
     public function asAdmin()
     {


@@ -36,56 +46,63 @@ trait SharedTestHelpers
 
     /**
      * Get the current admin user.
 
     /**
      * Get the current admin user.

-     * @return mixed

      */
      */

-    public function getAdmin() {
-        if($this->admin === null) {
+    public function getAdmin(): User
+    {
+        if (is_null($this->admin)) {

             $adminRole = Role::getSystemRole('admin');
             $this->admin = $adminRole->users->first();
         }
             $adminRole = Role::getSystemRole('admin');
             $this->admin = $adminRole->users->first();
         }

+

         return $this->admin;
     }
 
     /**
      * Set the current user context to be an editor.
         return $this->admin;
     }
 
     /**
      * Set the current user context to be an editor.

-     * @return $this

      */
     public function asEditor()
     {
         return $this->actingAs($this->getEditor());
     }
 
      */
     public function asEditor()
     {
         return $this->actingAs($this->getEditor());
     }
 

-

     /**
      * Get a editor user.
     /**
      * Get a editor user.

-     * @return mixed

      */
      */

-    protected function getEditor() {
-        if($this->editor === null) {
+    protected function getEditor(): User
+    {
+        if ($this->editor === null) {

             $editorRole = Role::getRole('editor');
             $this->editor = $editorRole->users->first();
         }
             $editorRole = Role::getRole('editor');
             $this->editor = $editorRole->users->first();
         }

+

         return $this->editor;
     }
 
     /**
         return $this->editor;
     }
 
     /**

-     * Get an instance of a user with 'viewer' permissions
-     * @param $attributes
-     * @return mixed
+     * Get an instance of a user with 'viewer' permissions.

      */
      */

-    protected function getViewer($attributes = [])
+    protected function getViewer(array $attributes = []): User

     {
         $user = Role::getRole('viewer')->users()->first();
     {
         $user = Role::getRole('viewer')->users()->first();

-        if (!empty($attributes)) $user->forceFill($attributes)->save();
+        if (!empty($attributes)) {
+            $user->forceFill($attributes)->save();
+        }
+

         return $user;
     }
 
         return $user;
     }
 

+    /**
+     * Get a user that's not a system user such as the guest user.
+     */
+    public function getNormalUser(): User
+    {
+        return User::query()->where('system_name', '=', null)->get()->last();
+    }
+

     /**
      * Regenerate the permission for an entity.
     /**
      * Regenerate the permission for an entity.

-     * @param Entity $entity
-     * @throws Throwable

      */
      */

-    protected function regenEntityPermissions(Entity $entity)
+    protected function regenEntityPermissions(Entity $entity): void

     {
         $entity->rebuildPermissions();
         $entity->load('jointPermissions');
     {
         $entity->rebuildPermissions();
         $entity->load('jointPermissions');


@@ -93,50 +110,44 @@ trait SharedTestHelpers
 
     /**
      * Create and return a new bookshelf.
 
     /**
      * Create and return a new bookshelf.

-     * @param array $input
-     * @return Bookshelf

      */
      */

-    public function newShelf($input = ['name' => 'test shelf', 'description' => 'My new test shelf']) {
+    public function newShelf(array $input = ['name' => 'test shelf', 'description' => 'My new test shelf']): Bookshelf
+    {

         return app(BookshelfRepo::class)->create($input, []);
     }
 
     /**
      * Create and return a new book.
         return app(BookshelfRepo::class)->create($input, []);
     }
 
     /**
      * Create and return a new book.

-     * @param array $input
-     * @return Book

      */
      */

-    public function newBook($input = ['name' => 'test book', 'description' => 'My new test book']) {
+    public function newBook(array $input = ['name' => 'test book', 'description' => 'My new test book']): Book
+    {

         return app(BookRepo::class)->create($input);
     }
 
     /**
         return app(BookRepo::class)->create($input);
     }
 
     /**

-     * Create and return a new test chapter
-     * @param array $input
-     * @param Book $book
-     * @return Chapter
+     * Create and return a new test chapter.

      */
      */

-    public function newChapter($input = ['name' => 'test chapter', 'description' => 'My new test chapter'], Book $book) {
+    public function newChapter(array $input, Book $book): Chapter
+    {

         return app(ChapterRepo::class)->create($input, $book);
     }
 
     /**
         return app(ChapterRepo::class)->create($input, $book);
     }
 
     /**

-     * Create and return a new test page
-     * @param array $input
-     * @return Page
-     * @throws Throwable
+     * Create and return a new test page.

      */
      */

-    public function newPage($input = ['name' => 'test page', 'html' => 'My new test page']) {
-        $book = Book::first();
+    public function newPage(array $input = ['name' => 'test page', 'html' => 'My new test page']): Page
+    {
+        $book = Book::query()->first();

         $pageRepo = app(PageRepo::class);
         $draftPage = $pageRepo->getNewDraftPage($book);
         $pageRepo = app(PageRepo::class);
         $draftPage = $pageRepo->getNewDraftPage($book);

+

         return $pageRepo->publishDraft($draftPage, $input);
     }
 
     /**
      * Quickly sets an array of settings.
         return $pageRepo->publishDraft($draftPage, $input);
     }
 
     /**
      * Quickly sets an array of settings.

-     * @param $settingsArray

      */
      */

-    protected function setSettings($settingsArray)
+    protected function setSettings(array $settingsArray): void

     {
         $settings = app(SettingService::class);
         foreach ($settingsArray as $key => $value) {
     {
         $settings = app(SettingService::class);
         foreach ($settingsArray as $key => $value) {


@@ -146,11 +157,8 @@ trait SharedTestHelpers
 
     /**
      * Manually set some permissions on an entity.
 
     /**
      * Manually set some permissions on an entity.

-     * @param Entity $entity
-     * @param array $actions
-     * @param array $roles

      */
      */

-    protected function setEntityRestrictions(Entity $entity, $actions = [], $roles = [])
+    protected function setEntityRestrictions(Entity $entity, array $actions = [], array $roles = []): void

     {
         $entity->restricted = true;
         $entity->permissions()->delete();
     {
         $entity->restricted = true;
         $entity->permissions()->delete();


@@ -160,7 +168,7 @@ trait SharedTestHelpers
             foreach ($roles as $role) {
                 $permissions[] = [
                     'role_id' => $role->id,
             foreach ($roles as $role) {
                 $permissions[] = [
                     'role_id' => $role->id,

-                    'action' => strtolower($action)
+                    'action'  => strtolower($action),

                 ];
             }
         }
                 ];
             }
         }


@@ -174,34 +182,63 @@ trait SharedTestHelpers
 
     /**
      * Give the given user some permissions.
 
     /**
      * Give the given user some permissions.

-     * @param User $user
-     * @param array $permissions

      */
      */

-    protected function giveUserPermissions(User $user, $permissions = [])
+    protected function giveUserPermissions(User $user, array $permissions = []): void

     {
         $newRole = $this->createNewRole($permissions);
         $user->attachRole($newRole);
         $user->load('roles');
     {
         $newRole = $this->createNewRole($permissions);
         $user->attachRole($newRole);
         $user->load('roles');

-        $user->permissions(false);
+        $user->clearPermissionCache();
+    }
+
+    /**
+     * Completely remove the given permission name from the given user.
+     */
+    protected function removePermissionFromUser(User $user, string $permission)
+    {
+        $permission = RolePermission::query()->where('name', '=', $permission)->first();
+        /** @var Role $role */
+        foreach ($user->roles as $role) {
+            $role->detachPermission($permission);
+        }
+        $user->clearPermissionCache();

     }
 
     /**
      * Create a new basic role for testing purposes.
     }
 
     /**
      * Create a new basic role for testing purposes.

-     * @param array $permissions
-     * @return Role

      */
      */

-    protected function createNewRole($permissions = [])
+    protected function createNewRole(array $permissions = []): Role

     {
         $permissionRepo = app(PermissionsRepo::class);
     {
         $permissionRepo = app(PermissionsRepo::class);

-        $roleData = factory(Role::class)->make()->toArray();
+        $roleData = Role::factory()->make()->toArray();

         $roleData['permissions'] = array_flip($permissions);
         $roleData['permissions'] = array_flip($permissions);

+

         return $permissionRepo->saveNewRole($roleData);
     }
 
         return $permissionRepo->saveNewRole($roleData);
     }
 

+    /**
+     * Create a group of entities that belong to a specific user.
+     *
+     * @return array{book: Book, chapter: Chapter, page: Page}
+     */
+    protected function createEntityChainBelongingToUser(User $creatorUser, ?User $updaterUser = null): array
+    {
+        if (empty($updaterUser)) {
+            $updaterUser = $creatorUser;
+        }
+
+        $userAttrs = ['created_by' => $creatorUser->id, 'owned_by' => $creatorUser->id, 'updated_by' => $updaterUser->id];
+        $book = Book::factory()->create($userAttrs);
+        $chapter = Chapter::factory()->create(array_merge(['book_id' => $book->id], $userAttrs));
+        $page = Page::factory()->create(array_merge(['book_id' => $book->id, 'chapter_id' => $chapter->id], $userAttrs));
+        $restrictionService = $this->app[PermissionService::class];
+        $restrictionService->buildJointPermissionsForEntity($book);
+
+        return compact('book', 'chapter', 'page');
+    }
+

     /**
      * Mock the HttpFetcher service and return the given data on fetch.
     /**
      * Mock the HttpFetcher service and return the given data on fetch.

-     * @param $returnData
-     * @param int $times

      */
     protected function mockHttpFetch($returnData, int $times = 1)
     {
      */
     protected function mockHttpFetch($returnData, int $times = 1)
     {


@@ -212,12 +249,27 @@ trait SharedTestHelpers
             ->andReturn($returnData);
     }
 
             ->andReturn($returnData);
     }
 

+    /**
+     * Mock the http client used in BookStack.
+     * Returns a reference to the container which holds all history of http transactions.
+     *
+     * @link https://docs.guzzlephp.org/en/stable/testing.html#history-middleware
+     */
+    protected function &mockHttpClient(array $responses = []): array
+    {
+        $container = [];
+        $history = Middleware::history($container);
+        $mock = new MockHandler($responses);
+        $handlerStack = new HandlerStack($mock);
+        $handlerStack->push($history);
+        $this->app[ClientInterface::class] = new Client(['handler' => $handlerStack]);
+
+        return $container;
+    }
+

     /**
      * Run a set test with the given env variable.
      * Remembers the original and resets the value after test.
     /**
      * Run a set test with the given env variable.
      * Remembers the original and resets the value after test.

-     * @param string $name
-     * @param $value
-     * @param callable $callback

      */
     protected function runWithEnv(string $name, $value, callable $callback)
     {
      */
     protected function runWithEnv(string $name, $value, callable $callback)
     {


@@ -243,11 +295,8 @@ trait SharedTestHelpers
     /**
      * Check the keys and properties in the given map to include
      * exist, albeit not exclusively, within the map to check.
     /**
      * Check the keys and properties in the given map to include
      * exist, albeit not exclusively, within the map to check.

-     * @param array $mapToInclude
-     * @param array $mapToCheck
-     * @param string $message

      */
      */

-    protected function assertArrayMapIncludes(array $mapToInclude, array $mapToCheck, string $message = '') : void
+    protected function assertArrayMapIncludes(array $mapToInclude, array $mapToCheck, string $message = ''): void

     {
         $passed = true;
 
     {
         $passed = true;
 


@@ -262,4 +311,65 @@ trait SharedTestHelpers
         self::assertThat($passed, self::isTrue(), "Failed asserting that given map:\n\n{$toCheckStr}\n\nincludes:\n\n{$toIncludeStr}");
     }
 
         self::assertThat($passed, self::isTrue(), "Failed asserting that given map:\n\n{$toCheckStr}\n\nincludes:\n\n{$toIncludeStr}");
     }
 

-}
\ No newline at end of file
+    /**
+     * Assert a permission error has occurred.
+     */
+    protected function assertPermissionError($response)
+    {
+        PHPUnit::assertTrue($this->isPermissionError($response->baseResponse ?? $response->response), 'Failed asserting the response contains a permission error.');
+    }
+
+    /**
+     * Assert a permission error has occurred.
+     */
+    protected function assertNotPermissionError($response)
+    {
+        PHPUnit::assertFalse($this->isPermissionError($response->baseResponse ?? $response->response), 'Failed asserting the response does not contain a permission error.');
+    }
+
+    /**
+     * Check if the given response is a permission error.
+     */
+    private function isPermissionError($response): bool
+    {
+        return $response->status() === 302
+            && (
+                (
+                    $response->headers->get('Location') === url('/')
+                    && strpos(session()->pull('error', ''), 'You do not have permission to access') === 0
+                )
+                ||
+                (
+                    $response instanceof JsonResponse &&
+                    $response->json(['error' => 'You do not have permission to perform the requested action.'])
+                )
+            );
+    }
+
+    /**
+     * Assert that the session has a particular error notification message set.
+     */
+    protected function assertSessionError(string $message)
+    {
+        $error = session()->get('error');
+        PHPUnit::assertTrue($error === $message, "Failed asserting the session contains an error. \nFound: {$error}\nExpecting: {$message}");
+    }
+
+    /**
+     * Set a test handler as the logging interface for the application.
+     * Allows capture of logs for checking against during tests.
+     */
+    protected function withTestLogger(): TestHandler
+    {
+        $monolog = new Logger('testing');
+        $testHandler = new TestHandler();
+        $monolog->pushHandler($testHandler);
+
+        Log::extend('testing', function () use ($monolog) {
+            return $monolog;
+        });
+        Log::setDefaultDriver('testing');
+
+        return $testHandler;
+    }
+}