Started rewriting back-end image managment

[bookstack] / app / Http / Controllers / ImageController.php

diff --git a/app/Http/Controllers/ImageController.php b/app/Http/Controllers/ImageController.php
index 77c320e07db7989203f87284914ba39e68803672..ae2d743052fe1b1e70e014f16dbb2e270c964caa 100644 (file)
--- a/app/Http/Controllers/ImageController.php
+++ b/app/Http/Controllers/ImageController.php
@@ -1,12 +1,12 @@
 <?php namespace BookStack\Http\Controllers;
 
 <?php namespace BookStack\Http\Controllers;
 

+use BookStack\Entities\Repos\EntityRepo;

 use BookStack\Exceptions\ImageUploadException;
 use BookStack\Exceptions\ImageUploadException;

-use BookStack\Repos\EntityRepo;
-use BookStack\Repos\ImageRepo;
+use BookStack\Repos\PageRepo;
+use BookStack\Uploads\Image;
+use BookStack\Uploads\ImageRepo;

 use Illuminate\Filesystem\Filesystem as File;
 use Illuminate\Http\Request;
 use Illuminate\Filesystem\Filesystem as File;
 use Illuminate\Http\Request;

-use BookStack\Image;
-use BookStack\Repos\PageRepo;

 
 class ImageController extends Controller
 {
 
 class ImageController extends Controller
 {


@@ -28,15 +28,38 @@ class ImageController extends Controller
         parent::__construct();
     }
 
         parent::__construct();
     }
 

+    /**
+     * Provide an image file from storage.
+     * @param string $path
+     * @return mixed
+     */
+    public function showImage(string $path)
+    {
+        $path = storage_path('uploads/images/' . $path);
+        if (!file_exists($path)) {
+            abort(404);
+        }
+
+        return response()->file($path);
+    }
+

     /**
      * Get all images for a specific type, Paginated
     /**
      * Get all images for a specific type, Paginated

+     * @param Request $request

      * @param string $type
      * @param int $page
      * @return \Illuminate\Http\JsonResponse
      */
      * @param string $type
      * @param int $page
      * @return \Illuminate\Http\JsonResponse
      */

-    public function getAllByType($type, $page = 0)
+    public function getAllByType(Request $request, $type, $page = 0)

     {
     {

-        $imgData = $this->imageRepo->getPaginatedByType($type, $page);
+        $uploadedToFilter = $request->get('uploaded_to', null);
+
+        // For user profile request, check access to user images
+        if ($type === 'user') {
+            $this->checkPermissionOrCurrentUser('users-manage', $uploadedToFilter ?? 0);
+        }
+
+        $imgData = $this->imageRepo->getPaginatedByType($type, $page, 24, $uploadedToFilter);

         return response()->json($imgData);
     }
 
         return response()->json($imgData);
     }
 


@@ -47,48 +70,84 @@ class ImageController extends Controller
      * @param Request $request
      * @return mixed
      */
      * @param Request $request
      * @return mixed
      */

-    public function searchByType($type, $page = 0, Request $request)
+    public function searchByType(Request $request, $type, $page = 0)

     {
         $this->validate($request, [
             'term' => 'required|string'
         ]);
 
         $searchTerm = $request->get('term');
     {
         $this->validate($request, [
             'term' => 'required|string'
         ]);
 
         $searchTerm = $request->get('term');

-        $imgData = $this->imageRepo->searchPaginatedByType($type, $page, 24, $searchTerm);
+        $imgData = $this->imageRepo->searchPaginatedByType($type, $searchTerm, $page, 24);

         return response()->json($imgData);
     }
 
     /**
         return response()->json($imgData);
     }
 
     /**

-     * Get all images for a user.
+     * Get gallery images with a specific filter such as book or page
+     * @param $filter

      * @param int $page
      * @param int $page

-     * @return \Illuminate\Http\JsonResponse
+     * @param Request $request
+     * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\JsonResponse|\Symfony\Component\HttpFoundation\Response

      */
      */

-    public function getAllForUserType($page = 0)
+    public function getGalleryFiltered(Request $request, $filter, $page = 0)

     {
     {

-        $imgData = $this->imageRepo->getPaginatedByType('user', $page, 24, $this->currentUser->id);
+        $this->validate($request, [
+            'uploaded_to' => 'required|integer'
+        ]);
+
+        $validFilters = collect(['page', 'book']);
+        if (!$validFilters->contains($filter)) {
+            return response('Invalid filter', 500);
+        }
+
+        $pageId = $request->get('uploaded_to');
+        $imgData = $this->imageRepo->getGalleryFiltered(strtolower($filter), $pageId, $page, 24);
+

         return response()->json($imgData);
     }
 
         return response()->json($imgData);
     }
 

+    public function uploadGalleryImage(Request $request)
+    {
+        // TODO
+    }
+
+    public function uploadUserImage(Request $request)
+    {
+        // TODO
+    }
+
+    public function uploadSystemImage(Request $request)
+    {
+        // TODO
+    }
+
+    public function uploadCoverImage(Request $request)
+    {
+        // TODO
+    }
+

     /**
     /**

-     * Get gallery images with a specific filter such as book or page
-     * @param $filter
-     * @param int $page
+     * Upload a draw.io image into the system.

      * @param Request $request
      * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\JsonResponse|\Symfony\Component\HttpFoundation\Response
      */
      * @param Request $request
      * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\JsonResponse|\Symfony\Component\HttpFoundation\Response
      */

-    public function getGalleryFiltered($filter, $page = 0, Request $request)
+    public function uploadDrawioImage(Request $request)

     {
         $this->validate($request, [
     {
         $this->validate($request, [

-            'page_id' => 'required|integer'
+            'image' => 'required|string',
+            'uploaded_to' => 'required|integer'

         ]);
         ]);

+        $uploadedTo = $request->get('uploaded_to', 0);
+        $page = $this->
+        $this->checkPermission('image-create-all');
+        $imageBase64Data = $request->get('image');

 
 

-        $validFilters = collect(['page', 'book']);
-        if (!$validFilters->contains($filter)) return response('Invalid filter', 500);
-
-        $pageId = $request->get('page_id');
-        $imgData = $this->imageRepo->getGalleryFiltered($page, 24, strtolower($filter), $pageId);
+        try {
+            $image = $this->imageRepo->saveDrawing($imageBase64Data, $uploadedTo);
+        } catch (ImageUploadException $e) {
+            return response($e->getMessage(), 500);
+        }

 
 

-        return response()->json($imgData);
+        return response()->json($image);

     }
 
     /**
     }
 
     /**


@@ -96,18 +155,29 @@ class ImageController extends Controller
      * @param string $type
      * @param Request $request
      * @return \Illuminate\Http\JsonResponse
      * @param string $type
      * @param Request $request
      * @return \Illuminate\Http\JsonResponse

+     * @throws \Exception

      */
     public function uploadByType($type, Request $request)
     {
         $this->checkPermission('image-create-all');
         $this->validate($request, [
      */
     public function uploadByType($type, Request $request)
     {
         $this->checkPermission('image-create-all');
         $this->validate($request, [

-            'file' => 'is_image'
+            'file' => 'image_extension|no_double_extension|mimes:jpeg,png,gif,bmp,webp,tiff'

         ]);
 
         ]);
 

+        if (!$this->imageRepo->isValidType($type)) {
+            return $this->jsonError(trans('errors.image_upload_type_error'));
+        }
+

         $imageUpload = $request->file('file');
 
         try {
         $imageUpload = $request->file('file');
 
         try {

-            $uploadedTo = $request->has('uploaded_to') ? $request->get('uploaded_to') : 0;
+            $uploadedTo = $request->get('uploaded_to', 0);
+
+            // For user profile request, check access to user images
+            if ($type === 'user') {
+                $this->checkPermissionOrCurrentUser('users-manage', $uploadedTo ?? 0);
+            }
+

             $image = $this->imageRepo->saveNew($imageUpload, $type, $uploadedTo);
         } catch (ImageUploadException $e) {
             return response($e->getMessage(), 500);
             $image = $this->imageRepo->saveNew($imageUpload, $type, $uploadedTo);
         } catch (ImageUploadException $e) {
             return response($e->getMessage(), 500);


@@ -115,6 +185,22 @@ class ImageController extends Controller
 
         return response()->json($image);
     }
 
         return response()->json($image);
     }

+    /**
+     * Get the content of an image based64 encoded.
+     * @param $id
+     * @return \Illuminate\Http\JsonResponse|mixed
+     */
+    public function getBase64Image($id)
+    {
+        $image = $this->imageRepo->getById($id);
+        $imageData = $this->imageRepo->getImageData($image);
+        if ($imageData === null) {
+            return $this->jsonError("Image data could not be found");
+        }
+        return response()->json([
+            'content' => base64_encode($imageData)
+        ]);
+    }

 
     /**
      * Generate a sized thumbnail for an image.
 
     /**
      * Generate a sized thumbnail for an image.


@@ -123,6 +209,8 @@ class ImageController extends Controller
      * @param $height
      * @param $crop
      * @return \Illuminate\Http\JsonResponse
      * @param $height
      * @param $crop
      * @return \Illuminate\Http\JsonResponse

+     * @throws ImageUploadException
+     * @throws \Exception

      */
     public function getThumbnail($id, $width, $height, $crop)
     {
      */
     public function getThumbnail($id, $width, $height, $crop)
     {


@@ -134,45 +222,50 @@ class ImageController extends Controller
 
     /**
      * Update image details
 
     /**
      * Update image details

-     * @param integer $imageId
+     * @param integer $id

      * @param Request $request
      * @return \Illuminate\Http\JsonResponse
      * @param Request $request
      * @return \Illuminate\Http\JsonResponse

+     * @throws ImageUploadException
+     * @throws \Exception

      */
      */

-    public function update($imageId, Request $request)
+    public function update($id, Request $request)

     {
         $this->validate($request, [
             'name' => 'required|min:2|string'
         ]);
     {
         $this->validate($request, [
             'name' => 'required|min:2|string'
         ]);

-        $image = $this->imageRepo->getById($imageId);
+
+        $image = $this->imageRepo->getById($id);

         $this->checkOwnablePermission('image-update', $image);
         $this->checkOwnablePermission('image-update', $image);

+

         $image = $this->imageRepo->updateImageDetails($image, $request->all());
         return response()->json($image);
     }
 
         $image = $this->imageRepo->updateImageDetails($image, $request->all());
         return response()->json($image);
     }
 

+    /**
+     * Show the usage of an image on pages.
+     * @param \BookStack\Entities\Repos\EntityRepo $entityRepo
+     * @param $id
+     * @return \Illuminate\Http\JsonResponse
+     */
+    public function usage(EntityRepo $entityRepo, $id)
+    {
+        $image = $this->imageRepo->getById($id);
+        $pageSearch = $entityRepo->searchForImage($image->url);
+        return response()->json($pageSearch);
+    }
+

     /**
      * Deletes an image and all thumbnail/image files
     /**
      * Deletes an image and all thumbnail/image files

-     * @param EntityRepo $entityRepo
-     * @param Request $request

      * @param int $id
      * @return \Illuminate\Http\JsonResponse
      * @param int $id
      * @return \Illuminate\Http\JsonResponse

+     * @throws \Exception

      */
      */

-    public function destroy(EntityRepo $entityRepo, Request $request, $id)
+    public function destroy($id)

     {
         $image = $this->imageRepo->getById($id);
         $this->checkOwnablePermission('image-delete', $image);
 
     {
         $image = $this->imageRepo->getById($id);
         $this->checkOwnablePermission('image-delete', $image);
 

-        // Check if this image is used on any pages
-        $isForced = ($request->has('force') && ($request->get('force') === 'true') || $request->get('force') === true);
-        if (!$isForced) {
-            $pageSearch = $entityRepo->searchForImage($image->url);
-            if ($pageSearch !== false) {
-                return response()->json($pageSearch, 400);
-            }
-        }
-

         $this->imageRepo->destroyImage($image);
         return response()->json(trans('components.images_deleted'));
     }
         $this->imageRepo->destroyImage($image);
         return response()->json(trans('components.images_deleted'));
     }

-
-

 }
 }