BookStack Code Mirror - bookstack/blobdiff - tests/Permissions/RolesTest.php

diff --git a/tests/Permissions/RolesTest.php b/tests/Permissions/RolesTest.php

index 73060c834383726a138fa8ce180980123070104a..8398d08281a12d4e0239ae1531f4817d86b0c1a5 100644 (file)

--- a/tests/Permissions/RolesTest.php

+++ b/tests/Permissions/RolesTest.php

@@ -1,8 +1,13 @@

<?php namespace Tests\Permissions;

-use BookStack\Entities\Bookshelf;

-use BookStack\Entities\Page;

+use BookStack\Actions\Comment;

+use BookStack\Auth\User;

+use BookStack\Entities\Models\Book;

+use BookStack\Entities\Models\Bookshelf;

+use BookStack\Entities\Models\Chapter;

+use BookStack\Entities\Models\Page;

use BookStack\Auth\Role;

+use BookStack\Uploads\Image;

use Laravel\BrowserKitTesting\HttpException;

use Tests\BrowserKitTest;

@@ -23,7 +28,7 @@ class RolesTest extends BrowserKitTest

public function test_cannot_delete_admin_role()

{

- $adminRole = \BookStack\Auth\Role::getRole('admin');

+ $adminRole = Role::getRole('admin');

$deletePageUrl = '/settings/roles/delete/' . $adminRole->id;

$this->asAdmin()->visit($deletePageUrl)

->press('Confirm')

@@ -195,7 +200,7 @@ class RolesTest extends BrowserKitTest

public function test_restrictions_manage_all_permission()

{

- $page = \BookStack\Entities\Page::take(1)->get()->first();

+ $page = Page::take(1)->get()->first();

$this->actingAs($this->user)->visit($page->getUrl())

->dontSee('Permissions')

->visit($page->getUrl() . '/permissions')

@@ -209,17 +214,25 @@ class RolesTest extends BrowserKitTest

public function test_restrictions_manage_own_permission()

{

- $otherUsersPage = \BookStack\Entities\Page::first();

+ $otherUsersPage = Page::first();

$content = $this->createEntityChainBelongingToUser($this->user);

+

+ // Set a different creator on the page we're checking to ensure

+ // that the owner fields are checked

+ $page = $content['page']; /** @var Page $page */

+ $page->created_by = $otherUsersPage->id;

+ $page->owned_by = $this->user->id;

+ $page->save();

+

// Check can't restrict other's content

$this->actingAs($this->user)->visit($otherUsersPage->getUrl())

->dontSee('Permissions')

->visit($otherUsersPage->getUrl() . '/permissions')

->seePageIs('/');

// Check can't restrict own content

- $this->actingAs($this->user)->visit($content['page']->getUrl())

+ $this->actingAs($this->user)->visit($page->getUrl())

->dontSee('Permissions')

- ->visit($content['page']->getUrl() . '/permissions')

+ ->visit($page->getUrl() . '/permissions')

->seePageIs('/');

$this->giveUserPermissions($this->user, ['restrictions-manage-own']);

@@ -230,10 +243,10 @@ class RolesTest extends BrowserKitTest

->visit($otherUsersPage->getUrl() . '/permissions')

->seePageIs('/');

// Check can restrict own content

- $this->actingAs($this->user)->visit($content['page']->getUrl())

+ $this->actingAs($this->user)->visit($page->getUrl())

->see('Permissions')

->click('Permissions')

- ->seePageIs($content['page']->getUrl() . '/permissions');

+ ->seePageIs($page->getUrl() . '/permissions');

}

/**

@@ -284,7 +297,7 @@ class RolesTest extends BrowserKitTest

{

$otherShelf = Bookshelf::first();

$ownShelf = $this->newShelf(['name' => 'test-shelf', 'slug' => 'test-shelf']);

- $ownShelf->forceFill(['created_by' => $this->user->id, 'updated_by' => $this->user->id])->save();

+ $ownShelf->forceFill(['owned_by' => $this->user->id, 'updated_by' => $this->user->id])->save();

$this->regenEntityPermissions($ownShelf);

$this->checkAccessPermission('bookshelf-update-own', [

@@ -301,7 +314,7 @@ class RolesTest extends BrowserKitTest

public function test_bookshelves_edit_all_permission()

{

- $otherShelf = \BookStack\Entities\Bookshelf::first();

+ $otherShelf = Bookshelf::first();

$this->checkAccessPermission('bookshelf-update-all', [

$otherShelf->getUrl('/edit')

], [

@@ -312,9 +325,9 @@ class RolesTest extends BrowserKitTest

public function test_bookshelves_delete_own_permission()

{

$this->giveUserPermissions($this->user, ['bookshelf-update-all']);

- $otherShelf = \BookStack\Entities\Bookshelf::first();

+ $otherShelf = Bookshelf::first();

$ownShelf = $this->newShelf(['name' => 'test-shelf', 'slug' => 'test-shelf']);

- $ownShelf->forceFill(['created_by' => $this->user->id, 'updated_by' => $this->user->id])->save();

+ $ownShelf->forceFill(['owned_by' => $this->user->id, 'updated_by' => $this->user->id])->save();

$this->regenEntityPermissions($ownShelf);

$this->checkAccessPermission('bookshelf-delete-own', [

@@ -336,7 +349,7 @@ class RolesTest extends BrowserKitTest

public function test_bookshelves_delete_all_permission()

{

$this->giveUserPermissions($this->user, ['bookshelf-update-all']);

- $otherShelf = \BookStack\Entities\Bookshelf::first();

+ $otherShelf = Bookshelf::first();

$this->checkAccessPermission('bookshelf-delete-all', [

$otherShelf->getUrl('/delete')

], [

@@ -366,7 +379,7 @@ class RolesTest extends BrowserKitTest

public function test_books_edit_own_permission()

{

- $otherBook = \BookStack\Entities\Book::take(1)->get()->first();

+ $otherBook = Book::take(1)->get()->first();

$ownBook = $this->createEntityChainBelongingToUser($this->user)['book'];

$this->checkAccessPermission('book-update-own', [

$ownBook->getUrl() . '/edit'

@@ -382,7 +395,7 @@ class RolesTest extends BrowserKitTest

public function test_books_edit_all_permission()

{

- $otherBook = \BookStack\Entities\Book::take(1)->get()->first();

+ $otherBook = Book::take(1)->get()->first();

$this->checkAccessPermission('book-update-all', [

$otherBook->getUrl() . '/edit'

], [

@@ -393,7 +406,7 @@ class RolesTest extends BrowserKitTest

public function test_books_delete_own_permission()

{

$this->giveUserPermissions($this->user, ['book-update-all']);

- $otherBook = \BookStack\Entities\Book::take(1)->get()->first();

+ $otherBook = Book::take(1)->get()->first();

$ownBook = $this->createEntityChainBelongingToUser($this->user)['book'];

$this->checkAccessPermission('book-delete-own', [

$ownBook->getUrl() . '/delete'

@@ -414,7 +427,7 @@ class RolesTest extends BrowserKitTest

public function test_books_delete_all_permission()

{

$this->giveUserPermissions($this->user, ['book-update-all']);

- $otherBook = \BookStack\Entities\Book::take(1)->get()->first();

+ $otherBook = Book::take(1)->get()->first();

$this->checkAccessPermission('book-delete-all', [

$otherBook->getUrl() . '/delete'

], [

@@ -429,7 +442,7 @@ class RolesTest extends BrowserKitTest

public function test_chapter_create_own_permissions()

{

- $book = \BookStack\Entities\Book::take(1)->get()->first();

+ $book = Book::take(1)->get()->first();

$ownBook = $this->createEntityChainBelongingToUser($this->user)['book'];

$this->checkAccessPermission('chapter-create-own', [

$ownBook->getUrl('/create-chapter')

@@ -451,7 +464,7 @@ class RolesTest extends BrowserKitTest

public function test_chapter_create_all_permissions()

{

- $book = \BookStack\Entities\Book::take(1)->get()->first();

+ $book = Book::take(1)->get()->first();

$this->checkAccessPermission('chapter-create-all', [

$book->getUrl('/create-chapter')

], [

@@ -467,7 +480,7 @@ class RolesTest extends BrowserKitTest

public function test_chapter_edit_own_permission()

{

- $otherChapter = \BookStack\Entities\Chapter::take(1)->get()->first();

+ $otherChapter = Chapter::take(1)->get()->first();

$ownChapter = $this->createEntityChainBelongingToUser($this->user)['chapter'];

$this->checkAccessPermission('chapter-update-own', [

$ownChapter->getUrl() . '/edit'

@@ -483,7 +496,7 @@ class RolesTest extends BrowserKitTest

public function test_chapter_edit_all_permission()

{

- $otherChapter = \BookStack\Entities\Chapter::take(1)->get()->first();

+ $otherChapter = Chapter::take(1)->get()->first();

$this->checkAccessPermission('chapter-update-all', [

$otherChapter->getUrl() . '/edit'

], [

@@ -494,7 +507,7 @@ class RolesTest extends BrowserKitTest

public function test_chapter_delete_own_permission()

{

$this->giveUserPermissions($this->user, ['chapter-update-all']);

- $otherChapter = \BookStack\Entities\Chapter::take(1)->get()->first();

+ $otherChapter = Chapter::take(1)->get()->first();

$ownChapter = $this->createEntityChainBelongingToUser($this->user)['chapter'];

$this->checkAccessPermission('chapter-delete-own', [

$ownChapter->getUrl() . '/delete'

@@ -516,7 +529,7 @@ class RolesTest extends BrowserKitTest

public function test_chapter_delete_all_permission()

{

$this->giveUserPermissions($this->user, ['chapter-update-all']);

- $otherChapter = \BookStack\Entities\Chapter::take(1)->get()->first();

+ $otherChapter = Chapter::take(1)->get()->first();

$this->checkAccessPermission('chapter-delete-all', [

$otherChapter->getUrl() . '/delete'

], [

@@ -532,8 +545,8 @@ class RolesTest extends BrowserKitTest

public function test_page_create_own_permissions()

{

- $book = \BookStack\Entities\Book::first();

- $chapter = \BookStack\Entities\Chapter::first();

+ $book = Book::first();

+ $chapter = Chapter::first();

$entities = $this->createEntityChainBelongingToUser($this->user);

$ownBook = $entities['book'];

@@ -557,7 +570,7 @@ class RolesTest extends BrowserKitTest

foreach ($accessUrls as $index => $url) {

$this->actingAs($this->user)->visit($url);

- $expectedUrl = \BookStack\Entities\Page::where('draft', '=', true)->orderBy('id', 'desc')->first()->getUrl();

+ $expectedUrl = Page::where('draft', '=', true)->orderBy('id', 'desc')->first()->getUrl();

$this->seePageIs($expectedUrl);

}

@@ -579,8 +592,8 @@ class RolesTest extends BrowserKitTest

public function test_page_create_all_permissions()

{

- $book = \BookStack\Entities\Book::take(1)->get()->first();

- $chapter = \BookStack\Entities\Chapter::take(1)->get()->first();

+ $book = Book::take(1)->get()->first();

+ $chapter = Chapter::take(1)->get()->first();

$baseUrl = $book->getUrl() . '/page';

$createUrl = $book->getUrl('/create-page');

@@ -601,7 +614,7 @@ class RolesTest extends BrowserKitTest

foreach ($accessUrls as $index => $url) {

$this->actingAs($this->user)->visit($url);

- $expectedUrl = \BookStack\Entities\Page::where('draft', '=', true)->orderBy('id', 'desc')->first()->getUrl();

+ $expectedUrl = Page::where('draft', '=', true)->orderBy('id', 'desc')->first()->getUrl();

$this->seePageIs($expectedUrl);

}

@@ -620,7 +633,7 @@ class RolesTest extends BrowserKitTest

public function test_page_edit_own_permission()

{

- $otherPage = \BookStack\Entities\Page::take(1)->get()->first();

+ $otherPage = Page::take(1)->get()->first();

$ownPage = $this->createEntityChainBelongingToUser($this->user)['page'];

$this->checkAccessPermission('page-update-own', [

$ownPage->getUrl() . '/edit'

@@ -636,7 +649,7 @@ class RolesTest extends BrowserKitTest

public function test_page_edit_all_permission()

{

- $otherPage = \BookStack\Entities\Page::take(1)->get()->first();

+ $otherPage = Page::take(1)->get()->first();

$this->checkAccessPermission('page-update-all', [

$otherPage->getUrl() . '/edit'

], [

@@ -647,7 +660,7 @@ class RolesTest extends BrowserKitTest

public function test_page_delete_own_permission()

{

$this->giveUserPermissions($this->user, ['page-update-all']);

- $otherPage = \BookStack\Entities\Page::take(1)->get()->first();

+ $otherPage = Page::take(1)->get()->first();

$ownPage = $this->createEntityChainBelongingToUser($this->user)['page'];

$this->checkAccessPermission('page-delete-own', [

$ownPage->getUrl() . '/delete'

@@ -669,7 +682,7 @@ class RolesTest extends BrowserKitTest

public function test_page_delete_all_permission()

{

$this->giveUserPermissions($this->user, ['page-update-all']);

- $otherPage = \BookStack\Entities\Page::take(1)->get()->first();

+ $otherPage = Page::take(1)->get()->first();

$this->checkAccessPermission('page-delete-all', [

$otherPage->getUrl() . '/delete'

], [

@@ -685,7 +698,7 @@ class RolesTest extends BrowserKitTest

public function test_public_role_visible_in_user_edit_screen()

{

- $user = \BookStack\Auth\User::first();

+ $user = User::first();

$adminRole = Role::getSystemRole('admin');

$publicRole = Role::getSystemRole('public');

$this->asAdmin()->visit('/settings/users/' . $user->id)

@@ -721,8 +734,8 @@ class RolesTest extends BrowserKitTest

public function test_image_delete_own_permission()

{

$this->giveUserPermissions($this->user, ['image-update-all']);

- $page = \BookStack\Entities\Page::first();

- $image = factory(\BookStack\Uploads\Image::class)->create(['uploaded_to' => $page->id, 'created_by' => $this->user->id, 'updated_by' => $this->user->id]);

+ $page = Page::first();

+ $image = factory(Image::class)->create(['uploaded_to' => $page->id, 'created_by' => $this->user->id, 'updated_by' => $this->user->id]);

$this->actingAs($this->user)->json('delete', '/images/' . $image->id)

->seeStatusCode(403);

@@ -738,8 +751,8 @@ class RolesTest extends BrowserKitTest

{

$this->giveUserPermissions($this->user, ['image-update-all']);

$admin = $this->getAdmin();

- $page = \BookStack\Entities\Page::first();

- $image = factory(\BookStack\Uploads\Image::class)->create(['uploaded_to' => $page->id, 'created_by' => $admin->id, 'updated_by' => $admin->id]);

+ $page = Page::first();

+ $image = factory(Image::class)->create(['uploaded_to' => $page->id, 'created_by' => $admin->id, 'updated_by' => $admin->id]);

$this->actingAs($this->user)->json('delete', '/images/' . $image->id)

->seeStatusCode(403);

@@ -760,7 +773,7 @@ class RolesTest extends BrowserKitTest

{

// To cover issue fixed in f99c8ff99aee9beb8c692f36d4b84dc6e651e50a.

$page = Page::first();

- $viewerRole = \BookStack\Auth\Role::getRole('viewer');

+ $viewerRole = Role::getRole('viewer');

$viewer = $this->getViewer();

$this->actingAs($viewer)->visit($page->getUrl())->assertResponseStatus(200);

@@ -778,14 +791,14 @@ class RolesTest extends BrowserKitTest

{

$admin = $this->getAdmin();

// Book links

- $book = factory(\BookStack\Entities\Book::class)->create(['created_by' => $admin->id, 'updated_by' => $admin->id]);

+ $book = factory(Book::class)->create(['created_by' => $admin->id, 'updated_by' => $admin->id]);

$this->updateEntityPermissions($book);

$this->actingAs($this->getViewer())->visit($book->getUrl())

->dontSee('Create a new page')

->dontSee('Add a chapter');

// Chapter links

- $chapter = factory(\BookStack\Entities\Chapter::class)->create(['created_by' => $admin->id, 'updated_by' => $admin->id, 'book_id' => $book->id]);

+ $chapter = factory(Chapter::class)->create(['created_by' => $admin->id, 'updated_by' => $admin->id, 'book_id' => $book->id]);

$this->updateEntityPermissions($chapter);

$this->actingAs($this->getViewer())->visit($chapter->getUrl())

->dontSee('Create a new page')

@@ -869,7 +882,7 @@ class RolesTest extends BrowserKitTest

}

private function addComment($page) {

- $comment = factory(\BookStack\Actions\Comment::class)->make();

+ $comment = factory(Comment::class)->make();

$url = "/comment/$page->id";

$request = [

'text' => $comment->text,

@@ -882,7 +895,7 @@ class RolesTest extends BrowserKitTest

}

private function updateComment($commentId) {

- $comment = factory(\BookStack\Actions\Comment::class)->make();

+ $comment = factory(Comment::class)->make();

$url = "/comment/$commentId";

$request = [

'text' => $comment->text,