Started rewriting back-end image managment

[bookstack] / app / Http / Controllers / ImageController.php

diff --git a/app/Http/Controllers/ImageController.php b/app/Http/Controllers/ImageController.php
index 9fcd5c304acbdfba3ec2bd2e1cb1daeada9fed1b..ae2d743052fe1b1e70e014f16dbb2e270c964caa 100644 (file)
--- a/app/Http/Controllers/ImageController.php
+++ b/app/Http/Controllers/ImageController.php
@@ -1,192 +1,271 @@
-<?php
-
-namespace Oxbow\Http\Controllers;
+<?php namespace BookStack\Http\Controllers;

 
 

+use BookStack\Entities\Repos\EntityRepo;
+use BookStack\Exceptions\ImageUploadException;
+use BookStack\Repos\PageRepo;
+use BookStack\Uploads\Image;
+use BookStack\Uploads\ImageRepo;

 use Illuminate\Filesystem\Filesystem as File;
 use Illuminate\Http\Request;
 
 use Illuminate\Filesystem\Filesystem as File;
 use Illuminate\Http\Request;
 

-use Illuminate\Support\Facades\Auth;
-use Intervention\Image\Facades\Image as ImageTool;
-use Illuminate\Support\Facades\DB;
-use Oxbow\Http\Requests;
-use Oxbow\Image;
-use RecursiveDirectoryIterator;
-use RecursiveIteratorIterator;
-use RegexIterator;
-

 class ImageController extends Controller
 {
     protected $image;
     protected $file;
 class ImageController extends Controller
 {
     protected $image;
     protected $file;

+    protected $imageRepo;

 
     /**
      * ImageController constructor.
      * @param Image $image
      * @param File $file
 
     /**
      * ImageController constructor.
      * @param Image $image
      * @param File $file

+     * @param ImageRepo $imageRepo

      */
      */

-    public function __construct(Image $image, File $file)
+    public function __construct(Image $image, File $file, ImageRepo $imageRepo)

     {
         $this->image = $image;
         $this->file = $file;
     {
         $this->image = $image;
         $this->file = $file;

+        $this->imageRepo = $imageRepo;
+        parent::__construct();

     }
 
     /**
     }
 
     /**

-     * Returns an image from behind the public-facing application.
-     * @param Request $request
-     * @return \Illuminate\Http\Response
+     * Provide an image file from storage.
+     * @param string $path
+     * @return mixed

      */
      */

-    public function getImage(Request $request)
-    {
-        $cacheTime = 60*60*24;
-        $path = storage_path() . '/' . $request->path();
-        $modifiedTime = $this->file->lastModified($path);
-        $eTag = md5($modifiedTime . $path);
-        $headerLastModified = gmdate('r', $modifiedTime);
-        $headerExpires = gmdate('r', $modifiedTime + $cacheTime);
-
-        $headers = [
-            'Last-Modified' => $headerLastModified,
-            'Cache-Control' => 'must-revalidate',
-            'Pragma' => 'public',
-            'Expires' => $headerExpires,
-            'Etag' => $eTag
-        ];
-
-        $browserModifiedSince = $request->header('If-Modified-Since');
-        $browserNoneMatch = $request->header('If-None-Match');
-        if($browserModifiedSince !== null && file_exists($path) && ($browserModifiedSince == $headerLastModified || $browserNoneMatch == $eTag)) {
-            return response()->make('', 304, $headers);
+    public function showImage(string $path)
+    {
+        $path = storage_path('uploads/images/' . $path);
+        if (!file_exists($path)) {
+            abort(404);

         }
 
         }
 

-        if(file_exists($path)) {
-            return response()->make(file_get_contents($path), 200, array_merge($headers, [
-                'Content-Type' => $this->file->mimeType($path),
-                'Content-Length' => filesize($path),
-            ]));
-        }
-        abort(404);
+        return response()->file($path);

     }
 
     /**
     }
 
     /**

-     * Get all images, Paginated
+     * Get all images for a specific type, Paginated
+     * @param Request $request
+     * @param string $type

      * @param int $page
      * @return \Illuminate\Http\JsonResponse
      */
      * @param int $page
      * @return \Illuminate\Http\JsonResponse
      */

-    public function getAll($page = 0)
+    public function getAllByType(Request $request, $type, $page = 0)

     {
     {

-        $pageSize = 30;
-        $images = DB::table('images')->orderBy('created_at', 'desc')
-            ->skip($page*$pageSize)->take($pageSize)->get();
-        foreach($images as $image) {
-            $image->thumbnail = $this->getThumbnail($image, 150, 150);
+        $uploadedToFilter = $request->get('uploaded_to', null);
+
+        // For user profile request, check access to user images
+        if ($type === 'user') {
+            $this->checkPermissionOrCurrentUser('users-manage', $uploadedToFilter ?? 0);

         }
         }

-        $hasMore = count(DB::table('images')->orderBy('created_at', 'desc')
-            ->skip(($page+1)*$pageSize)->take($pageSize)->get()) > 0;
-        return response()->json([
-            'images' => $images,
-            'hasMore' => $hasMore
+
+        $imgData = $this->imageRepo->getPaginatedByType($type, $page, 24, $uploadedToFilter);
+        return response()->json($imgData);
+    }
+
+    /**
+     * Search through images within a particular type.
+     * @param $type
+     * @param int $page
+     * @param Request $request
+     * @return mixed
+     */
+    public function searchByType(Request $request, $type, $page = 0)
+    {
+        $this->validate($request, [
+            'term' => 'required|string'

         ]);
         ]);

+
+        $searchTerm = $request->get('term');
+        $imgData = $this->imageRepo->searchPaginatedByType($type, $searchTerm, $page, 24);
+        return response()->json($imgData);

     }
 
     /**
     }
 
     /**

-     * Get the thumbnail for an image.
-     * @param $image
-     * @param int $width
-     * @param int $height
-     * @return string
+     * Get gallery images with a specific filter such as book or page
+     * @param $filter
+     * @param int $page
+     * @param Request $request
+     * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\JsonResponse|\Symfony\Component\HttpFoundation\Response

      */
      */

-    public function getThumbnail($image, $width = 220, $height = 220)
+    public function getGalleryFiltered(Request $request, $filter, $page = 0)

     {
     {

-        $explodedPath = explode('/', $image->url);
-        array_splice($explodedPath, 4, 0, ['thumbs-' . $width . '-' . $height]);
-        $thumbPath = implode('/', $explodedPath);
-        $thumbFilePath = public_path() . $thumbPath;
+        $this->validate($request, [
+            'uploaded_to' => 'required|integer'
+        ]);

 
 

-        // Return the thumbnail url path if already exists
-        if(file_exists($thumbFilePath)) {
-            return $thumbPath;
+        $validFilters = collect(['page', 'book']);
+        if (!$validFilters->contains($filter)) {
+            return response('Invalid filter', 500);

         }
 
         }
 

-        // Otherwise create the thumbnail
-        $thumb = ImageTool::make(public_path() . $image->url);
-        $thumb->fit($width, $height);
+        $pageId = $request->get('uploaded_to');
+        $imgData = $this->imageRepo->getGalleryFiltered(strtolower($filter), $pageId, $page, 24);
+
+        return response()->json($imgData);
+    }
+
+    public function uploadGalleryImage(Request $request)
+    {
+        // TODO
+    }
+
+    public function uploadUserImage(Request $request)
+    {
+        // TODO
+    }
+
+    public function uploadSystemImage(Request $request)
+    {
+        // TODO
+    }
+
+    public function uploadCoverImage(Request $request)
+    {
+        // TODO
+    }
+
+    /**
+     * Upload a draw.io image into the system.
+     * @param Request $request
+     * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\JsonResponse|\Symfony\Component\HttpFoundation\Response
+     */
+    public function uploadDrawioImage(Request $request)
+    {
+        $this->validate($request, [
+            'image' => 'required|string',
+            'uploaded_to' => 'required|integer'
+        ]);
+        $uploadedTo = $request->get('uploaded_to', 0);
+        $page = $this->
+        $this->checkPermission('image-create-all');
+        $imageBase64Data = $request->get('image');

 
 

-        // Create thumbnail folder if it does not exist
-        if(!file_exists(dirname($thumbFilePath))) {
-            mkdir(dirname($thumbFilePath), 0775, true);
+        try {
+            $image = $this->imageRepo->saveDrawing($imageBase64Data, $uploadedTo);
+        } catch (ImageUploadException $e) {
+            return response($e->getMessage(), 500);

         }
 
         }
 

-        //Save Thumbnail
-        $thumb->save($thumbFilePath);
-        return $thumbPath;
+        return response()->json($image);

     }
 
     /**
      * Handles image uploads for use on pages.
     }
 
     /**
      * Handles image uploads for use on pages.

+     * @param string $type

      * @param Request $request
      * @return \Illuminate\Http\JsonResponse
      * @param Request $request
      * @return \Illuminate\Http\JsonResponse

+     * @throws \Exception

      */
      */

-    public function upload(Request $request)
+    public function uploadByType($type, Request $request)

     {
     {

+        $this->checkPermission('image-create-all');
+        $this->validate($request, [
+            'file' => 'image_extension|no_double_extension|mimes:jpeg,png,gif,bmp,webp,tiff'
+        ]);
+
+        if (!$this->imageRepo->isValidType($type)) {
+            return $this->jsonError(trans('errors.image_upload_type_error'));
+        }
+

         $imageUpload = $request->file('file');
         $imageUpload = $request->file('file');

-        $name = str_replace(' ', '-', $imageUpload->getClientOriginalName());
-        $storageName = substr(sha1(time()), 0, 10) . '-' . $name;
-        $imagePath = '/uploads/images/'.Date('Y-m-M').'/';
-        $storagePath = public_path(). $imagePath;
-        $fullPath = $storagePath . $storageName;
-        while(file_exists($fullPath)) {
-            $storageName = substr(sha1(rand()), 0, 3) . $storageName;
-            $fullPath = $storagePath . $storageName;
+
+        try {
+            $uploadedTo = $request->get('uploaded_to', 0);
+
+            // For user profile request, check access to user images
+            if ($type === 'user') {
+                $this->checkPermissionOrCurrentUser('users-manage', $uploadedTo ?? 0);
+            }
+
+            $image = $this->imageRepo->saveNew($imageUpload, $type, $uploadedTo);
+        } catch (ImageUploadException $e) {
+            return response($e->getMessage(), 500);
+        }
+
+        return response()->json($image);
+    }
+    /**
+     * Get the content of an image based64 encoded.
+     * @param $id
+     * @return \Illuminate\Http\JsonResponse|mixed
+     */
+    public function getBase64Image($id)
+    {
+        $image = $this->imageRepo->getById($id);
+        $imageData = $this->imageRepo->getImageData($image);
+        if ($imageData === null) {
+            return $this->jsonError("Image data could not be found");

         }
         }

-        $imageUpload->move($storagePath, $storageName);
-        // Create and save image object
-        $this->image->name = $name;
-        $this->image->url = $imagePath . $storageName;
-        $this->image->created_by = Auth::user()->id;
-        $this->image->updated_by = Auth::user()->id;
-        $this->image->save();
-        $this->image->thumbnail = $this->getThumbnail($this->image, 150, 150);
-        return response()->json($this->image);
+        return response()->json([
+            'content' => base64_encode($imageData)
+        ]);
+    }
+
+    /**
+     * Generate a sized thumbnail for an image.
+     * @param $id
+     * @param $width
+     * @param $height
+     * @param $crop
+     * @return \Illuminate\Http\JsonResponse
+     * @throws ImageUploadException
+     * @throws \Exception
+     */
+    public function getThumbnail($id, $width, $height, $crop)
+    {
+        $this->checkPermission('image-create-all');
+        $image = $this->imageRepo->getById($id);
+        $thumbnailUrl = $this->imageRepo->getThumbnail($image, $width, $height, $crop == 'false');
+        return response()->json(['url' => $thumbnailUrl]);

     }
 
     /**
      * Update image details
     }
 
     /**
      * Update image details

-     * @param $imageId
+     * @param integer $id

      * @param Request $request
      * @return \Illuminate\Http\JsonResponse
      * @param Request $request
      * @return \Illuminate\Http\JsonResponse

+     * @throws ImageUploadException
+     * @throws \Exception

      */
      */

-    public function update($imageId, Request $request)
+    public function update($id, Request $request)

     {
         $this->validate($request, [
             'name' => 'required|min:2|string'
         ]);
     {
         $this->validate($request, [
             'name' => 'required|min:2|string'
         ]);

-        $image = $this->image->findOrFail($imageId);
-        $image->fill($request->all());
-        $image->save();
-        return response()->json($this->image);
+
+        $image = $this->imageRepo->getById($id);
+        $this->checkOwnablePermission('image-update', $image);
+
+        $image = $this->imageRepo->updateImageDetails($image, $request->all());
+        return response()->json($image);

     }
 
     /**
     }
 
     /**

-     * Deletes an image and all thumbnail/image files
+     * Show the usage of an image on pages.
+     * @param \BookStack\Entities\Repos\EntityRepo $entityRepo

      * @param $id
      * @return \Illuminate\Http\JsonResponse
      */
      * @param $id
      * @return \Illuminate\Http\JsonResponse
      */

-    public function destroy($id)
+    public function usage(EntityRepo $entityRepo, $id)

     {
     {

-        $image = $this->image->findOrFail($id);
-
-        // Delete files
-        $folder = public_path() . dirname($image->url);
-        $pattern = '/' . preg_quote(basename($image->url)). '/';
-        $dir = new RecursiveDirectoryIterator($folder);
-        $ite = new RecursiveIteratorIterator($dir);
-        $files = new RegexIterator($ite, $pattern, RegexIterator::ALL_MATCHES);
-        foreach($files as $path => $file) {
-            unlink($path);
-        }
-        $image->delete();
-        return response()->json('Image Deleted');
+        $image = $this->imageRepo->getById($id);
+        $pageSearch = $entityRepo->searchForImage($image->url);
+        return response()->json($pageSearch);

     }
 
     }
 

+    /**
+     * Deletes an image and all thumbnail/image files
+     * @param int $id
+     * @return \Illuminate\Http\JsonResponse
+     * @throws \Exception
+     */
+    public function destroy($id)
+    {
+        $image = $this->imageRepo->getById($id);
+        $this->checkOwnablePermission('image-delete', $image);

 
 

+        $this->imageRepo->destroyImage($image);
+        return response()->json(trans('components.images_deleted'));
+    }

 }
 }