]> BookStack Code Mirror - bookstack/blobdiff - app/Entities/Queries/QueryPopular.php
added routes for zip export
[bookstack] / app / Entities / Queries / QueryPopular.php
index 2b46ebfbcf937caf1a1546290a6ce89c139aa868..065ae82ef825a33db8af26d81c63a6ba8fd63ecc 100644 (file)
@@ -18,7 +18,7 @@ class QueryPopular
     ) {
     }
 
-    public function run(int $count, int $page, array $filterModels = null): Collection
+    public function run(int $count, int $page, array $filterModels): Collection
     {
         $query = $this->permissions
             ->restrictEntityRelationQuery(View::query(), 'views', 'viewable_id', 'viewable_type')
@@ -26,7 +26,7 @@ class QueryPopular
             ->groupBy('viewable_id', 'viewable_type')
             ->orderBy('view_count', 'desc');
 
-        if ($filterModels) {
+        if (!empty($filterModels)) {
             $query->whereIn('viewable_type', $this->entityProvider->getMorphClasses($filterModels));
         }
 
@@ -35,7 +35,7 @@ class QueryPopular
             ->take($count)
             ->get();
 
-        $this->listLoader->loadIntoRelations($views->all(), 'viewable', false);
+        $this->listLoader->loadIntoRelations($views->all(), 'viewable', true);
 
         return $views->pluck('viewable')->filter();
     }