Extend /users API endpoint

[bookstack] / tests / PublicActionTest.php

diff --git a/tests/PublicActionTest.php b/tests/PublicActionTest.php
index 671b5ee420453d266618b09a2f795de1c124d7dc..7dbf467bd838d8d82ece92e72b6b298ec0b88146 100644 (file)
--- a/tests/PublicActionTest.php
+++ b/tests/PublicActionTest.php
@@ -1,78 +1,111 @@
 <?php namespace Tests;
 
 <?php namespace Tests;
 

-class PublicActionTest extends BrowserKitTest
+use Auth;
+use BookStack\Auth\Permissions\PermissionService;
+use BookStack\Auth\Permissions\RolePermission;
+use BookStack\Auth\Role;
+use BookStack\Auth\User;
+use BookStack\Entities\Models\Book;
+use BookStack\Entities\Models\Chapter;
+use BookStack\Entities\Models\Page;
+use Illuminate\Support\Facades\View;
+
+class PublicActionTest extends TestCase

 {
 
     public function test_app_not_public()
     {
         $this->setSettings(['app-public' => 'false']);
 {
 
     public function test_app_not_public()
     {
         $this->setSettings(['app-public' => 'false']);

-        $book = \BookStack\Entities\Book::orderBy('name', 'asc')->first();
-        $this->visit('/books')->seePageIs('/login');
-        $this->visit($book->getUrl())->seePageIs('/login');
+        $book = Book::query()->first();
+        $this->get('/books')->assertRedirect('/login');
+        $this->get($book->getUrl())->assertRedirect('/login');

 
 

-        $page = \BookStack\Entities\Page::first();
-        $this->visit($page->getUrl())->seePageIs('/login');
+        $page = Page::query()->first();
+        $this->get($page->getUrl())->assertRedirect('/login');
+    }
+
+    public function test_login_link_visible()
+    {
+        $this->setSettings(['app-public' => 'true']);
+        $this->get('/')->assertElementExists('a[href="'.url('/login').'"]');
+    }
+
+    public function test_register_link_visible_when_enabled()
+    {
+        $this->setSettings(['app-public' => 'true']);
+        $home = $this->get('/');
+        $home->assertSee(url('/login'));
+        $home->assertDontSee(url('/register'));
+
+        $this->setSettings(['app-public' => 'true', 'registration-enabled' => 'true']);
+        $home = $this->get('/');
+        $home->assertSee(url('/login'));
+        $home->assertSee(url('/register'));

     }
 
     public function test_books_viewable()
     {
         $this->setSettings(['app-public' => 'true']);
     }
 
     public function test_books_viewable()
     {
         $this->setSettings(['app-public' => 'true']);

-        $books = \BookStack\Entities\Book::orderBy('name', 'asc')->take(10)->get();
+        $books = Book::query()->orderBy('name', 'asc')->take(10)->get();

         $bookToVisit = $books[1];
 
         // Check books index page is showing
         $bookToVisit = $books[1];
 
         // Check books index page is showing

-        $this->visit('/books')
-            ->seeStatusCode(200)
-            ->see($books[0]->name)
-            // Check individual book page is showing and it's child contents are visible.
-            ->click($bookToVisit->name)
-            ->seePageIs($bookToVisit->getUrl())
-            ->see($bookToVisit->name)
-            ->see($bookToVisit->chapters()->first()->name);
+        $resp = $this->get('/books');
+        $resp->assertStatus(200);
+        $resp->assertSee($books[0]->name);
+
+        // Check individual book page is showing and it's child contents are visible.
+        $resp = $this->get($bookToVisit->getUrl());
+        $resp->assertSee($bookToVisit->name);
+        $resp->assertSee($bookToVisit->chapters()->first()->name);

     }
 
     public function test_chapters_viewable()
     {
         $this->setSettings(['app-public' => 'true']);
     }
 
     public function test_chapters_viewable()
     {
         $this->setSettings(['app-public' => 'true']);

-        $chapterToVisit = \BookStack\Entities\Chapter::first();
+        /** @var Chapter $chapterToVisit */
+        $chapterToVisit = Chapter::query()->first();

         $pageToVisit = $chapterToVisit->pages()->first();
 
         // Check chapters index page is showing
         $pageToVisit = $chapterToVisit->pages()->first();
 
         // Check chapters index page is showing

-        $this->visit($chapterToVisit->getUrl())
-            ->seeStatusCode(200)
-            ->see($chapterToVisit->name)
-            // Check individual chapter page is showing and it's child contents are visible.
-            ->see($pageToVisit->name)
-            ->click($pageToVisit->name)
-            ->see($chapterToVisit->book->name)
-            ->see($chapterToVisit->name)
-            ->seePageIs($pageToVisit->getUrl());
+        $resp = $this->get($chapterToVisit->getUrl());
+        $resp->assertStatus(200);
+        $resp->assertSee($chapterToVisit->name);
+        // Check individual chapter page is showing and it's child contents are visible.
+        $resp->assertSee($pageToVisit->name);
+        $resp = $this->get($pageToVisit->getUrl());
+        $resp->assertStatus(200);
+        $resp->assertSee($chapterToVisit->book->name);
+        $resp->assertSee($chapterToVisit->name);

     }
 
     public function test_public_page_creation()
     {
         $this->setSettings(['app-public' => 'true']);
     }
 
     public function test_public_page_creation()
     {
         $this->setSettings(['app-public' => 'true']);

-        $publicRole = \BookStack\Auth\Role::getSystemRole('public');
+        $publicRole = Role::getSystemRole('public');

         // Grant all permissions to public
         $publicRole->permissions()->detach();
         // Grant all permissions to public
         $publicRole->permissions()->detach();

-        foreach (\BookStack\Auth\Permissions\RolePermission::all() as $perm) {
+        foreach (RolePermission::all() as $perm) {

             $publicRole->attachPermission($perm);
         }
             $publicRole->attachPermission($perm);
         }

-        $this->app[\BookStack\Auth\Permissions\PermissionService::class]->buildJointPermissionForRole($publicRole);
+        $this->app[PermissionService::class]->buildJointPermissionForRole($publicRole);
+
+        /** @var Chapter $chapter */
+        $chapter = Chapter::query()->first();
+        $resp = $this->get($chapter->getUrl());
+        $resp->assertSee('New Page');
+        $resp->assertElementExists('a[href="'.$chapter->getUrl('/create-page').'"]');

 
 

-        $chapter = \BookStack\Entities\Chapter::first();
-        $this->visit($chapter->book->getUrl());
-        $this->visit($chapter->getUrl())
-            ->click('New Page')
-            ->see('New Page')
-            ->seePageIs($chapter->getUrl('/create-page'));
+        $resp = $this->get($chapter->getUrl('/create-page'));
+        $resp->assertSee('Continue');
+        $resp->assertSee('Page Name');
+        $resp->assertElementExists('form[action="'.$chapter->getUrl('/create-guest-page').'"]');

 
 

-        $this->submitForm('Continue', [
-            'name' => 'My guest page'
-        ])->seePageIs($chapter->book->getUrl('/page/my-guest-page/edit'));
+        $resp = $this->post($chapter->getUrl('/create-guest-page'), ['name' => 'My guest page']);
+        $resp->assertRedirect($chapter->book->getUrl('/page/my-guest-page/edit'));

 
 

-        $user = \BookStack\Auth\User::getDefault();
-        $this->seeInDatabase('pages', [
+        $user = User::getDefault();
+        $this->assertDatabaseHas('pages', [

             'name' => 'My guest page',
             'chapter_id' => $chapter->id,
             'created_by' => $user->id,
             'name' => 'My guest page',
             'chapter_id' => $chapter->id,
             'created_by' => $user->id,


@@ -82,43 +115,73 @@ class PublicActionTest extends BrowserKitTest
 
     public function test_content_not_listed_on_404_for_public_users()
     {
 
     public function test_content_not_listed_on_404_for_public_users()
     {

-        $page = \BookStack\Entities\Page::first();
-        $this->asAdmin()->visit($page->getUrl());
-        \Auth::logout();
-        view()->share('pageTitle', '');
-        $this->forceVisit('/cats/dogs/hippos');
-        $this->dontSee($page->name);
+        $page = Page::query()->first();
+        $page->fill(['name' => 'my testing random unique page name'])->save();
+        $this->asAdmin()->get($page->getUrl()); // Fake visit to show on recents
+        $resp = $this->get('/cats/dogs/hippos');
+        $resp->assertStatus(404);
+        $resp->assertSee($page->name);
+        View::share('pageTitle', '');
+
+        Auth::logout();
+        $resp = $this->get('/cats/dogs/hippos');
+        $resp->assertStatus(404);
+        $resp->assertDontSee($page->name);

     }
 
     public function test_robots_effected_by_public_status()
     {
     }
 
     public function test_robots_effected_by_public_status()
     {

-        $this->visit('/robots.txt');
-        $this->seeText("User-agent: *\nDisallow: /");
+        $this->get('/robots.txt')->assertSee("User-agent: *\nDisallow: /");

 
         $this->setSettings(['app-public' => 'true']);
 
         $this->setSettings(['app-public' => 'true']);

-        $this->visit('/robots.txt');

 
 

-        $this->seeText("User-agent: *\nDisallow:");
-        $this->dontSeeText("Disallow: /");
+        $resp = $this->get('/robots.txt');
+        $resp->assertSee("User-agent: *\nDisallow:");
+        $resp->assertDontSee("Disallow: /");

     }
 
     public function test_robots_effected_by_setting()
     {
     }
 
     public function test_robots_effected_by_setting()
     {

-        $this->visit('/robots.txt');
-        $this->seeText("User-agent: *\nDisallow: /");
+        $this->get('/robots.txt')->assertSee("User-agent: *\nDisallow: /");

 
         config()->set('app.allow_robots', true);
 
         config()->set('app.allow_robots', true);

-        $this->visit('/robots.txt');

 
 

-        $this->seeText("User-agent: *\nDisallow:");
-        $this->dontSeeText("Disallow: /");
+        $resp = $this->get('/robots.txt');
+        $resp->assertSee("User-agent: *\nDisallow:");
+        $resp->assertDontSee("Disallow: /");

 
         // Check config overrides app-public setting
         config()->set('app.allow_robots', false);
         $this->setSettings(['app-public' => 'true']);
 
         // Check config overrides app-public setting
         config()->set('app.allow_robots', false);
         $this->setSettings(['app-public' => 'true']);

-        $this->visit('/robots.txt');
+        $this->get('/robots.txt')->assertSee("User-agent: *\nDisallow: /");
+    }

 
 

-        $this->seeText("User-agent: *\nDisallow: /");
+    public function test_public_view_then_login_redirects_to_previous_content()
+    {
+        $this->setSettings(['app-public' => 'true']);
+        /** @var Book $book */
+        $book = Book::query()->first();
+        $resp = $this->get($book->getUrl());
+        $resp->assertSee($book->name);
+
+        $this->get('/login');
+        $resp = $this->post('/login', ['email' => '[email protected]', 'password' => 'password']);
+        $resp->assertRedirect($book->getUrl());

     }
 
     }
 

+    public function test_access_hidden_content_then_login_redirects_to_intended_content()
+    {
+        $this->setSettings(['app-public' => 'true']);
+        /** @var Book $book */
+        $book = Book::query()->first();
+        $this->setEntityRestrictions($book);
+
+        $resp = $this->get($book->getUrl());
+        $resp->assertSee('Book not found');
+
+        $this->get('/login');
+        $resp = $this->post('/login', ['email' => '[email protected]', 'password' => 'password']);
+        $resp->assertRedirect($book->getUrl());
+        $this->followRedirects($resp)->assertSee($book->name);
+    }

 }
\ No newline at end of file
 }
\ No newline at end of file