X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/33a2999a57854495fcea8c1acf1b75b04a28a0bf..refs/pull/2023/head:/tests/Entity/PageContentTest.php diff --git a/tests/Entity/PageContentTest.php b/tests/Entity/PageContentTest.php index 4f65d3406..d714c3229 100644 --- a/tests/Entity/PageContentTest.php +++ b/tests/Entity/PageContentTest.php @@ -1,33 +1,307 @@ -get(2); + $page = Page::first(); + $secondPage = Page::where('id', '!=', $page->id)->first(); $secondPage->html = "

Hello, This is a test

This is a second block of content

"; $secondPage->save(); - $this->asAdmin()->visit($page->getUrl()) - ->dontSee('Hello, This is a test'); + $this->asEditor(); + + $pageContent = $this->get($page->getUrl()); + $pageContent->assertDontSee('Hello, This is a test'); $originalHtml = $page->html; $page->html .= "{{@{$secondPage->id}}}"; $page->save(); - $this->asAdmin()->visit($page->getUrl()) - ->see('Hello, This is a test') - ->see('This is a second block of content'); + $pageContent = $this->get($page->getUrl()); + $pageContent->assertSee('Hello, This is a test'); + $pageContent->assertSee('This is a second block of content'); $page->html = $originalHtml . " Well {{@{$secondPage->id}#section2}}"; $page->save(); - $this->asAdmin()->visit($page->getUrl()) - ->dontSee('Hello, This is a test') - ->see('Well This is a second block of content'); + $pageContent = $this->get($page->getUrl()); + $pageContent->assertDontSee('Hello, This is a test'); + $pageContent->assertSee('Well This is a second block of content'); + } + + public function test_saving_page_with_includes() + { + $page = Page::first(); + $secondPage = Page::where('id', '!=', $page->id)->first(); + + $this->asEditor(); + $includeTag = '{{@' . $secondPage->id . '}}'; + $page->html = '

' . $includeTag . '

'; + + $resp = $this->put($page->getUrl(), ['name' => $page->name, 'html' => $page->html, 'summary' => '']); + + $resp->assertStatus(302); + + $page = Page::find($page->id); + $this->assertStringContainsString($includeTag, $page->html); + $this->assertEquals('', $page->text); + } + + public function test_page_includes_do_not_break_tables() + { + $page = Page::first(); + $secondPage = Page::where('id', '!=', $page->id)->first(); + + $content = '
test
'; + $secondPage->html = $content; + $secondPage->save(); + + $page->html = "{{@{$secondPage->id}#table}}"; + $page->save(); + + $this->asEditor(); + $pageResp = $this->get($page->getUrl()); + $pageResp->assertSee($content); + } + + public function test_page_content_scripts_removed_by_default() + { + $this->asEditor(); + $page = Page::first(); + $script = 'abc123abc123'; + $page->html = "escape {$script}"; + $page->save(); + + $pageView = $this->get($page->getUrl()); + $pageView->assertStatus(200); + $pageView->assertDontSee($script); + $pageView->assertSee('abc123abc123'); + } + + public function test_more_complex_content_script_escaping_scenarios() + { + $checks = [ + "

Some script

", + "

Some script

", + "

Some script

", + "

Some script

", + "

Some script

", + "

Some script

", + ]; + + $this->asEditor(); + $page = Page::first(); + + foreach ($checks as $check) { + $page->html = $check; + $page->save(); + + $pageView = $this->get($page->getUrl()); + $pageView->assertStatus(200); + $pageView->assertElementNotContains('.page-content', ''); + } + + } + + public function test_iframe_js_and_base64_urls_are_removed() + { + $checks = [ + '', + '', + '', + '', + '' + ]; + + $this->asEditor(); + $page = Page::first(); + + foreach ($checks as $check) { + $page->html = $check; + $page->save(); + + $pageView = $this->get($page->getUrl()); + $pageView->assertStatus(200); + $pageView->assertElementNotContains('.page-content', ''); + $pageView->assertElementNotContains('.page-content', 'src='); + $pageView->assertElementNotContains('.page-content', 'javascript:'); + $pageView->assertElementNotContains('.page-content', 'data:'); + $pageView->assertElementNotContains('.page-content', 'base64'); + } + + } + + public function test_page_inline_on_attributes_removed_by_default() + { + $this->asEditor(); + $page = Page::first(); + $script = '

Hello

'; + $page->html = "escape {$script}"; + $page->save(); + + $pageView = $this->get($page->getUrl()); + $pageView->assertStatus(200); + $pageView->assertDontSee($script); + $pageView->assertSee('

Hello

'); } + public function test_more_complex_inline_on_attributes_escaping_scenarios() + { + $checks = [ + '

Hello

', + '
Lorem ipsum dolor sit amet.

Hello

', + '
Lorem ipsum dolor sit amet.

Hello

', + '
Lorem ipsum dolor sit amet.

Hello

', + '
Lorem ipsum dolor sit amet.

Hello

', + 'abc123'; + $page->html = "no escape {$script}"; + $page->save(); + + $pageView = $this->get($page->getUrl()); + $pageView->assertSee($script); + $pageView->assertDontSee('abc123abc123'); + } + + public function test_page_inline_on_attributes_show_if_configured() + { + $this->asEditor(); + $page = Page::first(); + config()->push('app.allow_content_scripts', 'true'); + + $script = '

Hello

'; + $page->html = "escape {$script}"; + $page->save(); + + $pageView = $this->get($page->getUrl()); + $pageView->assertSee($script); + $pageView->assertDontSee('

Hello

'); + } + + public function test_duplicate_ids_does_not_break_page_render() + { + $this->asEditor(); + $pageA = Page::first(); + $pageB = Page::query()->where('id', '!=', $pageA->id)->first(); + + $content = ' '; + $pageA->html = $content; + $pageA->save(); + + $pageB->html = '

{{@'. $pageA->id .'#test}}

'; + $pageB->save(); + + $pageView = $this->get($pageB->getUrl()); + $pageView->assertSuccessful(); + } + + public function test_duplicate_ids_fixed_on_page_save() + { + $this->asEditor(); + $page = Page::first(); + + $content = ''; + $pageSave = $this->put($page->getUrl(), [ + 'name' => $page->name, + 'html' => $content, + 'summary' => '' + ]); + $pageSave->assertRedirect(); + + $updatedPage = Page::where('id', '=', $page->id)->first(); + $this->assertEquals(substr_count($updatedPage->html, "bkmrk-test\""), 1); + } + + public function test_get_page_nav_sets_correct_properties() + { + $content = '

Hello

There

Donkey

'; + $pageContent = new PageContent(new Page(['html' => $content])); + $navMap = $pageContent->getNavigation($content); + + $this->assertCount(3, $navMap); + $this->assertArrayMapIncludes([ + 'nodeName' => 'h1', + 'link' => '#testa', + 'text' => 'Hello', + 'level' => 1, + ], $navMap[0]); + $this->assertArrayMapIncludes([ + 'nodeName' => 'h2', + 'link' => '#testb', + 'text' => 'There', + 'level' => 2, + ], $navMap[1]); + $this->assertArrayMapIncludes([ + 'nodeName' => 'h3', + 'link' => '#testc', + 'text' => 'Donkey', + 'level' => 3, + ], $navMap[2]); + } + + public function test_get_page_nav_does_not_show_empty_titles() + { + $content = '

Hello

 

'; + $pageContent = new PageContent(new Page(['html' => $content])); + $navMap = $pageContent->getNavigation($content); + + $this->assertCount(1, $navMap); + $this->assertArrayMapIncludes([ + 'nodeName' => 'h1', + 'link' => '#testa', + 'text' => 'Hello' + ], $navMap[0]); + } + + public function test_get_page_nav_shifts_headers_if_only_smaller_ones_are_used() + { + $content = '

Hello

There
Donkey
'; + $pageContent = new PageContent(new Page(['html' => $content])); + $navMap = $pageContent->getNavigation($content); + + $this->assertCount(3, $navMap); + $this->assertArrayMapIncludes([ + 'nodeName' => 'h4', + 'level' => 1, + ], $navMap[0]); + $this->assertArrayMapIncludes([ + 'nodeName' => 'h5', + 'level' => 2, + ], $navMap[1]); + $this->assertArrayMapIncludes([ + 'nodeName' => 'h6', + 'level' => 3, + ], $navMap[2]); + } }