X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/756b55bbffedb6e5fde91f9fbc61f5a382f20705..refs/pull/3593/head:/tests/Entity/BookTest.php diff --git a/tests/Entity/BookTest.php b/tests/Entity/BookTest.php index fa63c0bf9..2e6f8e9de 100644 --- a/tests/Entity/BookTest.php +++ b/tests/Entity/BookTest.php @@ -3,21 +3,26 @@ namespace Tests\Entity; use BookStack\Entities\Models\Book; +use BookStack\Entities\Models\BookChild; +use BookStack\Entities\Repos\BookRepo; use Tests\TestCase; +use Tests\Uploads\UsesImages; class BookTest extends TestCase { + use UsesImages; + public function test_create() { - $book = factory(Book::class)->make([ + $book = Book::factory()->make([ 'name' => 'My First Book', ]); $resp = $this->asEditor()->get('/books'); - $resp->assertElementContains('a[href="' . url('/http/source.bookstackapp.com/create-book') . '"]', 'Create New Book'); + $this->withHtml($resp)->assertElementContains('a[href="' . url('/http/source.bookstackapp.com/create-book') . '"]', 'Create New Book'); $resp = $this->get('/create-book'); - $resp->assertElementContains('form[action="' . url('/http/source.bookstackapp.com/books') . '"][method="POST"]', 'Save Book'); + $this->withHtml($resp)->assertElementContains('form[action="' . url('/http/source.bookstackapp.com/books') . '"][method="POST"]', 'Save Book'); $resp = $this->post('/books', $book->only('name', 'description')); $resp->assertRedirect('/books/my-first-book'); @@ -29,7 +34,7 @@ class BookTest extends TestCase public function test_create_uses_different_slugs_when_name_reused() { - $book = factory(Book::class)->make([ + $book = Book::factory()->make([ 'name' => 'My First Book', ]); @@ -45,6 +50,33 @@ class BookTest extends TestCase $this->assertEquals('my-first-book', $books[1]->slug); } + public function test_create_sets_tags() + { + // Cheeky initial update to refresh slug + $this->asEditor()->post('books', [ + 'name' => 'My book with tags', + 'description' => 'A book with tags', + 'tags' => [ + [ + 'name' => 'Category', + 'value' => 'Donkey Content', + ], + [ + 'name' => 'Level', + 'value' => '5', + ], + ], + ]); + + /** @var Book $book */ + $book = Book::query()->where('name', '=', 'My book with tags')->firstOrFail(); + $tags = $book->tags()->get(); + + $this->assertEquals(2, $tags->count()); + $this->assertEquals('Donkey Content', $tags[0]->value); + $this->assertEquals('Level', $tags[1]->name); + } + public function test_update() { /** @var Book $book */ @@ -59,7 +91,7 @@ class BookTest extends TestCase $resp = $this->get($book->getUrl('/edit')); $resp->assertSee($book->name); $resp->assertSee($book->description); - $resp->assertElementContains('form[action="' . $book->getUrl() . '"]', 'Save Book'); + $this->withHtml($resp)->assertElementContains('form[action="' . $book->getUrl() . '"]', 'Save Book'); $resp = $this->put($book->getUrl(), ['name' => $newName, 'description' => $newDesc]); $resp->assertRedirect($book->getUrl() . '-updated'); @@ -69,6 +101,36 @@ class BookTest extends TestCase $resp->assertSee($newDesc); } + public function test_update_sets_tags() + { + /** @var Book $book */ + $book = Book::query()->first(); + + $this->assertEquals(0, $book->tags()->count()); + + // Cheeky initial update to refresh slug + $this->asEditor()->put($book->getUrl(), [ + 'name' => $book->name, + 'tags' => [ + [ + 'name' => 'Category', + 'value' => 'Dolphin Content', + ], + [ + 'name' => 'Level', + 'value' => '5', + ], + ], + ]); + + $book->refresh(); + $tags = $book->tags()->get(); + + $this->assertEquals(2, $tags->count()); + $this->assertEquals('Dolphin Content', $tags[0]->value); + $this->assertEquals('Level', $tags[1]->name); + } + public function test_delete() { $book = Book::query()->whereHas('pages')->whereHas('chapters')->first(); @@ -93,13 +155,13 @@ class BookTest extends TestCase $this->assertTrue($book->deletions()->count() === 1); $redirectReq = $this->get($deleteReq->baseResponse->headers->get('location')); - $redirectReq->assertNotificationContains('Book Successfully Deleted'); + $this->assertNotificationContains($redirectReq, 'Book Successfully Deleted'); } public function test_cancel_on_create_page_leads_back_to_books_listing() { $resp = $this->asEditor()->get('/create-book'); - $resp->assertElementContains('form a[href="' . url('/http/source.bookstackapp.com/books') . '"]', 'Cancel'); + $this->withHtml($resp)->assertElementContains('form a[href="' . url('/http/source.bookstackapp.com/books') . '"]', 'Cancel'); } public function test_cancel_on_edit_book_page_leads_back_to_book() @@ -107,7 +169,7 @@ class BookTest extends TestCase /** @var Book $book */ $book = Book::query()->first(); $resp = $this->asEditor()->get($book->getUrl('/edit')); - $resp->assertElementContains('form a[href="' . $book->getUrl() . '"]', 'Cancel'); + $this->withHtml($resp)->assertElementContains('form a[href="' . $book->getUrl() . '"]', 'Cancel'); } public function test_next_previous_navigation_controls_show_within_book_content() @@ -116,28 +178,28 @@ class BookTest extends TestCase $chapter = $book->chapters->first(); $resp = $this->asEditor()->get($chapter->getUrl()); - $resp->assertElementContains('#sibling-navigation', 'Next'); - $resp->assertElementContains('#sibling-navigation', substr($chapter->pages[0]->name, 0, 20)); + $this->withHtml($resp)->assertElementContains('#sibling-navigation', 'Next'); + $this->withHtml($resp)->assertElementContains('#sibling-navigation', substr($chapter->pages[0]->name, 0, 20)); $resp = $this->get($chapter->pages[0]->getUrl()); - $resp->assertElementContains('#sibling-navigation', substr($chapter->pages[1]->name, 0, 20)); - $resp->assertElementContains('#sibling-navigation', 'Previous'); - $resp->assertElementContains('#sibling-navigation', substr($chapter->name, 0, 20)); + $this->withHtml($resp)->assertElementContains('#sibling-navigation', substr($chapter->pages[1]->name, 0, 20)); + $this->withHtml($resp)->assertElementContains('#sibling-navigation', 'Previous'); + $this->withHtml($resp)->assertElementContains('#sibling-navigation', substr($chapter->name, 0, 20)); } public function test_recently_viewed_books_updates_as_expected() { $books = Book::all()->take(2); - $this->asAdmin()->get('/books') - ->assertElementNotContains('#recents', $books[0]->name) + $resp = $this->asAdmin()->get('/books'); + $this->withHtml($resp)->assertElementNotContains('#recents', $books[0]->name) ->assertElementNotContains('#recents', $books[1]->name); $this->get($books[0]->getUrl()); $this->get($books[1]->getUrl()); - $this->get('/books') - ->assertElementContains('#recents', $books[0]->name) + $resp = $this->get('/books'); + $this->withHtml($resp)->assertElementContains('#recents', $books[0]->name) ->assertElementContains('#recents', $books[1]->name); } @@ -145,16 +207,16 @@ class BookTest extends TestCase { $books = Book::all()->take(2); - $this->asAdmin()->get('/books') - ->assertElementNotContains('#popular', $books[0]->name) + $resp = $this->asAdmin()->get('/books'); + $this->withHtml($resp)->assertElementNotContains('#popular', $books[0]->name) ->assertElementNotContains('#popular', $books[1]->name); $this->get($books[0]->getUrl()); $this->get($books[1]->getUrl()); $this->get($books[0]->getUrl()); - $this->get('/books') - ->assertElementContains('#popular .book:nth-child(1)', $books[0]->name) + $resp = $this->get('/books'); + $this->withHtml($resp)->assertElementContains('#popular .book:nth-child(1)', $books[0]->name) ->assertElementContains('#popular .book:nth-child(2)', $books[1]->name); } @@ -165,16 +227,16 @@ class BookTest extends TestCase setting()->putUser($editor, 'books_view_type', 'list'); $resp = $this->actingAs($editor)->get('/books'); - $resp->assertElementContains('form[action$="/settings/users/' . $editor->id . '/switch-books-view"]', 'Grid View'); - $resp->assertElementExists('input[name="view_type"][value="grid"]'); + $this->withHtml($resp)->assertElementContains('form[action$="/settings/users/' . $editor->id . '/switch-books-view"]', 'Grid View'); + $this->withHtml($resp)->assertElementExists('input[name="view_type"][value="grid"]'); $resp = $this->patch("/settings/users/{$editor->id}/switch-books-view", ['view_type' => 'grid']); $resp->assertRedirect(); $this->assertEquals('grid', setting()->getUser($editor, 'books_view_type')); $resp = $this->actingAs($editor)->get('/books'); - $resp->assertElementContains('form[action$="/settings/users/' . $editor->id . '/switch-books-view"]', 'List View'); - $resp->assertElementExists('input[name="view_type"][value="list"]'); + $this->withHtml($resp)->assertElementContains('form[action$="/settings/users/' . $editor->id . '/switch-books-view"]', 'List View'); + $this->withHtml($resp)->assertElementExists('input[name="view_type"][value="list"]'); $resp = $this->patch("/settings/users/{$editor->id}/switch-books-view", ['view_type' => 'list']); $resp->assertRedirect(); @@ -187,7 +249,7 @@ class BookTest extends TestCase 'name' => 'информация', ]); - $this->assertEquals('informatsiya', $book->slug); + $this->assertEquals('informaciya', $book->slug); $book = $this->newBook([ 'name' => '¿Qué?', @@ -204,4 +266,89 @@ class BookTest extends TestCase $this->assertEquals('parta-partb-partc', $book->slug); } + + public function test_show_view_has_copy_button() + { + /** @var Book $book */ + $book = Book::query()->first(); + $resp = $this->asEditor()->get($book->getUrl()); + + $this->withHtml($resp)->assertElementContains("a[href=\"{$book->getUrl('/copy')}\"]", 'Copy'); + } + + public function test_copy_view() + { + /** @var Book $book */ + $book = Book::query()->first(); + $resp = $this->asEditor()->get($book->getUrl('/copy')); + + $resp->assertOk(); + $resp->assertSee('Copy Book'); + $this->withHtml($resp)->assertElementExists("input[name=\"name\"][value=\"{$book->name}\"]"); + } + + public function test_copy() + { + /** @var Book $book */ + $book = Book::query()->whereHas('chapters')->whereHas('pages')->first(); + $resp = $this->asEditor()->post($book->getUrl('/copy'), ['name' => 'My copy book']); + + /** @var Book $copy */ + $copy = Book::query()->where('name', '=', 'My copy book')->first(); + + $resp->assertRedirect($copy->getUrl()); + $this->assertEquals($book->getDirectChildren()->count(), $copy->getDirectChildren()->count()); + } + + public function test_copy_does_not_copy_non_visible_content() + { + /** @var Book $book */ + $book = Book::query()->whereHas('chapters')->whereHas('pages')->first(); + + // Hide child content + /** @var BookChild $page */ + foreach ($book->getDirectChildren() as $child) { + $child->restricted = true; + $child->save(); + $this->regenEntityPermissions($child); + } + + $this->asEditor()->post($book->getUrl('/copy'), ['name' => 'My copy book']); + /** @var Book $copy */ + $copy = Book::query()->where('name', '=', 'My copy book')->first(); + + $this->assertEquals(0, $copy->getDirectChildren()->count()); + } + + public function test_copy_does_not_copy_pages_or_chapters_if_user_cant_create() + { + /** @var Book $book */ + $book = Book::query()->whereHas('chapters')->whereHas('directPages')->whereHas('chapters')->first(); + $viewer = $this->getViewer(); + $this->giveUserPermissions($viewer, ['book-create-all']); + + $this->actingAs($viewer)->post($book->getUrl('/copy'), ['name' => 'My copy book']); + /** @var Book $copy */ + $copy = Book::query()->where('name', '=', 'My copy book')->first(); + + $this->assertEquals(0, $copy->pages()->count()); + $this->assertEquals(0, $copy->chapters()->count()); + } + + public function test_copy_clones_cover_image_if_existing() + { + /** @var Book $book */ + $book = Book::query()->first(); + $bookRepo = $this->app->make(BookRepo::class); + $coverImageFile = $this->getTestImage('cover.png'); + $bookRepo->updateCoverImage($book, $coverImageFile); + + $this->asEditor()->post($book->getUrl('/copy'), ['name' => 'My copy book']); + + /** @var Book $copy */ + $copy = Book::query()->where('name', '=', 'My copy book')->first(); + + $this->assertNotNull($copy->cover); + $this->assertNotEquals($book->cover->id, $copy->cover->id); + } }