X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/7be7d7d1e74cc8edc1a3106e4691c4883c14079a..refs/pull/2902/head:/app/Exceptions/Handler.php diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php index 8d3a743fa..2d40f4476 100644 --- a/app/Exceptions/Handler.php +++ b/app/Exceptions/Handler.php @@ -9,7 +9,6 @@ use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; use Illuminate\Validation\ValidationException; use Symfony\Component\HttpKernel\Exception\HttpException; -use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; class Handler extends ExceptionHandler { @@ -36,9 +35,10 @@ class Handler extends ExceptionHandler * Report or log an exception. * * @param Exception $exception - * @return void * * @throws Exception + * + * @return void */ public function report(Exception $exception) { @@ -48,8 +48,9 @@ class Handler extends ExceptionHandler /** * Render an exception into an HTTP response. * - * @param \Illuminate\Http\Request $request - * @param Exception $e + * @param \Illuminate\Http\Request $request + * @param Exception $e + * * @return \Illuminate\Http\Response */ public function render($request, Exception $e) @@ -58,16 +59,6 @@ class Handler extends ExceptionHandler return $this->renderApiException($e); } - // Handle notify exceptions which will redirect to the - // specified location then show a notification message. - if ($this->isExceptionType($e, NotifyException::class)) { - $message = $this->getOriginalMessage($e); - if (!empty($message)) { - session()->flash('error', $message); - } - return redirect($e->redirectLocation); - } - return parent::render($request, $e); } @@ -94,7 +85,7 @@ class Handler extends ExceptionHandler $responseData = [ 'error' => [ 'message' => $e->getMessage(), - ] + ], ]; if ($e instanceof ValidationException) { @@ -103,38 +94,16 @@ class Handler extends ExceptionHandler } $responseData['error']['code'] = $code; - return new JsonResponse($responseData, $code, $headers); - } - /** - * Check the exception chain to compare against the original exception type. - */ - protected function isExceptionType(Exception $e, string $type): bool - { - do { - if (is_a($e, $type)) { - return true; - } - } while ($e = $e->getPrevious()); - return false; - } - - /** - * Get original exception message. - */ - protected function getOriginalMessage(Exception $e): string - { - do { - $message = $e->getMessage(); - } while ($e = $e->getPrevious()); - return $message; + return new JsonResponse($responseData, $code, $headers); } /** * Convert an authentication exception into an unauthenticated response. * - * @param \Illuminate\Http\Request $request - * @param \Illuminate\Auth\AuthenticationException $exception + * @param \Illuminate\Http\Request $request + * @param \Illuminate\Auth\AuthenticationException $exception + * * @return \Illuminate\Http\Response */ protected function unauthenticated($request, AuthenticationException $exception) @@ -149,8 +118,9 @@ class Handler extends ExceptionHandler /** * Convert a validation exception into a JSON response. * - * @param \Illuminate\Http\Request $request - * @param \Illuminate\Validation\ValidationException $exception + * @param \Illuminate\Http\Request $request + * @param \Illuminate\Validation\ValidationException $exception + * * @return \Illuminate\Http\JsonResponse */ protected function invalidJson($request, ValidationException $exception)