X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/8e8d582bc67c6ec440229a7fa9d4998fc9129ac1..refs/pull/5280/head:/app/Exceptions/Handler.php diff --git a/app/Exceptions/Handler.php b/app/Exceptions/Handler.php index 73a316953..61e126327 100644 --- a/app/Exceptions/Handler.php +++ b/app/Exceptions/Handler.php @@ -3,62 +3,179 @@ namespace BookStack\Exceptions; use Exception; -use Illuminate\Contracts\Validation\ValidationException; +use Illuminate\Auth\AuthenticationException; use Illuminate\Database\Eloquent\ModelNotFoundException; -use PhpSpec\Exception\Example\ErrorException; -use Symfony\Component\HttpKernel\Exception\HttpException; use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler; -use Illuminate\Auth\Access\AuthorizationException; +use Illuminate\Http\Exceptions\PostTooLargeException; +use Illuminate\Http\JsonResponse; +use Illuminate\Http\Request; +use Illuminate\Http\Response; +use Illuminate\Validation\ValidationException; +use Symfony\Component\ErrorHandler\Error\FatalError; +use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface; +use Throwable; class Handler extends ExceptionHandler { /** - * A list of the exception types that should not be reported. + * A list of the exception types that are not reported. * - * @var array + * @var array> */ protected $dontReport = [ - AuthorizationException::class, - HttpException::class, - ModelNotFoundException::class, - ValidationException::class, + NotFoundException::class, + StoppedAuthenticationException::class, ]; + /** + * A list of the inputs that are never flashed to the session on validation exceptions. + * + * @var array + */ + protected $dontFlash = [ + 'current_password', + 'password', + 'password_confirmation', + ]; + + /** + * A function to run upon out of memory. + * If it returns a response, that will be provided back to the request + * upon an out of memory event. + * + * @var ?callable(): ?Response + */ + protected $onOutOfMemory = null; + /** * Report or log an exception. * - * This is a great spot to send exceptions to Sentry, Bugsnag, etc. + * @param \Throwable $exception + * + * @throws \Throwable * - * @param \Exception $e + * @return void */ - public function report(Exception $e) + public function report(Throwable $exception) { - return parent::report($e); + parent::report($exception); } /** * Render an exception into an HTTP response. * - * @param \Illuminate\Http\Request $request - * @param \Exception $e + * @param \Illuminate\Http\Request $request + * @param Exception $e + * * @return \Illuminate\Http\Response */ - public function render($request, Exception $e) + public function render($request, Throwable $e) { - // Handle notify exceptions which will redirect to the - // specified location then show a notification message. - if ($e instanceof NotifyException) { - \Session::flash('error', $e->message); - return response()->redirectTo($e->redirectLocation); + if ($e instanceof FatalError && str_contains($e->getMessage(), 'bytes exhausted (tried to allocate') && $this->onOutOfMemory) { + $response = call_user_func($this->onOutOfMemory); + if ($response) { + return $response; + } } - // Handle pretty exceptions which will show a friendly application-fitting page - // Which will include the basic message to point the user roughly to the cause. - if (($e instanceof PrettyException || $e->getPrevious() instanceof PrettyException) && !config('app.debug')) { - $message = ($e instanceof PrettyException) ? $e->getMessage() : $e->getPrevious()->getMessage(); - return response()->view('errors/500', ['message' => $message], 500); + if ($e instanceof PostTooLargeException) { + $e = new NotifyException(trans('errors.server_post_limit'), '/', 413); + } + + if ($this->isApiRequest($request)) { + return $this->renderApiException($e); } return parent::render($request, $e); } + + /** + * Provide a function to be called when an out of memory event occurs. + * If the callable returns a response, this response will be returned + * to the request upon error. + */ + public function prepareForOutOfMemory(callable $onOutOfMemory) + { + $this->onOutOfMemory = $onOutOfMemory; + } + + /** + * Forget the current out of memory handler, if existing. + */ + public function forgetOutOfMemoryHandler() + { + $this->onOutOfMemory = null; + } + + /** + * Check if the given request is an API request. + */ + protected function isApiRequest(Request $request): bool + { + return str_starts_with($request->path(), 'api/'); + } + + /** + * Render an exception when the API is in use. + */ + protected function renderApiException(Throwable $e): JsonResponse + { + $code = 500; + $headers = []; + + if ($e instanceof HttpExceptionInterface) { + $code = $e->getStatusCode(); + $headers = $e->getHeaders(); + } + + if ($e instanceof ModelNotFoundException) { + $code = 404; + } + + $responseData = [ + 'error' => [ + 'message' => $e->getMessage(), + ], + ]; + + if ($e instanceof ValidationException) { + $responseData['error']['message'] = 'The given data was invalid.'; + $responseData['error']['validation'] = $e->errors(); + $code = $e->status; + } + + $responseData['error']['code'] = $code; + + return new JsonResponse($responseData, $code, $headers); + } + + /** + * Convert an authentication exception into an unauthenticated response. + * + * @param \Illuminate\Http\Request $request + * @param \Illuminate\Auth\AuthenticationException $exception + * + * @return \Illuminate\Http\Response + */ + protected function unauthenticated($request, AuthenticationException $exception) + { + if ($request->expectsJson()) { + return response()->json(['error' => 'Unauthenticated.'], 401); + } + + return redirect()->guest('login'); + } + + /** + * Convert a validation exception into a JSON response. + * + * @param \Illuminate\Http\Request $request + * @param \Illuminate\Validation\ValidationException $exception + * + * @return \Illuminate\Http\JsonResponse + */ + protected function invalidJson($request, ValidationException $exception) + { + return response()->json($exception->errors(), $exception->status); + } }