X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/a6633642232efd164d4708967ab59e498fbff896..refs/pull/3693/head:/tests/HomepageTest.php diff --git a/tests/HomepageTest.php b/tests/HomepageTest.php index 943a3160a..1d968a2c9 100644 --- a/tests/HomepageTest.php +++ b/tests/HomepageTest.php @@ -1,10 +1,14 @@ -asEditor(); @@ -39,13 +43,13 @@ class HomepageTest extends TestCase $content = str_repeat('This is the body content of my custom homepage.', 20); $customPage = $this->newPage(['name' => $name, 'html' => $content]); $this->setSettings([ - 'app-homepage' => $customPage->id, - 'app-homepage-type' => 'page' + 'app-homepage' => $customPage->id, + 'app-homepage-type' => 'page', ]); $homeVisit = $this->get('/'); $homeVisit->assertSee($name); - $homeVisit->assertElementNotExists('#home-default'); + $this->withHtml($homeVisit)->assertElementNotExists('#home-default'); $pageDeleteReq = $this->delete($customPage->getUrl()); $pageDeleteReq->assertStatus(302); @@ -65,8 +69,8 @@ class HomepageTest extends TestCase $content = str_repeat('This is the body content of my custom homepage.', 20); $customPage = $this->newPage(['name' => $name, 'html' => $content]); $this->setSettings([ - 'app-homepage' => $customPage->id, - 'app-homepage-type' => 'default' + 'app-homepage' => $customPage->id, + 'app-homepage-type' => 'default', ]); $pageDeleteReq = $this->delete($customPage->getUrl()); @@ -75,6 +79,43 @@ class HomepageTest extends TestCase $pageDeleteReq->assertSessionMissing('error'); } + public function test_custom_homepage_cannot_be_deleted_from_parent_deletion() + { + /** @var Page $page */ + $page = Page::query()->first(); + $this->setSettings([ + 'app-homepage' => $page->id, + 'app-homepage-type' => 'page', + ]); + + $this->asEditor()->delete($page->book->getUrl()); + $this->assertSessionError('Cannot delete a page while it is set as a homepage'); + $this->assertDatabaseMissing('deletions', ['deletable_id' => $page->book->id]); + + $page->refresh(); + $this->assertNull($page->deleted_at); + $this->assertNull($page->book->deleted_at); + } + + public function test_custom_homepage_renders_includes() + { + $this->asEditor(); + /** @var Page $included */ + $included = Page::query()->first(); + $content = str_repeat('This is the body content of my custom homepage.', 20); + $included->html = $content; + $included->save(); + + $name = 'My custom homepage'; + $customPage = $this->newPage(['name' => $name, 'html' => '{{@' . $included->id . '}}']); + $this->setSettings(['app-homepage' => $customPage->id]); + $this->setSettings(['app-homepage-type' => 'page']); + + $homeVisit = $this->get('/'); + $homeVisit->assertSee($name); + $homeVisit->assertSee($content); + } + public function test_set_book_homepage() { $editor = $this->getEditor(); @@ -107,7 +148,7 @@ class HomepageTest extends TestCase $homeVisit->assertSee('Shelves'); $homeVisit->assertSee('grid-card-content'); $homeVisit->assertSee('featured-image-container'); - $homeVisit->assertElementContains('.grid-card', $shelf->name); + $this->withHtml($homeVisit)->assertElementContains('.grid-card', $shelf->name); $this->setSettings(['app-homepage-type' => false]); $this->test_default_homepage_visible(); @@ -125,20 +166,30 @@ class HomepageTest extends TestCase // Ensure initially visible $homeVisit = $this->get('/'); - $homeVisit->assertElementContains('.content-wrap', $shelf->name); - $homeVisit->assertElementContains('.content-wrap', $book->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $shelf->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $book->name); // Ensure book no longer visible without view permission $editor->roles()->detach(); $this->giveUserPermissions($editor, ['bookshelf-view-all']); $homeVisit = $this->get('/'); - $homeVisit->assertElementContains('.content-wrap', $shelf->name); - $homeVisit->assertElementNotContains('.content-wrap', $book->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $shelf->name); + $this->withHtml($homeVisit)->assertElementNotContains('.content-wrap', $book->name); // Ensure is visible again with entity-level view permission $this->setEntityRestrictions($book, ['view'], [$editor->roles()->first()]); $homeVisit = $this->get('/'); - $homeVisit->assertElementContains('.content-wrap', $shelf->name); - $homeVisit->assertElementContains('.content-wrap', $book->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $shelf->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $book->name); + } + + public function test_new_users_dont_have_any_recently_viewed() + { + $user = User::factory()->create(); + $viewRole = Role::getRole('Viewer'); + $user->attachRole($viewRole); + + $homeVisit = $this->actingAs($user)->get('/'); + $this->withHtml($homeVisit)->assertElementContains('#recently-viewed', 'You have not viewed any pages'); } }