X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/d3a96451614201ca1b92bd3dffa9726d0b48a203..refs/pull/3593/head:/tests/HomepageTest.php diff --git a/tests/HomepageTest.php b/tests/HomepageTest.php index e27b78774..1d968a2c9 100644 --- a/tests/HomepageTest.php +++ b/tests/HomepageTest.php @@ -49,7 +49,7 @@ class HomepageTest extends TestCase $homeVisit = $this->get('/'); $homeVisit->assertSee($name); - $homeVisit->assertElementNotExists('#home-default'); + $this->withHtml($homeVisit)->assertElementNotExists('#home-default'); $pageDeleteReq = $this->delete($customPage->getUrl()); $pageDeleteReq->assertStatus(302); @@ -79,6 +79,24 @@ class HomepageTest extends TestCase $pageDeleteReq->assertSessionMissing('error'); } + public function test_custom_homepage_cannot_be_deleted_from_parent_deletion() + { + /** @var Page $page */ + $page = Page::query()->first(); + $this->setSettings([ + 'app-homepage' => $page->id, + 'app-homepage-type' => 'page', + ]); + + $this->asEditor()->delete($page->book->getUrl()); + $this->assertSessionError('Cannot delete a page while it is set as a homepage'); + $this->assertDatabaseMissing('deletions', ['deletable_id' => $page->book->id]); + + $page->refresh(); + $this->assertNull($page->deleted_at); + $this->assertNull($page->book->deleted_at); + } + public function test_custom_homepage_renders_includes() { $this->asEditor(); @@ -130,7 +148,7 @@ class HomepageTest extends TestCase $homeVisit->assertSee('Shelves'); $homeVisit->assertSee('grid-card-content'); $homeVisit->assertSee('featured-image-container'); - $homeVisit->assertElementContains('.grid-card', $shelf->name); + $this->withHtml($homeVisit)->assertElementContains('.grid-card', $shelf->name); $this->setSettings(['app-homepage-type' => false]); $this->test_default_homepage_visible(); @@ -148,30 +166,30 @@ class HomepageTest extends TestCase // Ensure initially visible $homeVisit = $this->get('/'); - $homeVisit->assertElementContains('.content-wrap', $shelf->name); - $homeVisit->assertElementContains('.content-wrap', $book->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $shelf->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $book->name); // Ensure book no longer visible without view permission $editor->roles()->detach(); $this->giveUserPermissions($editor, ['bookshelf-view-all']); $homeVisit = $this->get('/'); - $homeVisit->assertElementContains('.content-wrap', $shelf->name); - $homeVisit->assertElementNotContains('.content-wrap', $book->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $shelf->name); + $this->withHtml($homeVisit)->assertElementNotContains('.content-wrap', $book->name); // Ensure is visible again with entity-level view permission $this->setEntityRestrictions($book, ['view'], [$editor->roles()->first()]); $homeVisit = $this->get('/'); - $homeVisit->assertElementContains('.content-wrap', $shelf->name); - $homeVisit->assertElementContains('.content-wrap', $book->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $shelf->name); + $this->withHtml($homeVisit)->assertElementContains('.content-wrap', $book->name); } public function test_new_users_dont_have_any_recently_viewed() { - $user = factory(User::class)->create(); + $user = User::factory()->create(); $viewRole = Role::getRole('Viewer'); $user->attachRole($viewRole); $homeVisit = $this->actingAs($user)->get('/'); - $homeVisit->assertElementContains('#recently-viewed', 'You have not viewed any pages'); + $this->withHtml($homeVisit)->assertElementContains('#recently-viewed', 'You have not viewed any pages'); } }