X-Git-Url: http://source.bookstackapp.com/bookstack/blobdiff_plain/f2ee95ca03a2bc1c0f80b5d775a340d920784bdb..refs/pull/3693/head:/tests/Entity/EntitySearchTest.php diff --git a/tests/Entity/EntitySearchTest.php b/tests/Entity/EntitySearchTest.php index 6929adc74..3a9b9f31b 100644 --- a/tests/Entity/EntitySearchTest.php +++ b/tests/Entity/EntitySearchTest.php @@ -214,7 +214,7 @@ class EntitySearchTest extends TestCase $defaultListTest->assertDontSee($notVisitedPage->name); } - public function test_ajax_entity_serach_shows_breadcrumbs() + public function test_ajax_entity_search_shows_breadcrumbs() { $chapter = Chapter::first(); $page = $chapter->pages->first(); @@ -230,6 +230,21 @@ class EntitySearchTest extends TestCase $chapterSearch->assertSee($chapter->book->getShortName(42)); } + public function test_ajax_entity_search_reflects_items_without_permission() + { + $page = Page::query()->first(); + $baseSelector = 'a[data-entity-type="page"][data-entity-id="' . $page->id . '"]'; + $searchUrl = '/ajax/search/entities?permission=update&term=' . urlencode($page->name); + + $resp = $this->asEditor()->get($searchUrl); + $this->withHtml($resp)->assertElementContains($baseSelector, $page->name); + $this->withHtml($resp)->assertElementNotContains($baseSelector, "You don't have the required permissions to select this item"); + + $resp = $this->actingAs($this->getViewer())->get($searchUrl); + $this->withHtml($resp)->assertElementContains($baseSelector, $page->name); + $this->withHtml($resp)->assertElementContains($baseSelector, "You don't have the required permissions to select this item"); + } + public function test_sibling_search_for_pages() { $chapter = Chapter::query()->with('pages')->first(); @@ -323,16 +338,16 @@ class EntitySearchTest extends TestCase $this->newPage(['name' => 'Test page B', 'html' => '
cat biscuit
']); $search = $this->asEditor()->get('/search?term=cat+dog+biscuit'); - $search->assertElementContains('.entity-list > .page', 'Test page A', 1); - $search->assertElementContains('.entity-list > .page', 'Test page B', 2); + $this->withHtml($search)->assertElementContains('.entity-list > .page:nth-child(1)', 'Test page A'); + $this->withHtml($search)->assertElementContains('.entity-list > .page:nth-child(2)', 'Test page B'); for ($i = 0; $i < 2; $i++) { $this->newPage(['name' => 'Test page ' . $i, 'html' => 'dog
']); } $search = $this->asEditor()->get('/search?term=cat+dog+biscuit'); - $search->assertElementContains('.entity-list > .page', 'Test page B', 1); - $search->assertElementContains('.entity-list > .page', 'Test page A', 2); + $this->withHtml($search)->assertElementContains('.entity-list > .page:nth-child(1)', 'Test page B'); + $this->withHtml($search)->assertElementContains('.entity-list > .page:nth-child(2)', 'Test page A'); } public function test_terms_in_headers_have_an_adjusted_index_score() @@ -398,9 +413,20 @@ class EntitySearchTest extends TestCase // Content $search->assertSee('A superimportant page about meowieable animals', false); // Tag name - $search->assertElementContains('.tag-name.highlight', 'SuperImportant'); + $this->withHtml($search)->assertElementContains('.tag-name.highlight', 'SuperImportant'); // Tag value - $search->assertElementContains('.tag-value.highlight', 'MeowieCat'); + $this->withHtml($search)->assertElementContains('.tag-value.highlight', 'MeowieCat'); + } + + public function test_match_highlighting_works_with_multibyte_content() + { + $this->newPage([ + 'name' => 'Test Page', + 'html' => 'Ðа мен ми ÑÑÑбва неÑо добÑо test
', + ]); + + $search = $this->asEditor()->get('/search?term=' . urlencode('Ðа мен ми ÑÑÑбва неÑо добÑо')); + $search->assertSee('Ðа мен ми ÑÑÑбва неÑо добÑо test', false); } public function test_html_entities_in_item_details_remains_escaped_in_search_results() @@ -411,4 +437,22 @@ class EntitySearchTest extends TestCase $search->assertSee('My <cool> TestPageContent', false); $search->assertSee('My supercool <great> TestPageContent page', false); } + + public function test_words_adjacent_to_lines_breaks_can_be_matched_with_normal_terms() + { + $page = $this->newPage(['name' => 'TermA', 'html' => ' +TermA
TermB
TermC