Updated user interfaces for LDAP and added email from LDAP

diff --git a/app/Http/Controllers/Auth/AuthController.php b/app/Http/Controllers/Auth/AuthController.php
index 98ef67987ce6960b243e7ce306d86010269b6e4e..21abfb24c84950675f725c9ae2a7d104007ac573 100644 (file)
--- a/app/Http/Controllers/Auth/AuthController.php
+++ b/app/Http/Controllers/Auth/AuthController.php
@@ -118,11 +118,22 @@ class AuthController extends Controller
      */
     protected function authenticated(Request $request, Authenticatable $user)
     {
+        if(!$user->exists && $user->email === null && !$request->has('email')) {
+            $request->flash();
+            session()->flash('request-email', true);
+            return redirect('/login');
+        }
+
+        if(!$user->exists && $user->email === null && $request->has('email')) {
+            $user->email = $request->get('email');
+        }
+
         if(!$user->exists) {
             $user->save();
             $this->userRepo->attachDefaultRole($user);
             auth()->login($user);
         }
+
         return redirect()->intended($this->redirectPath());
     }
 
@@ -183,7 +194,7 @@ class AuthController extends Controller
     }
 
     /**
-     * Show the page to tell the user to check thier email
+     * Show the page to tell the user to check their email
      * and confirm their address.
      */
     public function getRegisterConfirmation()
@@ -243,7 +254,7 @@ class AuthController extends Controller
         ]);
         $user = $this->userRepo->getByEmail($request->get('email'));
         $this->emailConfirmationService->sendConfirmation($user);
-        \Session::flash('success', 'Confirmation email resent, Please check your inbox.');
+        session()->flash('success', 'Confirmation email resent, Please check your inbox.');
         return redirect('/register/confirm');
     }
 

diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php
index 9184b245ef29c0324de3f397c735b4ca346d4042..f504f447734c77d242c9146d536ce99f60d518e9 100644 (file)
--- a/app/Http/Controllers/UserController.php
+++ b/app/Http/Controllers/UserController.php
@@ -46,7 +46,8 @@ class UserController extends Controller
     public function create()
     {
         $this->checkPermission('user-create');
-        return view('users/create');
+        $authMethod = config('auth.method');
+        return view('users/create', ['authMethod' => $authMethod]);
     }
 
     /**
@@ -94,10 +95,12 @@ class UserController extends Controller
             return $this->currentUser->id == $id;
         });
 
+        $authMethod = config('auth.method');
+
         $user = $this->user->findOrFail($id);
         $activeSocialDrivers = $socialAuthService->getActiveDrivers();
         $this->setPageTitle('User Profile');
-        return view('users/edit', ['user' => $user, 'activeSocialDrivers' => $activeSocialDrivers]);
+        return view('users/edit', ['user' => $user, 'activeSocialDrivers' => $activeSocialDrivers, 'authMethod' => $authMethod]);
     }
 
     /**
@@ -124,17 +127,24 @@ class UserController extends Controller
         ]);
 
         $user = $this->user->findOrFail($id);
-        $user->fill($request->except('password'));
+        $user->fill($request->all());
 
+        // Role updates
         if ($this->currentUser->can('user-update') && $request->has('role')) {
             $user->attachRoleId($request->get('role'));
         }
 
+        // Password updates
         if ($request->has('password') && $request->get('password') != '') {
             $password = $request->get('password');
             $user->password = bcrypt($password);
         }
 
+        // External auth id updates
+        if ($this->currentUser->can('user-update') && $request->has('external_auth_id')) {
+            $user->external_auth_id = $request->get('external_auth_id');
+        }
+
         $user->save();
         return redirect('/users');
     }

diff --git a/app/Providers/LdapUserProvider.php b/app/Providers/LdapUserProvider.php
index 407791a7d0a555ef1c9ece628a89c5ecef599557..98cfc8340cbe55b2fde188afb0d0f3946c1b8932 100644 (file)
--- a/app/Providers/LdapUserProvider.php
+++ b/app/Providers/LdapUserProvider.php
@@ -87,7 +87,6 @@ class LdapUserProvider implements UserProvider
     public function updateRememberToken(Authenticatable $user, $token)
     {
         $user->setRememberToken($token);
-
         $user->save();
     }
 
@@ -113,6 +112,7 @@ class LdapUserProvider implements UserProvider
 
         $model->name = $userDetails['name'];
         $model->external_auth_id = $userDetails['uid'];
+        $model->email = $userDetails['email'];
         return $model;
     }
 

diff --git a/app/Repos/UserRepo.php b/app/Repos/UserRepo.php
index 88918910ab1c2f25d96ffb87738912fe8bc4aa63..77ad22f3996cf070e5b62c50ed413e326986e81e 100644 (file)
--- a/app/Repos/UserRepo.php
+++ b/app/Repos/UserRepo.php
@@ -88,7 +88,7 @@ class UserRepo
      */
     public function create(array $data)
     {
-        return $this->user->create([
+        return $this->user->forceCreate([
             'name'     => $data['name'],
             'email'    => $data['email'],
             'password' => bcrypt($data['password'])

diff --git a/app/Services/LdapService.php b/app/Services/LdapService.php
index bceed682a96e0657d7bb6225bab77c2c6a320760..cd80290e48b39a1c90b718c2b4e884b6a1f23686 100644 (file)
--- a/app/Services/LdapService.php
+++ b/app/Services/LdapService.php
@@ -23,7 +23,7 @@ class LdapService
         // Find user
         $userFilter = $this->buildFilter(config('services.ldap.user_filter'), ['user' => $userName]);
         $baseDn = config('services.ldap.base_dn');
-        $ldapSearch = ldap_search($ldapConnection, $baseDn, $userFilter, ['cn', 'uid', 'dn']);
+        $ldapSearch = ldap_search($ldapConnection, $baseDn, $userFilter, ['cn', 'uid', 'dn', 'mail']);
         $users = ldap_get_entries($ldapConnection, $ldapSearch);
         if ($users['count'] === 0) return null;
 
@@ -31,7 +31,8 @@ class LdapService
         return [
             'uid'  => $user['uid'][0],
             'name' => $user['cn'][0],
-            'dn'   => $user['dn']
+            'dn'   => $user['dn'],
+            'email' => (isset($user['mail'])) ? $user['mail'][0] : null
         ];
     }
 

diff --git a/app/Services/SettingService.php b/app/Services/SettingService.php
index 7f2549c7d78ed287c00bb6a47ad2f6cc3421469b..bcc7eae31a0a8c3713eb5f6935875f84be81aa45 100644 (file)
--- a/app/Services/SettingService.php
+++ b/app/Services/SettingService.php
@@ -38,7 +38,7 @@ class SettingService
      */
     public function get($key, $default = false)
     {
-        $value =  $this->getValueFromStore($key, $default);
+        $value = $this->getValueFromStore($key, $default);
         return $this->formatValue($value, $default);
     }
 
@@ -50,13 +50,17 @@ class SettingService
      */
     protected function getValueFromStore($key, $default)
     {
+        $overrideValue = $this->getOverrideValue($key);
+        if ($overrideValue !== null) return $overrideValue;
+
         $cacheKey = $this->cachePrefix . $key;
         if ($this->cache->has($cacheKey)) {
             return $this->cache->get($cacheKey);
         }
 
         $settingObject = $this->getSettingObjectByKey($key);
-        if($settingObject !== null) {
+
+        if ($settingObject !== null) {
             $value = $settingObject->value;
             $this->cache->forever($cacheKey, $value);
             return $value;
@@ -65,6 +69,10 @@ class SettingService
         return $default;
     }
 
+    /**
+     * Clear an item from the cache completely.
+     * @param $key
+     */
     protected function clearFromCache($key)
     {
         $cacheKey = $this->cachePrefix . $key;
@@ -136,9 +144,23 @@ class SettingService
      * @param $key
      * @return mixed
      */
-    private function getSettingObjectByKey($key)
+    protected function getSettingObjectByKey($key)
     {
         return $this->setting->where('setting_key', '=', $key)->first();
     }
 
+
+    /**
+     * Returns an override value for a setting based on certain app conditions.
+     * Used where certain configuration options overrule others.
+     * Returns null if no override value is available.
+     * @param $key
+     * @return bool|null
+     */
+    protected function getOverrideValue($key)
+    {
+        if ($key === 'registration-enabled' && config('auth.method') === 'ldap') return false;
+        return null;
+    }
+
 }
\ No newline at end of file

diff --git a/app/User.php b/app/User.php
index 1be98c3c46d86230b220574414acb863adf216d4..4a5914afd0a0a663289572a35ca4324e3de96cf8 100644 (file)
--- a/app/User.php
+++ b/app/User.php
@@ -24,7 +24,7 @@ class User extends Model implements AuthenticatableContract, CanResetPasswordCon
      *
      * @var array
      */
-    protected $fillable = ['name', 'email', 'password', 'image_id'];
+    protected $fillable = ['name', 'email', 'image_id'];
 
     /**
      * The attributes excluded from the model's JSON form.
@@ -68,7 +68,7 @@ class User extends Model implements AuthenticatableContract, CanResetPasswordCon
     }
 
     /**
-     * Loads the user's permissions from thier role.
+     * Loads the user's permissions from their role.
      */
     private function loadPermissions()
     {

diff --git a/config/auth.php b/config/auth.php
index 0f2d5a69c8cb0a9c9787ac78b9978f11a9acf6cc..ceeab5c71d88aecd074316f77f7fdf589e89a3a0 100644 (file)
--- a/config/auth.php
+++ b/config/auth.php
@@ -69,7 +69,7 @@ return [
 
     'providers' => [
         'users' => [
-            'driver' => env('AUTH_METHOD', 'eloquent'),
+            'driver' => env('AUTH_METHOD', 'standard') === 'standard' ? 'eloquent' : env('AUTH_METHOD'),
             'model' => BookStack\User::class,
         ],
 

diff --git a/phpunit.xml b/phpunit.xml
index 1704159e25d02a729f3f1ec76e620e4bd3bc58eb..48c0dde2203c3f6f5d65ba256a298dd552bce243 100644 (file)
--- a/phpunit.xml
+++ b/phpunit.xml
@@ -26,6 +26,7 @@
         <env name="QUEUE_DRIVER" value="sync"/>
         <env name="DB_CONNECTION" value="mysql_testing"/>
         <env name="MAIL_PRETEND" value="true"/>
+        <env name="AUTH_METHOD" value="standard"/>
         <env name="DISABLE_EXTERNAL_SERVICES" value="false"/>
     </php>
 </phpunit>

diff --git a/resources/views/auth/forms/login/ldap.blade.php b/resources/views/auth/forms/login/ldap.blade.php
index eb0a3182fdff440736676fba13cc4014158c74aa..5230d43ca03086fde6fdab5c8ca925a0e2b4112c 100644 (file)
--- a/resources/views/auth/forms/login/ldap.blade.php
+++ b/resources/views/auth/forms/login/ldap.blade.php
@@ -3,6 +3,16 @@
     @include('form/text', ['name' => 'username', 'tabindex' => 1])
 </div>
 
+@if(session('request-email', false) === true)
+    <div class="form-group">
+        <label for="email">Email</label>
+        @include('form/text', ['name' => 'email', 'tabindex' => 1])
+        <span class="text-neg">
+            Please enter an email to use for this account.
+        </span>
+    </div>
+@endif
+
 <div class="form-group">
     <label for="password">Password</label>
     @include('form/password', ['name' => 'password', 'tabindex' => 2])

diff --git a/resources/views/users/create.blade.php b/resources/views/users/create.blade.php
index f20ae6fc4b6684aef4732f1604b98685cc5f3737..e6398b8679b45ef9ef1c0ea86099f92b9d9968e8 100644 (file)
--- a/resources/views/users/create.blade.php
+++ b/resources/views/users/create.blade.php
@@ -8,7 +8,7 @@
 
         <form action="/users/create" method="post">
             {!! csrf_field() !!}
-            @include('users/form')
+            @include('users.forms.' . $authMethod)
         </form>
     </div>
 

diff --git a/resources/views/users/edit.blade.php b/resources/views/users/edit.blade.php
index e7100bdb1675bfb26e4b05253a10d3d47c2c7e0d..59457eb15752de06d431e957a10599f4982e5b9f 100644 (file)
--- a/resources/views/users/edit.blade.php
+++ b/resources/views/users/edit.blade.php
@@ -25,7 +25,7 @@
                 <h1>Edit {{ $user->id === $currentUser->id ? 'Profile' : 'User' }}</h1>
                 {!! csrf_field() !!}
                 <input type="hidden" name="_method" value="put">
-                @include('users/form', ['model' => $user])
+                @include('users.forms.' . $authMethod, ['model' => $user])
 
             </div>
             <div class="col-md-6">

diff --git a/resources/views/users/forms/ldap.blade.php b/resources/views/users/forms/ldap.blade.php
new file mode 100644 (file)
index 0000000..3897dfd
--- /dev/null
+++ b/resources/views/users/forms/ldap.blade.php
@@ -0,0 +1,30 @@
+<div class="form-group">
+    <label for="name">Name</label>
+    @include('form.text', ['name' => 'name'])
+</div>
+
+@if($currentUser->can('user-update'))
+<div class="form-group">
+    <label for="email">Email</label>
+    @include('form.text', ['name' => 'email'])
+</div>
+@endif
+
+@if($currentUser->can('user-update'))
+    <div class="form-group">
+        <label for="role">User Role</label>
+        @include('form.role-select', ['name' => 'role', 'options' => \BookStack\Role::all(), 'displayKey' => 'display_name'])
+    </div>
+@endif
+
+@if($currentUser->can('user-update'))
+    <div class="form-group">
+        <label for="external_auth_id">External Authentication ID</label>
+        @include('form.text', ['name' => 'external_auth_id'])
+    </div>
+@endif
+
+<div class="form-group">
+    <a href="/users" class="button muted">Cancel</a>
+    <button class="button pos" type="submit">Save</button>
+</div>
\ No newline at end of file

diff --git a/resources/views/users/form.blade.php b/resources/views/users/forms/standard.blade.php
similarity index 81%
rename from resources/views/users/form.blade.php
rename to resources/views/users/forms/standard.blade.php
index 16176bb8decfa0a7fa24877c7809f8183d44d9f2..7960a7ed5cee677664f8d2362fd372fb255c8f19 100644 (file)
--- a/resources/views/users/form.blade.php
+++ b/resources/views/users/forms/standard.blade.php
@@ -1,11 +1,11 @@
 <div class="form-group">
     <label for="name">Name</label>
-    @include('form/text', ['name' => 'name'])
+    @include('form.text', ['name' => 'name'])
 </div>
 
 <div class="form-group">
     <label for="email">Email</label>
-    @include('form/text', ['name' => 'email'])
+    @include('form.text', ['name' => 'email'])
 </div>
 
 @if($currentUser->can('user-update'))
@@ -25,12 +25,12 @@
 
 <div class="form-group">
     <label for="password">Password</label>
-    @include('form/password', ['name' => 'password'])
+    @include('form.password', ['name' => 'password'])
 </div>
 
 <div class="form-group">
     <label for="password-confirm">Confirm Password</label>
-    @include('form/password', ['name' => 'password-confirm'])
+    @include('form.password', ['name' => 'password-confirm'])
 </div>
 
 <div class="form-group">