]> BookStack Code Mirror - bookstack/commitdiff
Fixed test failing due to redirect changes
authorDan Brown <redacted>
Sat, 21 Dec 2019 13:48:44 +0000 (13:48 +0000)
committerDan Brown <redacted>
Sat, 21 Dec 2019 13:48:44 +0000 (13:48 +0000)
- Also set APP_THEME param during testing to avoid local conflicts

phpunit.xml
tests/Permissions/RolesTest.php

index 48eba5e9968f832739c097627f9a094f606f0718..546829247c6980b470e82eecf0dd0a523ef4efb2 100644 (file)
@@ -22,6 +22,7 @@
         <server name="APP_ENV" value="testing"/>
         <server name="APP_DEBUG" value="false"/>
         <server name="APP_LANG" value="en"/>
+        <server name="APP_THEME" value="none"/>
         <server name="APP_AUTO_LANG_PUBLIC" value="true"/>
         <server name="CACHE_DRIVER" value="array"/>
         <server name="SESSION_DRIVER" value="array"/>
index 371cffc0f3bd1be95a263c2bffd4c5f4277bb8f2..2ef72fb0aef8999403553d00819ae59ea9a2acf4 100644 (file)
@@ -637,14 +637,14 @@ class RolesTest extends BrowserKitTest
             $ownPage->getUrl() => 'Delete'
         ]);
 
-        $bookUrl = $ownPage->book->getUrl();
+        $parent = $ownPage->chapter ?? $ownPage->book;
         $this->visit($otherPage->getUrl())
             ->dontSeeInElement('.action-buttons', 'Delete')
             ->visit($otherPage->getUrl() . '/delete')
             ->seePageIs('/');
         $this->visit($ownPage->getUrl())->visit($ownPage->getUrl() . '/delete')
             ->press('Confirm')
-            ->seePageIs($bookUrl)
+            ->seePageIs($parent->getUrl())
             ->dontSeeInElement('.book-content', $ownPage->name);
     }
 
@@ -658,10 +658,10 @@ class RolesTest extends BrowserKitTest
             $otherPage->getUrl() => 'Delete'
         ]);
 
-        $bookUrl = $otherPage->book->getUrl();
+        $parent = $otherPage->chapter ?? $otherPage->book;
         $this->visit($otherPage->getUrl())->visit($otherPage->getUrl() . '/delete')
             ->press('Confirm')
-            ->seePageIs($bookUrl)
+            ->seePageIs($parent->getUrl())
             ->dontSeeInElement('.book-content', $otherPage->name);
     }