Fixed attachment error handling, Allowed all link types

Related to #812

diff --git a/app/Attachment.php b/app/Attachment.php
index 55344cd7d4d47c26b85d486843ce5d1c6791252e..6749130d9686268dde0ee1299d03d26284a70687 100644 (file)
--- a/app/Attachment.php
+++ b/app/Attachment.php
@@ -31,6 +31,9 @@ class Attachment extends Ownable
      */
     public function getUrl()
     {
      */
     public function getUrl()
     {

+        if ($this->external && strpos($this->path, 'http') !== 0) {
+            return $this->path;
+        }

         return baseUrl('/attachments/' . $this->id);
     }
 }
         return baseUrl('/attachments/' . $this->id);
     }
 }

diff --git a/app/Http/Controllers/AttachmentController.php b/app/Http/Controllers/AttachmentController.php
index ea41278aebc0082ef93054985b28eb4c1cff3db2..54e14bfb6f4cd654c7bf7e9c2353432b373c6e6f 100644 (file)
--- a/app/Http/Controllers/AttachmentController.php
+++ b/app/Http/Controllers/AttachmentController.php
@@ -103,7 +103,7 @@ class AttachmentController extends Controller
         $this->validate($request, [
             'uploaded_to' => 'required|integer|exists:pages,id',
             'name' => 'required|string|min:1|max:255',
         $this->validate($request, [
             'uploaded_to' => 'required|integer|exists:pages,id',
             'name' => 'required|string|min:1|max:255',

-            'link' =>  'url|min:1|max:255'
+            'link' =>  'string|min:1|max:255'

         ]);
 
         $pageId = $request->get('uploaded_to');
         ]);
 
         $pageId = $request->get('uploaded_to');


@@ -131,7 +131,7 @@ class AttachmentController extends Controller
         $this->validate($request, [
             'uploaded_to' => 'required|integer|exists:pages,id',
             'name' => 'required|string|min:1|max:255',
         $this->validate($request, [
             'uploaded_to' => 'required|integer|exists:pages,id',
             'name' => 'required|string|min:1|max:255',

-            'link' =>  'required|url|min:1|max:255'
+            'link' =>  'required|string|min:1|max:255'

         ]);
 
         $pageId = $request->get('uploaded_to');
         ]);
 
         $pageId = $request->get('uploaded_to');


@@ -184,6 +184,7 @@ class AttachmentController extends Controller
      * @param $attachmentId
      * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|\Symfony\Component\HttpFoundation\Response
      * @throws \Illuminate\Contracts\Filesystem\FileNotFoundException
      * @param $attachmentId
      * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|\Symfony\Component\HttpFoundation\Response
      * @throws \Illuminate\Contracts\Filesystem\FileNotFoundException

+     * @throws NotFoundException

      */
     public function get($attachmentId)
     {
      */
     public function get($attachmentId)
     {

diff --git a/resources/assets/js/vues/attachment-manager.js b/resources/assets/js/vues/attachment-manager.js
index 635622b93e80dcb8a584c6d6201e52ea7f678425..16f96c70b378df6b91e5a9e63f66fc979e4988b3 100644 (file)
--- a/resources/assets/js/vues/attachment-manager.js
+++ b/resources/assets/js/vues/attachment-manager.js
@@ -31,6 +31,9 @@ let methods = {
     },
 
     getFileUrl(file) {
     },
 
     getFileUrl(file) {

+        if (file.external && file.path.indexOf('http') !== 0) {
+            return file.path;
+        }

         return window.baseUrl(`/attachments/${file.id}`);
     },
 
         return window.baseUrl(`/attachments/${file.id}`);
     },
 


@@ -79,10 +82,8 @@ let methods = {
     },
 
     checkValidationErrors(groupName, err) {
     },
 
     checkValidationErrors(groupName, err) {

-        console.error(err);
-        if (typeof err.response.data === "undefined" && typeof err.response.data.validation === "undefined") return;
-        this.errors[groupName] = err.response.data.validation;
-        console.log(this.errors[groupName]);
+        if (typeof err.response.data === "undefined" && typeof err.response.data === "undefined") return;
+        this.errors[groupName] = err.response.data;

     },
 
     getUploadUrl(file) {
     },
 
     getUploadUrl(file) {


@@ -97,6 +98,7 @@ let methods = {
 
     attachNewLink(file) {
         file.uploaded_to = this.pageId;
 
     attachNewLink(file) {
         file.uploaded_to = this.pageId;

+        this.errors.link = {};

         this.$http.post(window.baseUrl('/attachments/link'), file).then(resp => {
             this.files.push(resp.data);
             this.file = this.newFile();
         this.$http.post(window.baseUrl('/attachments/link'), file).then(resp => {
             this.files.push(resp.data);
             this.file = this.newFile();