Updated comment delete action to be a button

Fixes issue that causes code error when an anchor tag.

Closes #1650

diff --git a/resources/assets/js/components/page-comments.js b/resources/assets/js/components/page-comments.js
index cabce91396082cf1944153e274d590643ed25742..5d8d169589804a5c92fd355281353bdcdaf6ed88 100644 (file)
--- a/resources/assets/js/components/page-comments.js
+++ b/resources/assets/js/components/page-comments.js
@@ -26,10 +26,12 @@ class PageComments {
 
     handleAction(event) {
         let actionElem = event.target.closest('[action]');
+
         if (event.target.matches('a[href^="#"]')) {
             const id = event.target.href.split('#')[1];
             scrollAndHighlightElement(document.querySelector('#' + id));
         }
+
         if (actionElem === null) return;
         event.preventDefault();
 

diff --git a/resources/views/comments/comment.blade.php b/resources/views/comments/comment.blade.php
index 5fbdfa500c6f10d14ddc64db887eb5ee2c8a824f..ea96a9250dd24a22f2bf274fc093f52edcd6454e 100644 (file)
--- a/resources/views/comments/comment.blade.php
+++ b/resources/views/comments/comment.blade.php
@@ -31,7 +31,7 @@
                         <button type="button" dropdown-toggle aria-haspopup="true" aria-expanded="false" class="text-button" title="{{ trans('common.delete') }}">@icon('delete')</button>
                         <ul class="dropdown-menu" role="menu">
                             <li class="px-m text-small text-muted pb-s">{{trans('entities.comment_delete_confirm')}}</li>
-                            <li><a action="delete" href="#" class="text-button text-neg" >@icon('delete'){{ trans('common.delete') }}</a></li>
+                            <li><button action="delete" type="button" class="text-button text-neg" >@icon('delete'){{ trans('common.delete') }}</button></li>
                         </ul>
                     </div>
                 @endif