Updated sort logic to handle chapter to book scenario

- Extended tests out to cover

diff --git a/app/Entities/Repos/PageRepo.php b/app/Entities/Repos/PageRepo.php
index 501b19c78fa84ba712ffeee46c2c61194caa94cf..e49eeb1ef5518eb8aa124d11e981236f11ebbe04 100644 (file)
--- a/app/Entities/Repos/PageRepo.php
+++ b/app/Entities/Repos/PageRepo.php
@@ -306,10 +306,7 @@ class PageRepo
             throw new PermissionsException('User does not have permission to create a page within the new parent');
         }
 
             throw new PermissionsException('User does not have permission to create a page within the new parent');
         }
 

-        if ($parent instanceof Chapter) {
-            $page->chapter_id = $parent->id;
-        }
-
+        $page->chapter_id = ($parent instanceof Chapter) ? $parent->id : null;

         $page->changeBook($parent instanceof Book ? $parent->id : $parent->book->id);
         $page->rebuildPermissions();
 
         $page->changeBook($parent instanceof Book ? $parent->id : $parent->book->id);
         $page->rebuildPermissions();
 

diff --git a/tests/Entity/SortTest.php b/tests/Entity/SortTest.php
index d7c004dc852982537c75897af4200a6c2e6862fa..7d67f05c6d6b0b77be7dde916d3c497c512d0482 100644 (file)
--- a/tests/Entity/SortTest.php
+++ b/tests/Entity/SortTest.php
@@ -66,10 +66,28 @@ class SortTest extends TestCase
         $this->assertTrue($page->book->id == $newBook->id, 'Page parent is now the new chapter');
 
         $newChapterResp = $this->get($newChapter->getUrl());
         $this->assertTrue($page->book->id == $newBook->id, 'Page parent is now the new chapter');
 
         $newChapterResp = $this->get($newChapter->getUrl());

-        $newChapterResp->assertSee('moved page');

         $newChapterResp->assertSee($page->name);
     }
 
         $newChapterResp->assertSee($page->name);
     }
 

+    public function test_page_move_from_chapter_to_book()
+    {
+        $oldChapter = Chapter::first();
+        $page = $oldChapter->pages()->first();
+        $newBook = Book::where('id', '!=', $oldChapter->book_id)->first();
+
+        $movePageResp = $this->actingAs($this->getEditor())->put($page->getUrl('/move'), [
+            'entity_selection' => 'book:' . $newBook->id
+        ]);
+        $page = Page::find($page->id);
+
+        $movePageResp->assertRedirect($page->getUrl());
+        $this->assertTrue($page->book->id == $newBook->id, 'Page parent is now the new book');
+        $this->assertTrue($page->chapter === null, 'Page has no parent chapter');
+
+        $newBookResp = $this->get($newBook->getUrl());
+        $newBookResp->assertSee($page->name);
+    }
+

     public function test_page_move_requires_create_permissions_on_parent()
     {
         $page = Page::first();
     public function test_page_move_requires_create_permissions_on_parent()
     {
         $page = Page::first();