]> BookStack Code Mirror - bookstack/commitdiff
Testing: Added PHP8.3 support
authorDan Brown <redacted>
Tue, 31 Oct 2023 15:50:56 +0000 (15:50 +0000)
committerDan Brown <redacted>
Tue, 31 Oct 2023 15:52:01 +0000 (15:52 +0000)
Also fixed text which could through deprecation notice due to not having
a properly formed comment in use.
For #4633

.github/workflows/test-migrations.yml
.github/workflows/test-php.yml
tests/Activity/WatchTest.php

index 710fafcf2ba29a569dca98f9d9a4bb05ad00c3e8..63f52a295063ddc379bec20bd50722b94afff489 100644 (file)
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        php: ['8.0', '8.1', '8.2']
+        php: ['8.0', '8.1', '8.2', '8.3']
     steps:
       - uses: actions/checkout@v1
 
index 64b1a2915915d7b21667697a838513bddcddb0da..89ebf0deceb411298cc3a9156689136126e264c9 100644 (file)
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        php: ['8.0', '8.1', '8.2']
+        php: ['8.0', '8.1', '8.2', '8.3']
     steps:
     - uses: actions/checkout@v1
 
index 5b9ae5a4c9e3d1996b652cab41f00675d7d9962a..63e51c92e822a82dbff6dd4fa11bdd5092fd8c2e 100644 (file)
@@ -336,7 +336,10 @@ class WatchTest extends TestCase
         $activities = [
             ActivityType::PAGE_CREATE => $entities['page'],
             ActivityType::PAGE_UPDATE => $entities['page'],
-            ActivityType::COMMENT_CREATE => (new Comment([]))->forceFill(['entity_id' => $entities['page']->id, 'entity_type' => $entities['page']->getMorphClass()]),
+            ActivityType::COMMENT_CREATE => Comment::factory()->make([
+                'entity_id' => $entities['page']->id,
+                'entity_type' => $entities['page']->getMorphClass(),
+            ]),
         ];
 
         $notifications = Notification::fake();