]> BookStack Code Mirror - bookstack/commitdiff
Fixed dodgy test helper signature causing tests to fail
authorDan Brown <redacted>
Sat, 18 Sep 2021 20:29:42 +0000 (21:29 +0100)
committerDan Brown <redacted>
Sat, 18 Sep 2021 20:29:42 +0000 (21:29 +0100)
Just needed some argument defaults to make them optional for existing
uses.

tests/TestCase.php

index 30b07da0fddf46c5e6de1628e4249753d78457d6..98e0dfbacf4c4cfb6321a55d9aa44fe9e491c6ef 100644 (file)
@@ -62,7 +62,7 @@ abstract class TestCase extends BaseTestCase
      * Assert that an activity entry exists of the given key.
      * Checks the activity belongs to the given entity if provided.
      */
-    protected function assertActivityExists(string $type, ?Entity $entity, ?string $detail)
+    protected function assertActivityExists(string $type, ?Entity $entity = null, string $detail = '')
     {
         $detailsToCheck = ['type' => $type];