From: Dan Brown Date: Mon, 10 Jun 2024 09:31:35 +0000 (+0100) Subject: SAML: Set static type to pass static checks X-Git-Tag: v24.05.2~1^2~1 X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/11a7ccc37e6ff62b7d666d89ae80f5f4a3ebea99 SAML: Set static type to pass static checks Not totally clear if underlying code can actually return null, but playing it safe to remain as-is for now for patch release. --- diff --git a/app/Access/Saml2Service.php b/app/Access/Saml2Service.php index 664b77aba..bb7e9b572 100644 --- a/app/Access/Saml2Service.php +++ b/app/Access/Saml2Service.php @@ -133,6 +133,7 @@ class Saml2Service // value so that the exact encoding format is matched when checking the signature. // This is primarily due to ADFS encoding query params with lowercase percent encoding while // PHP (And most other sensible providers) standardise on uppercase. + /** @var ?string $samlRedirect */ $samlRedirect = $toolkit->processSLO(true, $requestId, true, null, true); $errors = $toolkit->getErrors();