From: Dan Brown <redacted>
Date: Mon, 15 Jan 2024 11:50:05 +0000 (+0000)
Subject: Attachments: Drag and drop video support
X-Git-Tag: v24.02~1^2~24^2~1
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/c1552fb799cda7fbb6de27ebcb01aa2580fd5330

Attachments: Drag and drop video support

Supports dragging and dropping video attahchments to embed them in the
editor as HTML video tags.
---

diff --git a/app/Uploads/Attachment.php b/app/Uploads/Attachment.php
index 4fd6d4cdc..57d7cb334 100644
--- a/app/Uploads/Attachment.php
+++ b/app/Uploads/Attachment.php
@@ -77,7 +77,22 @@ class Attachment extends Model
     }
 
     /**
-     * Generate a HTML link to this attachment.
+     * Get the representation of this attachment in a format suitable for the page editors.
+     * Detects and adapts video content to use an inline video embed.
+     */
+    public function editorContent(): array
+    {
+        $videoExtensions = ['mp4', 'webm', 'mkv', 'ogg', 'avi'];
+        if (in_array(strtolower($this->extension), $videoExtensions)) {
+            $html = '<video src="' . e($this->getUrl(true)) . '" controls width="480" height="270"></video>';
+            return ['text/html' => $html, 'text/plain' => $html];
+        }
+
+        return ['text/html' => $this->htmlLink(), 'text/plain' => $this->markdownLink()];
+    }
+
+    /**
+     * Generate the HTML link to this attachment.
      */
     public function htmlLink(): string
     {
@@ -85,7 +100,7 @@ class Attachment extends Model
     }
 
     /**
-     * Generate a markdown link to this attachment.
+     * Generate a MarkDown link to this attachment.
      */
     public function markdownLink(): string
     {
diff --git a/resources/views/attachments/manager-list.blade.php b/resources/views/attachments/manager-list.blade.php
index 342b46dca..0e841a042 100644
--- a/resources/views/attachments/manager-list.blade.php
+++ b/resources/views/attachments/manager-list.blade.php
@@ -4,7 +4,7 @@
         <div component="ajax-delete-row"
              option:ajax-delete-row:url="{{ url('/http/source.bookstackapp.com/attachments/' . $attachment->id) }}"
              data-id="{{ $attachment->id }}"
-             data-drag-content="{{ json_encode(['text/html' => $attachment->htmlLink(), 'text/plain' => $attachment->markdownLink()]) }}"
+             data-drag-content="{{ json_encode($attachment->editorContent()) }}"
              class="card drag-card">
             <div class="handle">@icon('grip')</div>
             <div class="py-s">