From: Dan Brown <redacted>
Date: Tue, 3 Oct 2023 13:59:35 +0000 (+0100)
Subject: Print Styles: Fixed header/footer content showing
X-Git-Tag: v23.10~1^2~16
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/c5d5b6e3c1f85bab1cc7e18f85b4b3ca8c101a1c?ds=inline

Print Styles: Fixed header/footer content showing

Extra bits were showing due to recent changes.
Done a quick pass through major display views.

Fixes #4594
---

diff --git a/resources/sass/print-styles.scss b/resources/sass/print-styles.scss
index 2c51bd75c..cfc0ecdad 100644
--- a/resources/sass/print-styles.scss
+++ b/resources/sass/print-styles.scss
@@ -1,10 +1,6 @@
 @use "sass:math";
 @import "variables";
 
-header {
-  display: none;
-}
-
 html, body {
   font-size: 12px;
   background-color: #FFF;
diff --git a/resources/views/books/show.blade.php b/resources/views/books/show.blade.php
index 9e7df4156..8f7c3f6cf 100644
--- a/resources/views/books/show.blade.php
+++ b/resources/views/books/show.blade.php
@@ -17,7 +17,7 @@
 
 @section('body')
 
-    <div class="mb-s">
+    <div class="mb-s print-hidden">
         @include('entities.breadcrumbs', ['crumbs' => [
             $book,
         ]])
diff --git a/resources/views/layouts/parts/footer.blade.php b/resources/views/layouts/parts/footer.blade.php
index dd488dce5..4275866bc 100644
--- a/resources/views/layouts/parts/footer.blade.php
+++ b/resources/views/layouts/parts/footer.blade.php
@@ -1,5 +1,5 @@
 @if(count(setting('app-footer-links', [])) > 0)
-<footer>
+<footer class="print-hidden">
     @foreach(setting('app-footer-links', []) as $link)
         <a href="{{ $link['url'] }}" target="_blank" rel="noopener">{{ strpos($link['label'], 'trans::') === 0 ? trans(str_replace('trans::', '', $link['label'])) : $link['label'] }}</a>
     @endforeach
diff --git a/resources/views/layouts/parts/header.blade.php b/resources/views/layouts/parts/header.blade.php
index 25f8e8c54..0e3ad4466 100644
--- a/resources/views/layouts/parts/header.blade.php
+++ b/resources/views/layouts/parts/header.blade.php
@@ -1,4 +1,4 @@
-<header id="header" component="header-mobile-toggle" class="primary-background px-xl grid">
+<header id="header" component="header-mobile-toggle" class="primary-background px-xl grid print-hidden">
     <div>
         @include('layouts.parts.header-logo')
         <button type="button"
diff --git a/resources/views/pages/show.blade.php b/resources/views/pages/show.blade.php
index 5d70f7c28..e3a31dd5e 100644
--- a/resources/views/pages/show.blade.php
+++ b/resources/views/pages/show.blade.php
@@ -29,7 +29,7 @@
 
     @if ($commentTree->enabled())
         @if(($previous || $next))
-            <div class="px-xl">
+            <div class="px-xl print-hidden">
                 <hr class="darker">
             </div>
         @endif
diff --git a/resources/views/shelves/show.blade.php b/resources/views/shelves/show.blade.php
index 8694ce86d..58fe1cd86 100644
--- a/resources/views/shelves/show.blade.php
+++ b/resources/views/shelves/show.blade.php
@@ -11,7 +11,7 @@
 
 @section('body')
 
-    <div class="mb-s">
+    <div class="mb-s print-hidden">
         @include('entities.breadcrumbs', ['crumbs' => [
             $shelf,
         ]])