From: Dan Brown <redacted>
Date: Sat, 5 Sep 2020 18:26:47 +0000 (+0100)
Subject: Updated saml2 slo config so url is used if no repsonse url
X-Git-Tag: v0.30.0~1^2~17^2~1
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/e5377d5f46539c6b8098000135d2f3f5fab4cd81?ds=inline

Updated saml2 slo config so url is used if no repsonse url

Updated config to change empty string to null since the empty string was
hitting an isset check which caused an empty string to be used instead
of the slo url as a backup option.

Closes #2002
---

diff --git a/app/Config/saml2.php b/app/Config/saml2.php
index 5f2c1395b..d695abf32 100644
--- a/app/Config/saml2.php
+++ b/app/Config/saml2.php
@@ -101,7 +101,7 @@ return [
                 'url' => env('SAML2_IDP_SLO', null),
                 // URL location of the IdP where the SP will send the SLO Response (ResponseLocation)
                 // if not set, url for the SLO Request will be used
-                'responseUrl' => '',
+                'responseUrl' => null,
                 // SAML protocol binding to be used when returning the <Response>
                 // message.  Onelogin Toolkit supports for this endpoint the
                 // HTTP-Redirect binding only