From: Dan Brown <redacted>
Date: Tue, 31 Oct 2023 15:50:56 +0000 (+0000)
Subject: Testing: Added PHP8.3 support
X-Git-Tag: v23.10.1~1^2~6
X-Git-Url: http://source.bookstackapp.com/bookstack/commitdiff_plain/fce7190257d0e047e17b70e2c56dea6a0617a225

Testing: Added PHP8.3 support

Also fixed text which could through deprecation notice due to not having
a properly formed comment in use.
For #4633
---

diff --git a/.github/workflows/test-migrations.yml b/.github/workflows/test-migrations.yml
index 710fafcf2..63f52a295 100644
--- a/.github/workflows/test-migrations.yml
+++ b/.github/workflows/test-migrations.yml
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        php: ['8.0', '8.1', '8.2']
+        php: ['8.0', '8.1', '8.2', '8.3']
     steps:
       - uses: actions/checkout@v1
 
diff --git a/.github/workflows/test-php.yml b/.github/workflows/test-php.yml
index 64b1a2915..89ebf0dec 100644
--- a/.github/workflows/test-php.yml
+++ b/.github/workflows/test-php.yml
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        php: ['8.0', '8.1', '8.2']
+        php: ['8.0', '8.1', '8.2', '8.3']
     steps:
     - uses: actions/checkout@v1
 
diff --git a/tests/Activity/WatchTest.php b/tests/Activity/WatchTest.php
index 5b9ae5a4c..63e51c92e 100644
--- a/tests/Activity/WatchTest.php
+++ b/tests/Activity/WatchTest.php
@@ -336,7 +336,10 @@ class WatchTest extends TestCase
         $activities = [
             ActivityType::PAGE_CREATE => $entities['page'],
             ActivityType::PAGE_UPDATE => $entities['page'],
-            ActivityType::COMMENT_CREATE => (new Comment([]))->forceFill(['entity_id' => $entities['page']->id, 'entity_type' => $entities['page']->getMorphClass()]),
+            ActivityType::COMMENT_CREATE => Comment::factory()->make([
+                'entity_id' => $entities['page']->id,
+                'entity_type' => $entities['page']->getMorphClass(),
+            ]),
         ];
 
         $notifications = Notification::fake();