Dan Brown [Tue, 22 Jul 2025 15:42:47 +0000 (16:42 +0100)]
MD Editor: Worked to improve/fix positioning code
Still pending testing. Old logic did not work when lines would wrap, so
changing things to a character/line measuring technique.
Fixed some other isues too while testing shortcuts.
Dan Brown [Tue, 15 Jul 2025 14:24:31 +0000 (15:24 +0100)]
Mail: Removed custom symfony/mailer fork
Moved to standard symfony mailer now that my patches have been
upstreamed. This changes the config to work with the symfony option,
following the same overall logic.
Also updated testing to allow test runs via mulitple custom env options.
Dan Brown [Wed, 2 Jul 2025 11:15:25 +0000 (12:15 +0100)]
Perms: Removed entity perm regen on general update
Should not be needed here as this is not directly used for information
which should impact permissions.
Been through uses to ensure that this is the case.
Dan Brown [Mon, 30 Jun 2025 12:19:45 +0000 (13:19 +0100)]
Layout: Improved sidebar sizing, and dropdown consideration
- Updated tri-layout sidebars to have less padding and to avoid cutting
off content when in single-sidebar mode.
- Updated dropdown handling to consider the parent scroll container when
deciding to drop upwards, to help prevent cut-off.
Dan Brown [Wed, 25 Jun 2025 13:16:01 +0000 (14:16 +0100)]
Comments: Switched to lexical editor
Required a lot of changes to provide at least a decent attempt at proper
editor teardown control.
Also updates HtmlDescriptionFilter and testing to address issue with bad
child iteration which could lead to missed items.
Renamed editor version from comments to basic as it'll also be used for
item descriptions.
bumperbox [Sun, 22 Jun 2025 21:31:39 +0000 (09:31 +1200)]
CommentDisplayTest correct namespace
Class Entity\CommentDisplayTest located in ./tests/Entity/CommentDisplayTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Dan Brown [Sun, 15 Jun 2025 14:22:27 +0000 (15:22 +0100)]
Lexical: Added a media toolbar, improved toolbars and media selection
- Updated toolbars to auto-refresh ui if it attempts to update targeting
a DOM element which no longer exists.
- Removed MediaNode dom specific click handling which was causing
selection issues, and did not seem to be needed now.
Dan Brown [Sun, 15 Jun 2025 12:55:42 +0000 (13:55 +0100)]
Lexical: Fixed media resize handling
- Updating height/width setting to clear any inline CSS width/height
rules which would override and prevent resizes showing. This was
common when switching media from old editor.
Added test to cover.
- Updated resizer to track node so that it is retained & displayed
across node DOM changes, which was previously causing the
resizer/focus to disappear.
Formatting was not persisted on empty paragraphs, and was instead based
upon last format encountered in selection.
This was due to overly-hasty removal of other formatting code, which
this got caught it.
Restored required parts from prior codebase.
Also updated inline format button active indicator to reflect formats
using the above, so correct buttons are shown as active even when just
in an empty paragraph.
Dan Brown [Fri, 13 Jun 2025 15:38:53 +0000 (16:38 +0100)]
Lexical: Made table resize handles more efficent & less buggy
Fine mouse movement and handles will now only be active when actually
within a table, otherwise less frequent mouseovers are used to track if
in/out a table.
Hides handles when out of a table, preventing a range of issues with
stray handles floating about.
Dan Brown [Wed, 28 May 2025 21:47:39 +0000 (22:47 +0100)]
Lexical: Further improvements to table selection and captions
- Fixed errors with selection and range handling due to captions
existing.
- Updated TableNode change handling to update existing DOM instead of
re-creating, which avoids breaking an attached selection helper.
- To support, Added function to handle node change detection and apply
relevant dom updates for common properties.
Dan Brown [Wed, 28 May 2025 21:00:24 +0000 (22:00 +0100)]
Comments: Fixed tab focus change & button placement on form usage
Fixes issue of tabs jumping back to active comments when stopping a
reply to an archived comment.
Fixes button placement looking odd due to wrong location and differing
styles depending on interaction path.
Dan Brown [Mon, 26 May 2025 17:47:51 +0000 (18:47 +0100)]
Lexical: Changed table esacpe handling
Avoids misuse of selectPrevious/Next as per prior commit which was then
causing problems elsewhere, and is probably best to avoid creation in
those select methods anyway.
Dan Brown [Mon, 26 May 2025 13:48:13 +0000 (14:48 +0100)]
Lexical: Made a range of selection improvements
Updated up/down handling to create where a selection candidate does not
exist, to apply to a wider scenario via the selectPrevious/Next methods.
Updated DOM selection change handling to identify single selections
within decorated nodes to select them in full, instead of losing
selection due to partial selection of their contents.
Updated table selection handling so that our colgroups are ignored for
internal selection focus handling.
Dan Brown [Sun, 25 May 2025 15:28:42 +0000 (16:28 +0100)]
Lexical: Updated dropdown handling to match tinymce behaviour
Now toolbars stay open on mouse-out, and close on other toolbar open,
outside click or an accepted action.
To support:
- Added new system to track and manage open dropdowns.
- Added way for buttons to optionally emit events upon actions.
- Added way to listen for events.
- Used the above to control when dropdowns should hide on action, since
some dont (like overflow containers and split dropdown buttons).
projects / bookstack / log