aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFriedemann Kleint <[email protected]>2025-05-23 13:06:42 +0200
committerFriedemann Kleint <[email protected]>2025-05-23 19:08:44 +0200
commita5a1dc4775630300fe07feb23ce87f06664e4427 (patch)
treef18c2d74ea1c8d6a76f8847df01234e4de675123
parentf58ec8bb838a7313487a457ba7b0efb8dc890688 (diff)
example dombookmarks.py: Fix disconnection warning
Use a connection id instead of try-catch Pick-to: 6.9 6.8 Change-Id: Ia76880a32df8fc6e415f056606c0df98fe772257 Reviewed-by: Ece Cinucen <[email protected]> Reviewed-by: Shyamnath Premnadh <[email protected]>
-rw-r--r--examples/xml/dombookmarks/dombookmarks.py11
1 files changed, 5 insertions, 6 deletions
diff --git a/examples/xml/dombookmarks/dombookmarks.py b/examples/xml/dombookmarks/dombookmarks.py
index f5afdeef8..4f778acbd 100644
--- a/examples/xml/dombookmarks/dombookmarks.py
+++ b/examples/xml/dombookmarks/dombookmarks.py
@@ -7,7 +7,7 @@ from __future__ import annotations
import sys
-from PySide6.QtCore import QDir, QFile, Qt, QTextStream
+from PySide6.QtCore import QDir, QFile, QObject, Qt, QTextStream
from PySide6.QtGui import QAction, QIcon, QKeySequence
from PySide6.QtWidgets import (QApplication, QFileDialog, QHeaderView,
QMainWindow, QMessageBox, QStyle, QTreeWidget,
@@ -93,6 +93,7 @@ class XbelTree(QTreeWidget):
def __init__(self, parent=None):
super().__init__(parent)
+ self._update_conn_id = None
self.header().setSectionResizeMode(QHeaderView.ResizeMode.Stretch)
self.setHeaderLabels(("Title", "Location"))
@@ -131,17 +132,15 @@ class XbelTree(QTreeWidget):
self.clear()
# It might not be connected.
- try:
- self.itemChanged.disconnect(self.update_dom_element)
- except RuntimeError:
- pass
+ if self._update_conn_id:
+ QObject.disconnect(self._update_conn_id)
child = root.firstChildElement('folder')
while not child.isNull():
self.parse_folder_element(child)
child = child.nextSiblingElement('folder')
- self.itemChanged.connect(self.update_dom_element)
+ self._update_conn_id = self.itemChanged.connect(self.update_dom_element)
return True