reduce it down a little bit #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WildCryptoFox
commented
Nov 26, 2019
| @@ -1 +1 @@ | |||
| nightly-2019-11-24 | |||
| nightly-2019-11-26 | |||
There was a problem hiding this comment.
This is the current latest nightly. Which digresses from 2019-11-25 which appears to be happy with this code.
| fn problematic_function<Space>(_volume_space: &Space, material_surface: &Polygon<f64>) | ||
| where | ||
| Space: GeometricFiniteElementSpace<f64, GeometryDim = U2, ReferenceDim = U2>, | ||
| Space: GeometricFiniteElementSpace<GeometryDim = U1/*, NodalDim = U1*/>, |
There was a problem hiding this comment.
That is very strange, as the Space type has nothing to do with the the FiniteElement impls used in the function code.
Comment on lines
+92
to
+76
| // Including this trait bound (which should already be satisfied) seems to resolve the ICE | ||
| //+ FiniteElementAllocator<U1, U1> | ||
| // | ||
| // This has the same effect as telling the compiler Space::NodalDim = U1; which was not already | ||
| // known to be satisfied. |
There was a problem hiding this comment.
Or so it does in this case.
WildCryptoFox
commented
Nov 26, 2019
| git = "https://github.com/rustsim/nalgebra.git" | ||
| rev = "31ef5f0ab02c6ecf279867f07cd63e16cece8b75" | ||
| default-features = false | ||
| features = ["serde-serialize", "default"] |
There was a problem hiding this comment.
VERY weird that "default" acts differently to "std" here. Replacing this with "std" does not trigger the ICE.
WildCryptoFox
commented
Nov 26, 2019
| material_surface_element | ||
| .map_reference_coords(&eta) | ||
| .magnitude(); | ||
| material_surface_element.map_reference_coords().magnitude(); |
There was a problem hiding this comment.
This is the same bug as above.
|
Thanks a lot @WildCryptoFox! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.