Support for Text?

[bgamari]

It would be great to merge the regex-tdfa-text package.

[neongreen]

@bgamari Do you remember why your regex-tdfa-text patches weren't accepted in the first place?

[bgamari]

They weren't my patches. Regardless, I have no idea why they weren't accepted. I suspect they just appeared after maintenance of the package tapered off, but I could be wrong.

[neongreen]

They weren't my patches.

Oh, sorry, I confused the nicks.

I suspect they just appeared after maintenance of the package tapered off, but I could be wrong.

The thing is that when I looked at regex-tdfa-text (a year ago), I think I saw a discussion of some problems with it, so I'm not sure. Anyway, I'll research it.

[asr]

I also think it would be great to merge the regex-tdfa-text package (for example, right now, regex-tdfa supports GHC 8.8.1 but regex-tdfa-text doesn't).

Blocking agda/agda#3725.

[neongreen]

I will accept a PR that merges regex-tdfa-text (e.g. from https://github.com/hackage-trustees/regex-tdfa-text) into this package and makes sure that the tests in test/ are ran on Text.Regex.TDFA.Text in addition to Text.Regex.TDFA.

[asr]

From regex-tdfa-text:

This should be part of regex-tdfa package. But my patches are not accepted yet. So, I made a separate package. If you are interested in my patches, see http://hub.darcs.net/shelarcy/regex-base and http://hub.darcs.net/shelarcy/regex-tdfa.

By browsing in http://hub.darcs.net/shelarcy/regex-tdfa, we can find the change Add text support. Maybe it is easier to prepare the PR from this change.

[neongreen]

Moving over to haskell-hvr/regex-tdfa#4.