-
Notifications
You must be signed in to change notification settings - Fork 5
test: uploaded files #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Tavo Nieves J <[email protected]>
@fkupper It seems you forgot a I changed another Finally, i ran these tests locally (on Windows) and they passed, so there must be a problem with the CI config. I tried to fix it with |
@TavoNiievez I've added two changes to help understand the error.
|
@TavoNiievez can you remove my restriction to run CI tests at least for the duration of this PR? |
@fkupper I'm not sure how to do that (or if possible). I think GitHub made that change because some people were taking advantage of builds to mine cryptocurrencies. Have you tried activating Actions on your fork? |
It seems that that was the problem, the last execution was correct, the only thing that generates a little doubt is knowing if |
What do you think of using and |
I've pushed the changes with this suggestion so you can have a look. |
$response = json_decode($response, true); | ||
|
||
$last_error = json_last_error(); | ||
if ($last_error !== JSON_ERROR_NONE) { | ||
$this->fail("Failed to parse response from uploaded-files endpoint with json error code {$last_error}"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing.
Since we are on PHP 7.3+, how about using JSON_THROW_ON_ERROR
instead?
See this ref link.
@fkupper good work! thanks for your patience in this matter. |
You're welcome! |
Covers Codeception/module-laravel#26