format rsx using rustfmt

[dvc94ch]

Opened an issue here rust-lang/rustfmt#5656, although the P-low label doesn't give me much confidence that it will be implemented soon. Thought it might be of interest, feel free to close, since there is nothing immediately actionable.

[ealmloff]

There are a few long standing issues related to formatting macros in rustfmt (rust-lang/rustfmt#3705, rust-lang/rustfmt#5254). This would be great!... but I don't expect it to be implemented for a while if it ever is. I think there was another issue where this was specifically not planed which is why Dioxus autofmt was created instead of a more general solution, but I can't find it now

[dvc94ch]

alternatively could autofmt be turned into a cli tool called rsxfmt? so in ci I could run rsxfmt && rustfmt. would also fit my workflow better to have a standalone tool, as I don't use vscode.

[paultiplady]

This is timely; I'm just starting exploring Dioxus (fairly new to Rust) and this is an immediately obvious issue with the Rust toolchain vs. the standard modern JSX experience.

My dream solution would be something that can be tied into the IDE autocomplete functionality as well as just providing auto-formatting.

[jkelleyrtp]

The dioxus CLI tool has a fmt command used by the extension to format individual pieces of rsx. We could/should change the default behavior of dioxus fmt to format your project in the same way that rustfmt does.

[tkubicz]

@jkelleyrtp is there any guide/doc how to use it? My dioxus-cli unfortunatelly doesn't seem to have fmt command.

→ dioxus fmt
error: Found argument 'fmt' which wasn't expected, or isn't valid in this context

[jkelleyrtp]

@jkelleyrtp is there any guide/doc how to use it? My dioxus-cli unfortunatelly doesn't seem to have fmt command.

→ dioxus fmt
error: Found argument 'fmt' which wasn't expected, or isn't valid in this context

Dioxus fmt is in the most recent version of the CLI (0.3).You might need to update using cargo install --force dioxus-cli.

[jkelleyrtp]

I just put up a draft PR on the CLI tool that enables project autoformatting. I have yet to enable mod descending, but right now it uses .gitignore. It also queues all the files in an async stream so tokio will naturally multithread the formatting process.

https://github.com/DioxusLabs/cli/pull/92

---

The PR has been merged - I fixed a lot of little corner cases in autofmt. We still need to handle a few more cases in autofmt (if chain and for loop)

[jkelleyrtp]

We can't really do anything about this without rustfmt adding hooks, so, use dioxus fmt