Skip to content

fix: android 35 keyboard issues #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025
Merged

Conversation

isekovanic
Copy link
Contributor

@isekovanic isekovanic commented Jun 23, 2025

🎯 Goal

This PR fixes an issue with our KeyboardCompatibleView within the SDK that surfaced on Android 15 in the RN upstream.

The actual open issue can be seen here, while the Android changes that triggered this can be found here.

This fix should:

  • Fix some KeyboardCompatibleView edge cases and introduce slight performance improvements with skipping unnecessary state updates when they aren't needed
  • Do the RN CLI adjustments in the sample apps required for this to work (until it's fixed upstream)
  • Showcases a custom Expo plugin that does the same for the Expo sample app

Should also close this Zendesk ticket.

Docs PR here.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@Stream-SDK-Bot
Copy link
Contributor

SDK Size

title develop branch diff status
js_bundle_size 450 KB 450 KB 0 B 🟢

@isekovanic isekovanic merged commit 241d1db into develop Jun 25, 2025
8 checks passed
@isekovanic isekovanic deleted the fix/android-35-keyboard-issues branch June 25, 2025 07:02
@github-actions github-actions bot mentioned this pull request Jun 26, 2025
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 7.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants