Skip to content
This repository was archived by the owner on Mar 20, 2025. It is now read-only.

Refactor keyword argument processing, remove applyexp #62

Merged
merged 16 commits into from
Feb 15, 2024
Merged

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Feb 14, 2024

@mtfishman mtfishman changed the title Refactor keyword arguments Refactor keyword argument processing Feb 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (61f64f0) 86.50% compared to head (37a795c) 84.09%.

Files Patch % Lines
src/defaults.jl 76.47% 8 Missing ⚠️
src/tdvp_generic.jl 80.00% 3 Missing ⚠️
src/tdvporder.jl 25.00% 3 Missing ⚠️
src/tdvp.jl 85.71% 2 Missing ⚠️
src/tdvp_step.jl 71.42% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   86.50%   84.09%   -2.41%     
==========================================
  Files          17       17              
  Lines         600      522      -78     
==========================================
- Hits          519      439      -80     
- Misses         81       83       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title Refactor keyword argument processing Refactor keyword argument processing, remove applyexp Feb 15, 2024
@mtfishman
Copy link
Member Author

@emstoudenmire note that I've removed the applyexp backend to simplify this codebase.

@mtfishman mtfishman merged commit 449e3a4 into main Feb 15, 2024
@mtfishman mtfishman deleted the kwarg_refactor branch February 15, 2024 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants