Skip to content

Commit 0ad5cd6

Browse files
committed
Simplify initial index labels PR
* removed support for nested traversal of `index_labels`. Support for this can be added later but it required making a lot of decisions about managing labels that up front that would be better addressed through iterative PRs * removed `has_index_labels`. There are some odd corner cases for this one. Particularly for `SubArrays` where the presence of labels in the parent don't always have a clear way of propagating forward. Again, we can address this one but it will take some decisions about how labels are propagated. * `UnlabelledIndices` and `LabelledIndices` are types that provide a more clear structure to what a label is and how they are accessed. For now access only is supported through `getlabels` and `setlabels`
1 parent 809839b commit 0ad5cd6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/ArrayInterface.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import ArrayInterfaceCore: allowed_getindex, allowed_setindex!, aos_to_soa, buff
77
safevec, zeromatrix, ColoringAlgorithm, fast_scalar_indexing, parameterless_type,
88
ndims_index, ndims_shape, is_splat_index, is_forwarding_wrapper, IndicesInfo, childdims,
99
parentdims, map_tuple_type, flatten_tuples, GetIndex, SetIndex!, IndexLabel,
10-
LabelledIndices, getlabels, UnlabelledIndices, defines_strides, stride_preserving_index
10+
LabelledIndices, getlabels, setlabels!, UnlabelledIndices, defines_strides, stride_preserving_index
1111

1212
# ArrayIndex subtypes and methods
1313
import ArrayInterfaceCore: ArrayIndex, MatrixIndex, VectorIndex, BidiagonalIndex, TridiagonalIndex

0 commit comments

Comments
 (0)