Generate reverse
for StaticVector
types
#802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hat tip to @MasonProtter for this neat little trick.
This PR eliminates allocations in
SVector
containers that hold a single bits eltype and speeds them up by 1000 times the speed of the base branch in some cases:Benchmarking
v = SVector(Tuple(randn(200)))
base branch:
sc/reverse-speedup:
Benchmarking
v = SVector(Char.(rand('a':'z', 200))...)
:base branch:
sc/reverse-speedup:
For non-bits types, the speedup and allocation saves are closer to 100 times those of the base branch:
Benchmarking
v = SVector(("a", :b, randn(198)...))
(which has aneltype
ofAny
):base branch:
sc/reverse-speedup:
Benchmark information: