-
Notifications
You must be signed in to change notification settings - Fork 8
WIP: Updating FixedSizeStrings.jl #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be worth naming the package and primary type |
I've been speaking with Scott Paul Johnson and I think I might rewrite all of this completely to use a tuple of UInt64 as the underlying storage. I also think this should probably live in a new package over at the JuliaString github org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress, but here are a few of the changes so far and proposed changes.
Changes so far
SizedStrings
SizedArray
from StaticArrays.jl and is more concise / easier to write thanFixedSizeString
.SizedString("ferafver")
for two reasons:Planned Changes
MaxSizeString
(my personal biggest priority at the moment)sized"some string"
possible.Let me know what you think :)