Skip to content

WIP: Updating FixedSizeStrings.jl #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from

Conversation

Luapulu
Copy link

@Luapulu Luapulu commented Nov 21, 2020

This is still a work in progress, but here are a few of the changes so far and proposed changes.

Changes so far

  • Rename package and primary type to SizedStrings
    • This mirrors SizedArray from StaticArrays.jl and is more concise / easier to write than FixedSizeString.
  • Significantly expand test coverage
    • I'll need to add codecov back in to get the exact coverage, but it's probably near 100% now.
  • Replace REQUIRE file with Project.toml
  • Removed implicit constructor SizedString("ferafver") for two reasons:
    1. Type instability
    2. Is consistent with StaticArrays.jl, as they also don't have an implicit constructor.

Planned Changes

  • - Add docs
  • - Add basic usage section to README
  • - Add MaxSizeString (my personal biggest priority at the moment)
  • - Use Github actions for CI (add badges back in)
  • - Add convenience macro to make sized"some string" possible.
  • - Write efficient comparison, map, filter functions, which make use of statically known size.

Let me know what you think :)

@Luapulu
Copy link
Author

Luapulu commented Nov 22, 2020

It might be worth naming the package and primary type StaticString as well.

@Luapulu
Copy link
Author

Luapulu commented Nov 23, 2020

I've been speaking with Scott Paul Johnson and I think I might rewrite all of this completely to use a tuple of UInt64 as the underlying storage. I also think this should probably live in a new package over at the JuliaString github org.

@Luapulu Luapulu closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant