Add tests and make them pass on v0.4 - v0.6 #16
Conversation
|
This does pass CI BTW: https://travis-ci.org/jgoldfar/DBI.jl/builds/253428805 and will be required to get PostgreSQL passing: https://travis-ci.org/jgoldfar/PostgreSQL.jl in particular https://travis-ci.org/jgoldfar/PostgreSQL.jl/jobs/253423098 |
|
I would 1) drop 0.4 and 2) put more specific version bounds on DataFrames and DataArrays (I'm suspicious that many versions will fail here). |
|
I'm not sure how to test specific version compatibility of the package with others. Is there a standard way to do it other than pinning a version locally and checking that the package loads? |
|
It's either that or look through the code |
…r this package. Also remove v0.4 support.
|
Just updated this branch removing v0.4 support as well as the dependence on DataFrames and DataArrays, which were not explicitly used anywhere. Maybe they were meant to be? Travis (https://travis-ci.org/jgoldfar/DBI.jl/builds/258300798) reports all good without them... |
|
Thanks to @amgad-naiem for helping remove the remaining depwarns on v0.6 and schooling me a bit on git/github. Anything remaining to do here? |
No description provided.