Skip to content

Check that the derivative is nonnegative, and handle the case q == 0 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2019
Merged

Check that the derivative is nonnegative, and handle the case q == 0 #34

merged 3 commits into from
Aug 6, 2019

Conversation

wesselb
Copy link
Member

@wesselb wesselb commented Aug 4, 2019

Closes #32

@wesselb wesselb requested a review from willtebbutt August 4, 2019 15:27
@codecov-io
Copy link

codecov-io commented Aug 4, 2019 •
edited
Loading

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         126    128    +2     
=====================================
+ Hits          126    128    +2
Impacted Files Coverage Δ
src/methods.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e4b18c...43fedf2. Read the comment docs.

willtebbutt
willtebbutt approved these changes Aug 4, 2019
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided that @jessebett is happy that this resolves his issue.

@jessebett
Copy link

The default behaviour of derivative(f,0) should not be an assertion error, it should just return the function evaluation.

@willtebbutt
Copy link
Member

The default behaviour of derivative(f,0) should not be an assertion error, it should just return the function evaluation.

I can see the appeal. @wesselb any thoughts?

@wesselb wesselb changed the title Check that the derivative is strictly greater than zero Check that the derivative is nonnegative, and handle the case q == 0 Aug 5, 2019
@wesselb
Copy link
Member Author

wesselb commented Aug 5, 2019 •
edited
Loading

Also sounds fair to me. @jessebett, how does the most recent commit look?

@nickrobinson251
Copy link
Contributor

FYI I will register FiniteDifferences.jl as a a new package with a new UUID and version 0.1 (because renaming a package is hard/confusing/undefined behaviour AFAIU)

Should I wait for this PR before doing that?

@jessebett
Copy link

@wesselb Looks good! Thanks!

@willtebbutt willtebbutt merged commit 94f4a84 into master Aug 6, 2019
@willtebbutt willtebbutt mentioned this pull request Aug 6, 2019
Merged
@nickrobinson251 nickrobinson251 mentioned this pull request Aug 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtebbutt willtebbutt willtebbutt approved these changes

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do I choose method order to avoid NaN?
6 participants
@wesselb @codecov-io @jessebett @willtebbutt @nickrobinson251 @oxinabox