Add README and LICENSE #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f40d94e to
4bab6b3
Compare
mortenpi
reviewed
Nov 3, 2018
There was a problem hiding this comment.
LGTM. Needs docs though.
Also, a thing to note is that GitHub flavored Markdown is a bit different from what the Julia parser expects, so the document may not look the way it should when included with README (e.g. the [][] link shortcuts are not supported in Julia).
Right, I'll add a note in the docs about this, but this should at least replicate the behavior lost in JuliaLang/julia#25772 |
the package README.md and LICENSE.md in docstrings.
4bab6b3 to
cb3c24b
Compare
mortenpi
reviewed
Nov 4, 2018
cb3c24b to
06832cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
READMEandLICENSEto make it possible to splice in the packageREADME.mdandLICENSE.mdin docstrings.